Skip to contentSkip to conversation

gutenprint: fix host installation

PATCH New Baruch Siach 3 participants 4 messages Apr 12, 2016 – Apr 14, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gutenprint: fix host installation

Set DESTDIR to avoid installation attempt into build host directories.

Fixes:
http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/

---
 package/gutenprint/gutenprint.mk | 2 ++
 1 file changed, 2 insertions(+)
package/gutenprint/gutenprint.mk +2 -0
index 7e3024d400af..2ee411f66cc3 100644
@@ -69,6 +69,8 @@ HOST_GUTENPRINT_CONF_OPTS = \
 	--disable-testpattern \
 	--without-cups
 
+HOST_GUTENPRINT_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
+
 # Needed by autoreconf
 define GUTENPRINT_CREATE_M4_DIR
 	mkdir -p $(@D)/m4local
Signature · 1 line
2.8.0.rc3
#1 lore raw

PATCH 1/1 gutenprint: fix host installation

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Set DESTDIR to avoid installation attempt into build host directories. Fixes:
http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/

Hmm, this sounds fishy. DESTDIR is normally only needed when the installation directory is different from where the files will be used at runtime (E.G. like for our target installation). Host-gutenprint should be configured to install and run in HOST_DIR, so if you pass DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..

The error sounds more like it misdetects the location of (host-)cups. We do pass --without-cups to the configure script though, so I wonder why it still wants to install cups files.

Care to take a 2nd look?

Quoted 24 lines
---
 package/gutenprint/gutenprint.mk | 2 ++
 1 file changed, 2 insertions(+)
package/gutenprint/gutenprint.mk +2 -0
index 7e3024d400af..2ee411f66cc3 100644
@@ -69,6 +69,8 @@ HOST_GUTENPRINT_CONF_OPTS = \
 	--disable-testpattern \
 	--without-cups
 
+HOST_GUTENPRINT_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
+
 # Needed by autoreconf
 define GUTENPRINT_CREATE_M4_DIR
 	mkdir -p $(@D)/m4local
Signature · 6 lines
2.8.0.rc3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 gutenprint: fix host installation

Peter Korsgaard wrote,

Quoted 16 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Set DESTDIR to avoid installation attempt into build host directories. Fixes:
http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/

Hmm, this sounds fishy. DESTDIR is normally only needed when the installation directory is different from where the files will be used at runtime (E.G. like for our target installation). Host-gutenprint should be configured to install and run in HOST_DIR, so if you pass DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..

Quoted 5 lines

The error sounds more like it misdetects the location of (host-)cups. We do pass --without-cups to the configure script though, so I wonder why it still wants to install cups files.

Care to take a 2nd look?

Have you seen this try to fix it?
https://patchwork.ozlabs.org/patch/605452/

best regards
Waldemar

#3 lore raw

PATCH 1/1 gutenprint: fix host installation

Hi Waldemar,

Quoted 16 lines · Waldemar Brodkorb
Quoted 16 lines
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

Set DESTDIR to avoid installation attempt into build host directories. Fixes:
http://autobuild.buildroot.net/results/bca/bca299631949c7699682af41e3f1373dd10866ed/
http://autobuild.buildroot.net/results/294/294dfc02ee95caaac4be9fd632c399bb2c7d3f83/
http://autobuild.buildroot.net/results/8ce/8ce0c14d92f34245a87758db60c618916be48586/

Hmm, this sounds fishy. DESTDIR is normally only needed when the installation directory is different from where the files will be used at runtime (E.G. like for our target installation). Host-gutenprint should be configured to install and run in HOST_DIR, so if you pass DESTDIR=$(HOST_DIR) the files ends up in $(HOST_DIR)/$(HOST_DIR)/usr/..

Quoted 8 lines
Quoted 5 lines

The error sounds more like it misdetects the location of (host-)cups. We do pass --without-cups to the configure script though, so I wonder why it still wants to install cups files.

Care to take a 2nd look?

Have you seen this try to fix it?
https://patchwork.ozlabs.org/patch/605452/

That looks like a better fix to me.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -