gpio: brcmstb: missing error code

PATCH In review Dan Carpenter 2 participants 3 messages Apr 15, 2016

Subsystems (4)

Kernel janitors GPIO Broadcom BCM7XXX Arm architecture Broadcom brcmstb GPIO driver

lore

Share & tools

lore

Dan Carpenter

author

2016-04-15 14:45 UTC #0 lore raw

PATCH 1/1 gpio: brcmstb: missing error code

We should set the error code before returning here. Otherwise "err" could be uninitialized or zero.

Signed-off-by Dan Carpenter <[email protected]>

drivers/gpio/gpio-brcmstb.c +1 -0

index 42d51c5..e648914 100644
@@ -461,6 +461,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
 		bank->id = num_banks;
 		if (bank_width <= 0 || bank_width > MAX_GPIO_PER_BANK) {
 			dev_err(dev, "Invalid bank width %d\n", bank_width);
+			err = -EINVAL;
 			goto fail;
 		} else {
 			bank->width = bank_width;

Florian Fainelli

2016-04-15 22:04 UTC #1 lore raw

Quoted 4 lines · Dan Carpenter

We should set the error code before returning here. Otherwise "err" could be uninitialized or zero.
Signed-off-by Dan Carpenter <[email protected]>

Axel just sent an identical patch which Linus picked already:

http://www.spinics.net/lists/linux-gpio/msg13728.html

Thanks Dan!

Signature · 1 line

Florian

Dan Carpenter

author

2016-04-15 22:25 UTC #2 lore raw

Quoted 9 lines · Florian Fainelli

Quoted 4 lines · Dan Carpenter
We should set the error code before returning here. Otherwise "err" could be uninitialized or zero.
Signed-off-by Dan Carpenter <[email protected]>
Axel just sent an identical patch which Linus picked already:
http://www.spinics.net/lists/linux-gpio/msg13728.html

Heh. Weird timing. That bug has been there for 11 months...

regards,
dan carpenter