memcached: fix musl build
PATCH 1/1 memcached: fix musl build
Add a patch fixing pre-processor warnings that breaks the build. The patch is pending upstream.
--- .../memcached/0001-fix-build-with-musl-libc.patch | 78 ++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch
package/memcached/0001-fix-build-with-musl-libc.patch new file +78 -0
@@ -0,0 +1,78 @@ +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001 +From: Natanael Copa <[email protected]> +Date: Mon, 18 Jan 2016 12:11:48 +0100 +Subject: [PATCH] fix build with musl libc + +musl libc will warn if you include sys/signal.h instead of signal.h as +specified by posix. Build will fail due to -Werror explicitly beeing +set. + +Fix it by use the posix location. + +fixes #138 + +Signed-off-by: Baruch Siach <[email protected]> +--- +Patch status: pending (https://github.com/memcached/memcached/pull/139) + + assoc.c | 2 +- + items.c | 2 +- + slabs.c | 2 +- + 3 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/assoc.c b/assoc.c +index e6cf09b64e8c..9fff38fe01d6 100644 +--- a/assoc.c ++++ b/assoc.c +@@ -14,8 +14,8 @@ + #include "memcached.h" + #include <sys/stat.h> + #include <sys/socket.h> +-#include <sys/signal.h> + #include <sys/resource.h> ++#include <signal.h> + #include <fcntl.h> + #include <netinet/in.h> + #include <errno.h> +diff --git a/items.c b/items.c +index 199dc9fa6e6b..7040777ab0fb 100644 +--- a/items.c ++++ b/items.c +@@ -2,13 +2,13 @@ + #include "memcached.h" + #include <sys/stat.h> + #include <sys/socket.h> +-#include <sys/signal.h> + #include <sys/resource.h> + #include <fcntl.h> + #include <netinet/in.h> + #include <errno.h> + #include <stdlib.h> + #include <stdio.h> ++#include <signal.h> + #include <string.h> + #include <time.h> + #include <assert.h> +diff --git a/slabs.c b/slabs.c +index 31e85f6ec21d..bfafe5d0fdde 100644 +--- a/slabs.c ++++ b/slabs.c +@@ -10,7 +10,6 @@ + #include "memcached.h" + #include <sys/stat.h> + #include <sys/socket.h> +-#include <sys/signal.h> + #include <sys/resource.h> + #include <fcntl.h> + #include <netinet/in.h> +@@ -18,6 +17,7 @@ + #include <stdlib.h> + #include <stdio.h> + #include <string.h> ++#include <signal.h> + #include <assert.h> + #include <pthread.h> + +-- +2.8.0.rc3 +
Signature · 1 line
2.8.0.rc3
PATCH 1/1 memcached: fix musl build
Hello,
Quoted 8 lines · Baruch Siach
Add a patch fixing pre-processor warnings that breaks the build. The patch is pending upstream.
Signed-off-by Baruch Siach <[email protected]>--- .../memcached/0001-fix-build-with-musl-libc.patch | 78 ++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patch
I've added a reference to the autobuilder failure being fixed by this patch, and applied. Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 memcached: fix musl build
In reply to Baruch SiachQuoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Add a patch fixing pre-processor warnings that breaks the build. The patch is pending upstream.
Signed-off-by Baruch Siach <[email protected]>--- .../memcached/0001-fix-build-with-musl-libc.patch | 78 ++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patchpackage/memcached/0001-fix-build-with-musl-libc.patch new file +0
-0
package/memcached/0001-fix-build-with-musl-libc.patch line 8
Quoted 8 lines
package/memcached/0001-fix-build-with-musl-libc.patch new file +8
-0@@ -0,0 +1,78 @@ +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001 +From: Natanael Copa <[email protected]> +Date: Mon, 18 Jan 2016 12:11:48 +0100 +Subject: [PATCH] fix build with musl libc + +musl libc will warn if you include sys/signal.h instead of signal.h as +specified by posix. Build will fail due to -Werror explicitly beeing +set.
Is there any way to disable -Werror? -Werror should imho not be used for any released SW as it tends to break the build time and again.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 memcached: fix musl build
Hi Peter,
Quoted 21 lines · Peter Korsgaard
Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Baruch" == Baruch Siach <[email protected]> writes:
Add a patch fixing pre-processor warnings that breaks the build. The patch is pending upstream.
Signed-off-by Baruch Siach <[email protected]>--- .../memcached/0001-fix-build-with-musl-libc.patch | 78 ++++++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 package/memcached/0001-fix-build-with-musl-libc.patchpackage/memcached/0001-fix-build-with-musl-libc.patch new file +3
-0@@ -0,0 +1,78 @@ +From 2137a608c77c467200d73469f723ba97ff6b3511 Mon Sep 17 00:00:00 2001 +From: Natanael Copa <[email protected]> +Date: Mon, 18 Jan 2016 12:11:48 +0100
Quoted 8 lines
package/memcached/0001-fix-build-with-musl-libc.patch line 8
Quoted 5 lines
package/memcached/0001-fix-build-with-musl-libc.patch new file +5
-0+Subject: [PATCH] fix build with musl libc + +musl libc will warn if you include sys/signal.h instead of signal.h as +specified by posix. Build will fail due to -Werror explicitly beeing +set.Is there any way to disable -Werror? -Werror should imho not be used for any released SW as it tends to break the build time and again.
Removing -Werror requires patching configure.ac. It's not required at this point with this patch applied. We can always do it later if it's needed.
baruch
Signature · 3 lines
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -