Skip to contentSkip to conversation

lpfc: remove incorrect lockdep assertion

PATCH Applied Sebastian Herbszt 3 participants 3 messages Apr 17, 2016 – Apr 26, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lpfc: remove incorrect lockdep assertion

Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix the comment which resulted in this mistake.

Fixes 1c2ba475eb0e ("lpfc: Add lockdep assertions")
drivers/scsi/lpfc/lpfc_sli.c +3 -6
diff -uNr -U 5 a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
@@ -1998,24 +1998,21 @@
 /**
  * lpfc_sli_hbqbuf_find - Find the hbq buffer associated with a tag
  * @phba: Pointer to HBA context object.
  * @tag: Tag of the hbq buffer.
  *
- * This function is called with hbalock held. This function searches
- * for the hbq buffer associated with the given tag in the hbq buffer
- * list. If it finds the hbq buffer, it returns the hbq_buffer other wise
- * it returns NULL.
+ * This function searches for the hbq buffer associated with the given tag in
+ * the hbq buffer list. If it finds the hbq buffer, it returns the hbq_buffer
+ * otherwise it returns NULL.
  **/
 static struct hbq_dmabuf *
 lpfc_sli_hbqbuf_find(struct lpfc_hba *phba, uint32_t tag)
 {
 	struct lpfc_dmabuf *d_buf;
 	struct hbq_dmabuf *hbq_buf;
 	uint32_t hbqno;
 
-	lockdep_assert_held(&phba->hbalock);
-
 	hbqno = tag >> 16;
 	if (hbqno >= LPFC_MAX_HBQS)
 		return NULL;
 
 	spin_lock_irq(&phba->hbalock);
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Sonntag, 17. April 2016 13:27:27 CEST Sebastian Herbszt wrote:

Remove incorrect lockdep assertion from lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix the comment which resulted in this mistake.

Fixes 1c2ba475eb0e ("lpfc: Add lockdep assertions")

Good catch,

Signature · 11 lines
Johannes Thumshirn                                                                                Storage
[email protected]                                                             +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Sebastian Herbszt
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Sebastian" == Sebastian Herbszt <[email protected]> writes:

Sebastian> Remove incorrect lockdep assertion from Sebastian> lpfc_sli_hbqbuf_find() which acquires the hbalock itself. Fix Sebastian> the comment which resulted in this mistake.

Applied to 4.7/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering