Skip to contentSkip to conversation

drm/i915/kbl: Reset secondary power well requests left on by DMC/KVMR

PATCH In review Imre Deak 2 participants 4 messages Apr 15, 2016 – Apr 18, 2016

Subsystems (2)
lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 drm/i915/kbl: Reset secondary power well requests left on by DMC/KVMR

The workaround added in c6782b76d31a ("drm/i915/gen9: Reset secondary power well requests left on by DMC/KVMR") needs to be applied on Kabylake too as shown by the corresponding timeout errors about power well 1 and MISC IO power well disabling in the latest CI run.

CC Patrik Jakobsson <[email protected]>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -1
index 259f66f..1242fb5 100644
@@ -709,7 +709,7 @@ static void skl_set_power_well(struct drm_i915_private *dev_priv,
 			DRM_DEBUG_KMS("Disabling %s\n", power_well->name);
 		}
 
-		if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
+		if (IS_GEN9(dev_priv))
 			gen9_sanitize_power_well_requests(dev_priv, power_well);
 	}
 
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Imre Deak

The workaround added in c6782b76d31a ("drm/i915/gen9: Reset secondary power well requests left on by DMC/KVMR") needs to be applied on Kabylake too as shown by the corresponding timeout errors about power well 1 and MISC IO power well disabling in the latest CI run.

CC Patrik Jakobsson <[email protected]>

Ok, so this seems to affect all DMC firmwares we have so far? Any news on the bug report?

Quoted 20 lines
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -1
index 259f66f..1242fb5 100644
@@ -709,7 +709,7 @@ static void skl_set_power_well(struct drm_i915_private *dev_priv,
 			DRM_DEBUG_KMS("Disabling %s\n", power_well->name);
 		}
 
-		if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
+		if (IS_GEN9(dev_priv))
 			gen9_sanitize_power_well_requests(dev_priv, power_well);
 	}
 
Signature · 1 line
2.5.0
Signature · 5 lines
Intel Sweden AB Registered Office: Knarrarnasgatan 15, 164 40 Kista, Stockholm, Sweden Registration Number: 556189-6027 
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw
Quoted 9 lines · Patrik Jakobsson
Quoted 8 lines · Imre Deak

The workaround added in c6782b76d31a ("drm/i915/gen9: Reset secondary power
well requests left on by DMC/KVMR") needs to be applied on Kabylake too as
shown by the corresponding timeout errors about power well 1 and MISC IO
power well disabling in the latest CI run.

Quoted 5 lines
Quoted 2 lines
CC Patrik Jakobsson <[email protected]>

Ok, so this seems to affect all DMC firmwares we have so far? Any news on the bug report?

The problem was confirmed, but it's not clear whether this will be fixed in the firmware for SKL/BXT (since we can work around it in the driver). We can hope for a fix on later platforms.

Quoted 7 lines
Quoted 5 lines

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-

 1 file changed, 1

insertion(+), 1 deletion(-)

Quoted 17 lines
Quoted 10 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
index 259f66f..1242fb5 100644
@@ -709,7 +709,7 @@ static void skl_set_power_well(struct drm_i915_private *dev_priv,
  			DRM_DEBUG_KMS("Disabling %s\n", power_well->name);
  		}

drivers/gpu/drm/i915/intel_runtime_pm.c +1 -1
-		if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
+		if (IS_GEN9(dev_priv))
Quoted 6 lines

  gen9_sanitize_power_well_requests(dev_priv, power_well); }

Signature · 1 line
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#3 lore raw
In reply to Patrik Jakobsson
Quoted 9 lines · Patrik Jakobsson
Quoted 8 lines · Imre Deak

The workaround added in c6782b76d31a ("drm/i915/gen9: Reset secondary power
well requests left on by DMC/KVMR") needs to be applied on Kabylake too as
shown by the corresponding timeout errors about power well 1 and MISC IO
power well disabling in the latest CI run.

Quoted 8 lines
Quoted 2 lines
CC Patrik Jakobsson <[email protected]>

Ok, so this seems to affect all DMC firmwares we have so far? Any news on the
bug report?

I pushed this to -dinq thanks for the review.

Jani, Daniel: I made a mistake pushing this before getting the CI result. It wasn't either picked up by PW, so not sure about its status. What can we do, revert/resubmit or wait for the next regular CI result?

Sorry for the mess,
Imre

Quoted 16 lines
Quoted 16 lines

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
index 259f66f..1242fb5 100644
@@ -709,7 +709,7 @@ static void skl_set_power_well(struct
 drm_i915_private *dev_priv,
  			DRM_DEBUG_KMS("Disabling %s\n",
 power_well->name);
  		}

drivers/gpu/drm/i915/intel_runtime_pm.c +0 -1
-		if (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
+		if (IS_GEN9(dev_priv))

  gen9_sanitize_power_well_requests(dev_priv , power_well);
  }

Signature · 1 line
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx