Skip to contentSkip to conversation

package/x11r7/xdriver_xf86-video-mga: disable DRI support when not available

PATCH New Bernd Kuhls 3 participants 6 messages Nov 8, 2015 – May 31, 2016

lore
Share & tools
lore

Bernd Kuhls

author
#0 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-mga: disable DRI support when not available

configure.ac is not cross-compile aware, a patch fixing DRI detection was added in 2009
http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2

assuming DRI support being present if DRI support was not disabled.

By default configure.ac assumes "auto" which leads to DRI support being enabled even if DRI support is disabled in buildroot config. This patch adds --disable-dri to really disable DRI support, fixes:

http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/
http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/
http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/
http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/
http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk +4 -0
index dcf751c..771ec18 100644
@@ -12,4 +12,8 @@ XDRIVER_XF86_VIDEO_MGA_LICENSE_FILES = COPYING
 XDRIVER_XF86_VIDEO_MGA_AUTORECONF = YES
 XDRIVER_XF86_VIDEO_MGA_DEPENDENCIES = xserver_xorg-server libdrm xproto_fontsproto xproto_glproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xf86driproto xproto_xproto
 
+ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),)
+XDRIVER_XF86_VIDEO_MGA_CONF_OPTS = --disable-dri
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
2.6.2
author
#1 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-siliconmotion: Fix compile warnings being treated as error

Fixes
http://autobuild.buildroot.net/results/059/059d771cb39532dee73a5f50e24b3441005ed38b/
http://autobuild.buildroot.net/results/542/5429dd3f07430cf1487a8cfa82ba55e66a640473/
http://autobuild.buildroot.net/results/073/073105a692033665d31b2dc034eff2e0fdca7f10/
http://autobuild.buildroot.net/results/018/01805d60b8b046122d357e2559268e8a45dcf9d3/
and many others

Signed-off-by Bernd Kuhls <[email protected]>
---
 .../xdriver_xf86-video-siliconmotion.mk                                 | 2 ++
 1 file changed, 2 insertions(+)
package/x11r7/xdriver_xf86-video-siliconmotion/xdriver_xf86-video-siliconmotion.mk +2 -0
index 2aa22ae..f8ea403 100644
@@ -11,4 +11,6 @@ XDRIVER_XF86_VIDEO_SILICONMOTION_LICENSE = MIT
 XDRIVER_XF86_VIDEO_SILICONMOTION_LICENSE_FILES = COPYING
 XDRIVER_XF86_VIDEO_SILICONMOTION_DEPENDENCIES = xserver_xorg-server xproto_fontsproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xproto
 
+XDRIVER_XF86_VIDEO_SILICONMOTION_CONF_OPTS = --disable-selective-werror
+
 $(eval $(autotools-package))
Signature · 1 line
2.6.2
Applied
#2 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-siliconmotion: Fix compile warnings being treated as error

Dear Bernd Kuhls,

Quoted 11 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/059/059d771cb39532dee73a5f50e24b3441005ed38b/
http://autobuild.buildroot.net/results/542/5429dd3f07430cf1487a8cfa82ba55e66a640473/
http://autobuild.buildroot.net/results/073/073105a692033665d31b2dc034eff2e0fdca7f10/
http://autobuild.buildroot.net/results/018/01805d60b8b046122d357e2559268e8a45dcf9d3/
and many others

Signed-off-by Bernd Kuhls <[email protected]>
---
 .../xdriver_xf86-video-siliconmotion.mk                                 | 2 ++
 1 file changed, 2 insertions(+)

Applied, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-mga: disable DRI support when not available

In reply to Bernd Kuhls

Bernd, All,

On 2015-11-08 18:44 +0100, Bernd Kuhls spake thusly:

Quoted 9 lines

configure.ac is not cross-compile aware, a patch fixing DRI detection was added in 2009
http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2

assuming DRI support being present if DRI support was not disabled.

By default configure.ac assumes "auto" which leads to DRI support being enabled even if DRI support is disabled in buildroot config. This patch adds --disable-dri to really disable DRI support, fixes:

Is this patch still applicable?

Regards,
Yann E. MORIN.

Quoted 30 lines

http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/
http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/
http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/
http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/
http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/

Signed-off-by Bernd Kuhls <[email protected]>
---
 package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk +4 -0
index dcf751c..771ec18 100644
@@ -12,4 +12,8 @@ XDRIVER_XF86_VIDEO_MGA_LICENSE_FILES = COPYING
 XDRIVER_XF86_VIDEO_MGA_AUTORECONF = YES
 XDRIVER_XF86_VIDEO_MGA_DEPENDENCIES = xserver_xorg-server libdrm xproto_fontsproto xproto_glproto xproto_randrproto xproto_renderproto xproto_videoproto xproto_xextproto xproto_xf86driproto xproto_xproto
 
+ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),)
+XDRIVER_XF86_VIDEO_MGA_CONF_OPTS = --disable-dri
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.6.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#4 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-mga: disable DRI support when not available

Am Tue, 19 Apr 2016 23:47:02 +0200 schrieb Yann E. MORIN:

Quoted 1 line

Is this patch still applicable?

Hi Yann,

yes, the bug still occurs:

http://autobuild.buildroot.net/
results/8ae/8aec759b0e485b2c90e2a26d60c7776c2684c44a//

and is still fixed by my patch.

Regards, Bernd

Applied
#5 lore raw

PATCH 1/1 package/x11r7/xdriver_xf86-video-mga: disable DRI support when not available

In reply to Bernd Kuhls

Hello,

Quoted 15 lines · Bernd Kuhls

configure.ac is not cross-compile aware, a patch fixing DRI detection was added in 2009
http://git.buildroot.net/buildroot/commit/package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga-1.4.9.patch?id=59b0aa7a7ee327688a77dd5d01d0b2032f6535a2

assuming DRI support being present if DRI support was not disabled.

By default configure.ac assumes "auto" which leads to DRI support being enabled even if DRI support is disabled in buildroot config. This patch adds --disable-dri to really disable DRI support, fixes:

http://autobuild.buildroot.net/results/5e5/5e5dbc30e1f30f7d2d614f4a9edb7fe439f73d61/
http://autobuild.buildroot.net/results/a8f/a8fab920599e7dc77038f3d2a9a699d6823cf3ef/
http://autobuild.buildroot.net/results/81d/81dbad489412cd28345de364624180cb082b3bb6/
http://autobuild.buildroot.net/results/53f/53fc0031da2b65890223f3183c77eb66cf0b5273/
http://autobuild.buildroot.net/results/544/54481a0f8d690e3878f4616ae1f331705e3c34be/

Quoted 4 lines
Signed-off-by Bernd Kuhls <[email protected]>
---
 package/x11r7/xdriver_xf86-video-mga/xdriver_xf86-video-mga.mk | 4 ++++
 1 file changed, 4 insertions(+)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com