DT: Fix spelling of standard properties
Subsystems (15)
cover DT: Fix spelling of standard properties
Hi all,
This patch series fixes misspellings of various standard DT properties in DT binding documentation, DTS files, and error messages. While most of these are harmless, some of them may cause hard-to-debug failures.
Please apply where appropriate.
Thanks!
P.S. I used the following to detect misspellings:
words="(address|clock|cooling|dma|gpio|index|interrupt|mbox|msi|nvmem|phy|phys|power-domain|pwm|reset|size|sleep|sound-dai|thermal-sensor)"
git grep -Ew "${words}s-names"
git grep -E "[^-]\<${words}-name\>[^-]"
git grep -Ew "#${words}s-cells" # false positive phys-cells
git grep -E "#${words}-cell\>[^-]"
git grep -w adress-cells
git grep -Ew "interrupts-(map|parent)"How can we prevent adding more of these?
One simple option is to add the offenders to scripts/spelling.txt. Alternatively, we may want to do something smarter and more DT specific?
Geert Uytterhoeven (14):
ARM: dts: STiH407: DT spelling s/interrupts-names/interrupt-names/
ARM: dts: omap5-board-common: DT spelling
s/interrupt-name/interrupt-names/
ARM: dts: omap5-cm-t54: DT spelling s/interrupt-name/interrupt-names/
ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/
arm64: dts: lg1312: DT spelling s/#interrupts-cells/#interrupt-cells/
dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/
dt: booting-without-of: DT spelling
s/#interrupt-cell/#interrupt-cells/
powerpc: dts: acadia: DT spelling
s/#interrupts-parent/#interrupt-parent/
Input: touchscreen: Broadcom iProc: DT spelling
s/clock-name/clock-names/
misc: sram: DT spelling s/#adress-cells/#address-cells/
PCI: hisi: DT spelling s/interrupts-*/interrupt-*/
phy: phy-stih41x-usb: DT spelling s/#phy-cell/#phy-cells/
rtc: rtc-sa1100: DT spelling s/interrupt-name/interrupt-names/
regulator: ti-abb: DT spelling
s/#{address,size}-cell/#{address,size}-cells/.../bindings/input/touchscreen/brcm,iproc-touchscreen.txt | 2 +- Documentation/devicetree/bindings/pci/hisilicon-pcie.txt | 12 ++++++------ Documentation/devicetree/bindings/phy/phy-stih41x-usb.txt | 2 +- .../devicetree/bindings/regulator/ti-abb-regulator.txt | 10 +++++----- Documentation/devicetree/bindings/rtc/sa1100-rtc.txt | 2 +- Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +- Documentation/devicetree/bindings/sram/sram.txt | 2 +- Documentation/devicetree/booting-without-of.txt | 2 +- arch/arm/boot/dts/omap36xx.dtsi | 2 +- arch/arm/boot/dts/omap5-board-common.dtsi | 2 +- arch/arm/boot/dts/omap5-cm-t54.dts | 2 +- arch/arm/boot/dts/stih407-pinctrl.dtsi | 2 +- arch/arm64/boot/dts/lg/lg1312.dtsi | 2 +- arch/powerpc/boot/dts/acadia.dts | 2 +- drivers/dma/bcm2835-dma.c | 2 +- 15 files changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/14 ARM: dts: STiH407: DT spelling s/interrupts-names/interrupt-names/
--- arch/arm/boot/dts/stih407-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/stih407-pinctrl.dtsi +1 -1
@@ -1085,7 +1085,7 @@ reg = <0x0923f080 0x4>; reg-names = "irqmux"; interrupts = <GIC_SPI 192 IRQ_TYPE_NONE>; - interrupts-names = "irqmux"; + interrupt-names = "irqmux"; ranges = <0 0x09230000 0x3000>; pio40: gpio at 09230000 {
Signature · 1 line
1.9.1
PATCH 2/14 ARM: dts: omap5-board-common: DT spelling s/interrupt-name/interrupt-names/
In reply to Geert Uytterhoeven--- arch/arm/boot/dts/omap5-board-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap5-board-common.dtsi +1 -1
@@ -395,7 +395,7 @@ compatible = "ti,palmas-pmic"; interrupt-parent = <&palmas>; interrupts = <14 IRQ_TYPE_NONE>; - interrupt-name = "short-irq"; + interrupt-names = "short-irq"; ti,ldo6-vibrator;
Signature · 1 line
1.9.1
PATCH 3/14 ARM: dts: omap5-cm-t54: DT spelling s/interrupt-name/interrupt-names/
In reply to Geert Uytterhoeven--- arch/arm/boot/dts/omap5-cm-t54.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap5-cm-t54.dts +1 -1
@@ -434,7 +434,7 @@ compatible = "ti,palmas-pmic"; interrupt-parent = <&palmas>; interrupts = <14 IRQ_TYPE_NONE>; - interrupt-name = "short-irq"; + interrupt-names = "short-irq"; ti,ldo6-vibrator;
Signature · 1 line
1.9.1
PATCH 4/14 ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/
In reply to Geert Uytterhoeven--- arch/arm/boot/dts/omap36xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap36xx.dtsi +1 -1
@@ -44,7 +44,7 @@ abb_mpu_iva: regulator-abb-mpu { compatible = "ti,abb-v1"; regulator-name = "abb_mpu_iva"; - #address-cell = <0>; + #address-cells = <0>; #size-cells = <0>; reg = <0x483072f0 0x8>, <0x48306818 0x4>; reg-names = "base-address", "int-address";
Signature · 1 line
1.9.1
PATCH 4/14 ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/
Quoted 10 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- arch/arm/boot/dts/omap36xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/omap36xx.dtsi +0
-0
arch/arm/boot/dts/omap36xx.dtsi line 47
Quoted 5 lines
arch/arm/boot/dts/omap36xx.dtsi +1
-1@@ -44,7 +44,7 @@ abb_mpu_iva: regulator-abb-mpu { compatible = "ti,abb-v1"; regulator-name = "abb_mpu_iva"; - #address-cell = <0>; + #address-cells = <0>;
dtc should flag this if it was really needed. However, it looks like it isn't as there are no child nodes (unless the board files add them).
A nice dtc check would be to flag unnecessary #address-cells or #size-cells. That would only help here after your fix though.
Rob
Quoted 6 lines
arch/arm/boot/dts/omap36xx.dtsi +0
-1#size-cells = <0>; reg = <0x483072f0 0x8>, <0x48306818 0x4>; reg-names = "base-address", "int-address"; --1.9.1
PATCH 4/14 ARM: dts: OMAP36xx: : DT spelling s/#address-cell/#address-cells/
Quoted 22 lines · Rob Herring
Quoted 10 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- arch/arm/boot/dts/omap36xx.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/omap36xx.dtsi +0
-0arch/arm/boot/dts/omap36xx.dtsi line 47
Quoted 5 lines
arch/arm/boot/dts/omap36xx.dtsi +1
-1@@ -44,7 +44,7 @@ abb_mpu_iva: regulator-abb-mpu { compatible = "ti,abb-v1"; regulator-name = "abb_mpu_iva"; - #address-cell = <0>; + #address-cells = <0>;dtc should flag this if it was really needed. However, it looks like it isn't as there are no child nodes (unless the board files add them).
Quoted 2 lines
A nice dtc check would be to flag unnecessary #address-cells or #size-cells. That would only help here after your fix though.
Yeah. Applying patches 2 - 4 into omap-for-v4.7/dt thanks.
Tony
PATCH 5/14 arm64: dts: lg1312: DT spelling s/#interrupts-cells/#interrupt-cells/
In reply to Geert Uytterhoeven--- arch/arm64/boot/dts/lg/lg1312.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/lg/lg1312.dtsi +1 -1
@@ -123,7 +123,7 @@ amba { #address-cells = <2>; #size-cells = <1>; - #interrupts-cells = <3>; + #interrupt-cells = <3>; compatible = "arm,amba-bus"; interrupt-parent = <&gic>;
Signature · 1 line
1.9.1
PATCH 6/14 dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/
In reply to Geert Uytterhoeven--- Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +- drivers/dma/bcm2835-dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/sound/davinci-mcbsp.txt +1 -1
@@ -43,7 +43,7 @@ mcbsp0: mcbsp at 1d10000 { <0x00310000 0x1000>; reg-names = "mpu", "dat"; interrupts = <97 98>; - interrupts-names = "rx", "tx"; + interrupt-names = "rx", "tx"; dmas = <&edma0 3 1 &edma0 2 1>; dma-names = "tx", "rx";
drivers/dma/bcm2835-dma.c +1 -1
@@ -974,7 +974,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)/* legacy device tree case handling */ dev_warn_once (&pdev->dev, -"missing interrupts-names property in device tree - legacy interpretation is used" ); +"missing interrupt-names property in device tree - legacy interpretation is used" );/* * in case of channel >= 11 * use the 11th interrupt and that is shared
Signature · 1 line
1.9.1
PATCH 6/14 dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/
Quoted 3 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +-
This change does not apply for me, can you please split it up and send the sound ones thru sound tree
Signature · 1 line
~Vinod
Quoted 32 lines
drivers/dma/bcm2835-dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)Documentation/devicetree/bindings/sound/davinci-mcbsp.txt +1
-1@@ -43,7 +43,7 @@ mcbsp0: mcbsp@1d10000 { <0x00310000 0x1000>; reg-names = "mpu", "dat"; interrupts = <97 98>; - interrupts-names = "rx", "tx"; + interrupt-names = "rx", "tx"; dmas = <&edma0 3 1 &edma0 2 1>; dma-names = "tx", "rx";drivers/dma/bcm2835-dma.c +1
-1@@ -974,7 +974,7 @@ static int bcm2835_dma_probe(struct platform_device *pdev)/* legacy device tree case handling */ dev_warn_once (&pdev->dev, -"missing interrupts-names property in device tree - legacy interpretation is used" ); +"missing interrupt-names property in device tree - legacy interpretation is used" );/* * in case of channel >= 11 * use the 11th interrupt and that is shared Signature · 1 line
1.9.1
PATCH 6/14 dmaengine: bcm2835: DT spelling s/interrupts-names/interrupt-names/
Hi Vinod,
Quoted 7 lines · Vinod Koul
Quoted 3 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- Documentation/devicetree/bindings/sound/davinci-mcbsp.txt | 2 +-This change does not apply for me, can you please split it up and send the sound ones thru sound tree
Sorry, I seem to have mixed two unrelated drivers. Will split and resend...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 7/14 dt: booting-without-of: DT spelling s/#interrupt-cell/#interrupt-cells/
In reply to Geert Uytterhoeven--- Documentation/devicetree/booting-without-of.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/booting-without-of.txt +1 -1
@@ -1302,7 +1302,7 @@ number and level/sense information. All interrupt children in an OpenPIC interrupt domain use 2 cells per interrupt in their interrupts property. -The PCI bus binding specifies a #interrupt-cell value of 1 to encode +The PCI bus binding specifies a #interrupt-cells value of 1 to encode which interrupt pin (INTA,INTB,INTC,INTD) is used. 2) interrupt-parent property
Signature · 1 line
1.9.1
PATCH 8/14 powerpc: dts: acadia: DT spelling s/#interrupts-parent/#interrupt-parent/
In reply to Geert Uytterhoeven--- arch/powerpc/boot/dts/acadia.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/boot/dts/acadia.dts +1 -1
@@ -183,7 +183,7 @@ usb at ef603000 { compatible = "ohci-be"; reg = <0xef603000 0x80>; - interrupts-parent = <&UIC0>; + interrupt-parent = <&UIC0>; interrupts = <0xd 0x4 0xe 0x4>; };
Signature · 1 line
1.9.1
PATCH 9/14 Input: touchscreen: Broadcom iProc: DT spelling s/clock-name/clock-names/
In reply to Geert Uytterhoeven--- .../devicetree/bindings/input/touchscreen/brcm,iproc-touchscreen.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/input/touchscreen/brcm,iproc-touchscreen.txt +1 -1
@@ -7,7 +7,7 @@ Required properties: If this property is selected please make sure MFD_SYSCON config is enabled in the defconfig file. - clocks: The clock provided by the SOC to driver the tsc -- clock-name: name for the clock +- clock-names: name for the clock - interrupts: The touchscreen controller's interrupt - address-cells: Specify the number of u32 entries needed in child nodes. Should set to 1.
Signature · 1 line
1.9.1
PATCH 9/14 Input: touchscreen: Broadcom iProc: DT spelling s/clock-name/clock-names/
Quoted 1 line · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>
Applied, thank you.
Quoted 24 lines
--- .../devicetree/bindings/input/touchscreen/brcm,iproc-touchscreen.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/input/touchscreen/brcm,iproc-touchscreen.txt +1
-1@@ -7,7 +7,7 @@ Required properties: If this property is selected please make sure MFD_SYSCON config is enabled in the defconfig file. - clocks: The clock provided by the SOC to driver the tsc -- clock-name: name for the clock +- clock-names: name for the clock - interrupts: The touchscreen controller's interrupt - address-cells: Specify the number of u32 entries needed in child nodes. Should set to 1.Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 1 line
Dmitry
PATCH 10/14 misc: sram: DT spelling s/#adress-cells/#address-cells/
In reply to Geert Uytterhoeven--- Documentation/devicetree/bindings/sram/sram.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/sram/sram.txt +1 -1
@@ -51,7 +51,7 @@ sram: sram at 5c000000 { compatible = "mmio-sram"; reg = <0x5c000000 0x40000>; /* 256 KiB SRAM at address 0x5c000000 */ - #adress-cells = <1>; + #address-cells = <1>; #size-cells = <1>; ranges = <0 0x5c000000 0x40000>;
Signature · 1 line
1.9.1
PATCH 10/14 misc: sram: DT spelling s/#adress-cells/#address-cells/
Quoted 1 line · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>
Applied, thanks.
Rob
Quoted 20 lines
--- Documentation/devicetree/bindings/sram/sram.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/sram/sram.txt +1
-1@@ -51,7 +51,7 @@ sram: sram at 5c000000 { compatible = "mmio-sram"; reg = <0x5c000000 0x40000>; /* 256 KiB SRAM at address 0x5c000000 */ - #adress-cells = <1>; + #address-cells = <1>; #size-cells = <1>; ranges = <0 0x5c000000 0x40000>;Signature · 1 line
1.9.1
PATCH 11/14 PCI: hisi: DT spelling s/interrupts-*/interrupt-*/
In reply to Geert Uytterhoeven--- Documentation/devicetree/bindings/pci/hisilicon-pcie.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
Documentation/devicetree/bindings/pci/hisilicon-pcie.txt +6 -6
@@ -34,11 +34,11 @@ Hip05 Example (note that Hip06 is the same except compatible): ranges = <0x82000000 0 0x00000000 0x220 0x00000000 0 0x10000000>; num-lanes = <8>; port-id = <1>; - #interrupts-cells = <1>; - interrupts-map-mask = <0xf800 0 0 7>; - interrupts-map = <0x0 0 0 1 &mbigen_pcie 1 10 - 0x0 0 0 2 &mbigen_pcie 2 11 - 0x0 0 0 3 &mbigen_pcie 3 12 - 0x0 0 0 4 &mbigen_pcie 4 13>; + #interrupt-cells = <1>; + interrupt-map-mask = <0xf800 0 0 7>; + interrupt-map = <0x0 0 0 1 &mbigen_pcie 1 10 + 0x0 0 0 2 &mbigen_pcie 2 11 + 0x0 0 0 3 &mbigen_pcie 3 12 + 0x0 0 0 4 &mbigen_pcie 4 13>; status = "ok"; };
Signature · 1 line
1.9.1
PATCH 11/14 PCI: hisi: DT spelling s/interrupts-*/interrupt-*/
Quoted 1 line · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>
Applied, thanks.
Rob
Quoted 29 lines
--- Documentation/devicetree/bindings/pci/hisilicon-pcie.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)Documentation/devicetree/bindings/pci/hisilicon-pcie.txt +6
-6@@ -34,11 +34,11 @@ Hip05 Example (note that Hip06 is the same except compatible): ranges = <0x82000000 0 0x00000000 0x220 0x00000000 0 0x10000000>; num-lanes = <8>; port-id = <1>; - #interrupts-cells = <1>; - interrupts-map-mask = <0xf800 0 0 7>; - interrupts-map = <0x0 0 0 1 &mbigen_pcie 1 10 - 0x0 0 0 2 &mbigen_pcie 2 11 - 0x0 0 0 3 &mbigen_pcie 3 12 - 0x0 0 0 4 &mbigen_pcie 4 13>; + #interrupt-cells = <1>; + interrupt-map-mask = <0xf800 0 0 7>; + interrupt-map = <0x0 0 0 1 &mbigen_pcie 1 10 + 0x0 0 0 2 &mbigen_pcie 2 11 + 0x0 0 0 3 &mbigen_pcie 3 12 + 0x0 0 0 4 &mbigen_pcie 4 13>; status = "ok"; };Signature · 1 line
1.9.1
PATCH 12/14 phy: phy-stih41x-usb: DT spelling s/#phy-cell/#phy-cells/
In reply to Geert Uytterhoeven--- Documentation/devicetree/bindings/phy/phy-stih41x-usb.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/phy/phy-stih41x-usb.txt +1 -1
@@ -17,7 +17,7 @@ Example: usb2_phy: usb2phy at 0 { compatible = "st,stih416-usb-phy"; - #phy-cell = <0>; + #phy-cells = <0>; st,syscfg = <&syscfg_rear>; clocks = <&clk_sysin>; clock-names = "osc_phy";
Signature · 1 line
1.9.1
PATCH 12/14 phy: phy-stih41x-usb: DT spelling s/#phy-cell/#phy-cells/
Quoted 1 line · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>
Applied, thanks.
Rob
Quoted 20 lines
--- Documentation/devicetree/bindings/phy/phy-stih41x-usb.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/devicetree/bindings/phy/phy-stih41x-usb.txt +1
-1@@ -17,7 +17,7 @@ Example: usb2_phy: usb2phy at 0 { compatible = "st,stih416-usb-phy"; - #phy-cell = <0>; + #phy-cells = <0>; st,syscfg = <&syscfg_rear>; clocks = <&clk_sysin>; clock-names = "osc_phy";Signature · 1 line
1.9.1
PATCH 13/14 rtc: rtc-sa1100: DT spelling s/interrupt-name/interrupt-names/
In reply to Geert Uytterhoeven--- Documentation/devicetree/bindings/rtc/sa1100-rtc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/rtc/sa1100-rtc.txt +1 -1
@@ -13,5 +13,5 @@ Example: compatible = "mrvl,mmp-rtc"; reg = <0xd4010000 0x1000>; interrupts = <5>, <6>; - interrupt-name = "rtc 1Hz", "rtc alarm"; + interrupt-names = "rtc 1Hz", "rtc alarm"; };
Signature · 1 line
1.9.1
Alexandre Belloni
AppliedPATCH 13/14 rtc: rtc-sa1100: DT spelling s/interrupt-name/interrupt-names/
Quoted 5 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- Documentation/devicetree/bindings/rtc/sa1100-rtc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Signature · 3 lines
Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 14/14 regulator: ti-abb: DT spelling s/#{address, size}-cell/#{address, size}-cells/
In reply to Geert Uytterhoeven--- .../devicetree/bindings/regulator/ti-abb-regulator.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/devicetree/bindings/regulator/ti-abb-regulator.txt +5 -5
@@ -14,8 +14,8 @@ Required Properties: - "setup-address" - contains setup register address of ABB module (ti,abb-v3) - "int-address" - contains address of interrupt register for ABB module (also see Optional properties) -- #address-cell: should be 0 -- #size-cell: should be 0 +- #address-cells: should be 0 +- #size-cells: should be 0 - clocks: should point to the clock node used by ABB module - ti,settling-time: Settling time in uSecs from SoC documentation for ABB module to settle down(target time for SR2_WTCNT_VALUE).
@@ -69,7 +69,7 @@ Example #1: Simplest configuration (no efuse data, hard coded ABB table): abb_x: regulator-abb-x { compatible = "ti,abb-v1"; regulator-name = "abb_x"; - #address-cell = <0>; + #address-cells = <0>; #size-cells = <0>; reg = <0x483072f0 0x8>, <0x48306818 0x4>; reg-names = "base-address", "int-address";
@@ -89,7 +89,7 @@ Example #2: Efuse bits contain ABB mode setting (no LDO override capability) abb_y: regulator-abb-y { compatible = "ti,abb-v2"; regulator-name = "abb_y"; - #address-cell = <0>; + #address-cells = <0>; #size-cells = <0>; reg = <0x4a307bd0 0x8>, <0x4a306014 0x4>, <0x4A002268 0x8>; reg-names = "base-address", "int-address", "efuse-address";
@@ -110,7 +110,7 @@ Example #3: Efuse bits contain ABB mode setting and LDO override capability abb_z: regulator-abb-z { compatible = "ti,abb-v2"; regulator-name = "abb_z"; - #address-cell = <0>; + #address-cells = <0>; #size-cells = <0>; reg = <0x4ae07ce4 0x8>, <0x4ae06010 0x4>, <0x4a002194 0x8>, <0x4ae0C314 0x4>;
Signature · 1 line
1.9.1
PATCH 14/14 regulator: ti-abb: DT spelling s/#{address, size}-cell/#{address, size}-cells/
Quoted 10 lines · Geert Uytterhoeven
Signed-off-by Geert Uytterhoeven <[email protected]>--- .../devicetree/bindings/regulator/ti-abb-regulator.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)Documentation/devicetree/bindings/regulator/ti-abb-regulator.txt +0
-0
Documentation/devicetree/bindings/regulator/ti-abb-regulator.txt Required Properties: · line 18
Quoted 7 lines
Documentation/devicetree/bindings/regulator/ti-abb-regulator.txt +2
-2@@ -14,8 +14,8 @@ Required Properties: - "setup-address" - contains setup register address of ABB module (ti,abb-v3) - "int-address" - contains address of interrupt register for ABB module (also see Optional properties) -- #address-cell: should be 0 -- #size-cell: should be 0 +- #address-cells: should be 0 +- #size-cells: should be 0
Looks to me like you can just drop these.
Rob
cover DT: Fix spelling of standard properties
In reply to Geert UytterhoevenQuoted 2 lines · Geert Uytterhoeven
This patch series fixes misspellings of various standard DT properties in DT binding documentation, DTS files, and error messages.
BTW, this is against next-20160420.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
cover DT: Fix spelling of standard properties
In reply to Geert UytterhoevenQuoted 8 lines · Geert Uytterhoeven
Hi all,
This patch series fixes misspellings of various standard DT properties in DT binding documentation, DTS files, and error messages. While most of these are harmless, some of them may cause hard-to-debug failures.
Please apply where appropriate.
I'll happily take the whole series if you like, though I've not reviewed it all yet.
Quoted 15 lines
Thanks!
P.S. I used the following to detect misspellings:words="(address|clock|cooling|dma|gpio|index|interrupt|mbox|msi|nvmem|phy|phys|power-domain|pwm|reset|size|sleep|sound-dai|thermal-sensor)" git grep -Ew "${words}s-names" git grep -E "[^-]\<${words}-name\>[^-]" git grep -Ew "#${words}s-cells" # false positive phys-cells git grep -E "#${words}-cell\>[^-]" git grep -w adress-cells git grep -Ew "interrupts-(map|parent)"
Quoted 4 lines
How can we prevent adding more of these?
One simple option is to add the offenders to
scripts/spelling.txt. Alternatively, we may want to do something smarter and more DT specific?
At least for #*-cells, we should be able to check most in dtc. When we find common properties, we can check the node for the phandle has a cells property. That would also check that the property is in fact a phandle.
For *-names, we might be able to do a generic check in dtc for the corresponding property being present when we find a -names property. Though I suspect we're not consistent enough when/where we use plural.
Rob
cover DT: Fix spelling of standard properties
Quoted 9 lines · Rob Herring
Quoted 7 lines · Geert Uytterhoeven
Hi all,
This patch series fixes misspellings of various standard DT properties in DT binding documentation, DTS files, and error messages. While most of these are harmless, some of them may cause hard-to-debug failures.
Quoted 4 lines
Quoted 1 line
Please apply where appropriate.
I'll happily take the whole series if you like, though I've not reviewed it all yet.
Now, I have. Other than patch 4 and 14, for the series:
Rob