perfbook patch

DISCUSSION Paul E. McKenney 2 participants 3 messages Apr 21, 2016 1 message not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Paul E. McKenney

author

2016-04-21 16:18 UTC #1 lore raw

Quoted 7 lines · Balbir Singh

Hey, Paul
perfbook failed to build on Fedora 23 due to a texlive issue. I am not sure if other users are facing it. In any case I came up with a patch -- update FAQ.txt with an answer. I was not sure if it is worth posting to perfbook mailing list
I'm attaching it - FYI. I hope its useful
Balbir

Hello, Balbir, and thank you!

I tried it on Ubuntu 14.04, and it works just fine there. So are you OK with the following hijacking of your original patch?

Thanx, Paul

------------------------------------------------------------------------

commit 8c4c3c54d4d4246f6b13a914dda9c9ac42bf0c2e

Author: Balbir Singh <[email protected]>
Date:   Thu Apr 21 09:16:44 2016 -0700

Fix build error on Fedora 23 with texlive

The listings package is broken. The fix suggested is taken from
http://osdir.com/ml/general/2014-06/msg50467.html

Signed-off-by Balbir Singh <[email protected]>

Signed-off-by Paul E. McKenney <[email protected]>

perfbook.tex +12 -0

index ac46e74f6b6f..d607f66b428f 100644
@@ -35,6 +35,18 @@
   literate={\_}{}{0\discretionary{\_}{}{\_}}%
 }
 %%HTMLNOSKIP
+\makeatletter
+\renewcommand\lstinline[1][]{%
+\leavevmode\bgroup % \hbox\bgroup --> \bgroup
+\def\lst@boxpos{b}%
+\lsthk@PreSet\lstset{flexiblecolumns,#1}%
+\lsthk@TextStyle
+\ifnum\iffalse{\fi`}=\z@\fi
+\@ifnextchar\bgroup{%
+\ifnum`{=\z@}\fi%
+\afterassignment\lst@InlineG \let\@let@token}{%
+\ifnum`{=\z@}\fi\lstinline@}}
+\makeatother
 \newcommand{\co}[1]{\lstinline[breaklines=yes,breakatwhitespace=yes]{#1}}
 
 \title{Is Parallel Programming Hard, And, If So, What Can You Do About It?}

Balbir Singh

2016-04-21 21:52 UTC #2 lore raw

Quoted 44 lines · Paul E. McKenney

Quoted 7 lines · Balbir Singh
Hey, Paul
perfbook failed to build on Fedora 23 due to a texlive issue. I am not sure if other users are facing it. In any case I came up with a patch -- update FAQ.txt with an answer. I was not sure if it is worth posting to perfbook mailing list
I'm attaching it - FYI. I hope its useful
Balbir
Hello, Balbir, and thank you!
I tried it on Ubuntu 14.04, and it works just fine there. So are you OK with the following hijacking of your original patch?
Thanx, Paul
------------------------------------------------------------------------
commit 8c4c3c54d4d4246f6b13a914dda9c9ac42bf0c2e
Author: Balbir Singh <[email protected]>
Date:   Thu Apr 21 09:16:44 2016 -0700
Fix build error on Fedora 23 with texlive
The listings package is broken. The fix suggested is taken from
http://osdir.com/ml/general/2014-06/msg50467.html
Signed-off-by Balbir Singh <[email protected]>
Signed-off-by Paul E. McKenney <[email protected]>
perfbook.tex +5 -0
index ac46e74f6b6f..d607f66b428f 100644
@@ -35,6 +35,18 @@
   literate={\_}{}{0\discretionary{\_}{}{\_}}%
 }
 %%HTMLNOSKIP
+\makeatletter
+\renewcommand\lstinline[1][]{%
+\leavevmode\bgroup % \hbox\bgroup --> \bgroup
+\def\lst@boxpos{b}%
+\lsthk@PreSet\lstset{flexiblecolumns,#1}%

perfbook.tex line 52

Quoted 10 lines

perfbook.tex +7 -0

+\lsthk@TextStyle
+\ifnum\iffalse{\fi`}=\z@\fi
+\@ifnextchar\bgroup{%
+\ifnum`{=\z@}\fi%
+\afterassignment\lst@InlineG \let\@let@token}{%
+\ifnum`{=\z@}\fi\lstinline@}}
+\makeatother
 \newcommand{\co}[1]{\lstinline[breaklines=yes,breakatwhitespace=yes]{#1}}
 
 \title{Is Parallel Programming Hard, And, If So, What Can You Do About It?}

Absolutely!

Balbir Singh

Paul E. McKenney

author

2016-04-21 22:05 UTC #3 lore raw

Quoted 54 lines · Balbir Singh

Quoted 52 lines · Paul E. McKenney
Quoted 7 lines · Balbir Singh
Hey, Paul
perfbook failed to build on Fedora 23 due to a texlive issue. I am not sure if other users are facing it. In any case I came up with a patch -- update FAQ.txt with an answer. I was not sure if it is worth posting to perfbook mailing list
I'm attaching it - FYI. I hope its useful
Balbir
Hello, Balbir, and thank you!
I tried it on Ubuntu 14.04, and it works just fine there. So are you OK with the following hijacking of your original patch?
Thanx, Paul
------------------------------------------------------------------------
commit 8c4c3c54d4d4246f6b13a914dda9c9ac42bf0c2e
Author: Balbir Singh <[email protected]>
Date:   Thu Apr 21 09:16:44 2016 -0700
Fix build error on Fedora 23 with texlive
The listings package is broken. The fix suggested is taken from
http://osdir.com/ml/general/2014-06/msg50467.html
Signed-off-by Balbir Singh <[email protected]>
Signed-off-by Paul E. McKenney <[email protected]>
perfbook.tex +12 -0
index ac46e74f6b6f..d607f66b428f 100644
@@ -35,6 +35,18 @@
   literate={\_}{}{0\discretionary{\_}{}{\_}}%
 }
 %%HTMLNOSKIP
+\makeatletter
+\renewcommand\lstinline[1][]{%
+\leavevmode\bgroup % \hbox\bgroup --> \bgroup
+\def\lst@boxpos{b}%
+\lsthk@PreSet\lstset{flexiblecolumns,#1}%
+\lsthk@TextStyle
+\ifnum\iffalse{\fi`}=\z@\fi
+\@ifnextchar\bgroup{%
+\ifnum`{=\z@}\fi%
+\afterassignment\lst@InlineG \let\@let@token}{%
+\ifnum`{=\z@}\fi\lstinline@}}
+\makeatother
 \newcommand{\co}[1]{\lstinline[breaklines=yes,breakatwhitespace=yes]{#1}}
 

Quoted 3 lines

perfbook.tex line 52
Quoted 1 line
perfbook.tex +0 -0
 \title{Is Parallel Programming Hard, And, If So, What Can You Do About It?}
Absolutely!

Very good! I added some comments saying what the block of commands was for, and pushed it out.

Thanx, Paul