Skip to contentSkip to conversation

crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init()

PATCH In review Dan Carpenter 2 participants 2 messages Apr 22, 2016 – Apr 25, 2016

Subsystems (3)
Arm i.MX and Layerscape Kernel janitors Crypto API
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init()

->src_nents and ->dst_nents are unsigned so they can't be less than zero. I fixed this by introducing a temporary "nents" variable.

Fixes d293b640ebd5 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by Dan Carpenter <[email protected]>
drivers/crypto/mxc-scc.c +9 -6
index 38b01bf..9b348a7 100644
@@ -210,18 +210,21 @@ static int mxc_scc_ablkcipher_req_init(struct ablkcipher_request *req,
 				       struct mxc_scc_ctx *ctx)
 {
 	struct mxc_scc *scc = ctx->scc;
+	int nents;
 
-	ctx->src_nents = sg_nents_for_len(req->src, req->nbytes);
-	if (ctx->src_nents < 0) {
+	nents = sg_nents_for_len(req->src, req->nbytes);
+	if (nents < 0) {
 		dev_err(scc->dev, "Invalid number of src SC");
-		return ctx->src_nents;
+		return nents;
 	}
+	ctx->src_nents = nents;
 
-	ctx->dst_nents = sg_nents_for_len(req->dst, req->nbytes);
-	if (ctx->dst_nents < 0) {
+	nents = sg_nents_for_len(req->dst, req->nbytes);
+	if (nents < 0) {
 		dev_err(scc->dev, "Invalid number of dst SC");
-		return ctx->dst_nents;
+		return nents;
 	}
+	ctx->dst_nents = nents;
 
 	ctx->size = 0;
 	ctx->offset = 0;
maintainer
#1 lore raw
Quoted 5 lines · Dan Carpenter

->src_nents and ->dst_nents are unsigned so they can't be less than zero. I fixed this by introducing a temporary "nents" variable.

Fixes d293b640ebd5 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by Dan Carpenter <[email protected]>

Both applied.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt