Bluetooth: ath3k: Silence uninitialized variable warning

PATCH In review Dan Carpenter 3 participants 4 messages Apr 22, 2016 – Apr 23, 2016

Subsystems (2)

Bluetooth drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-04-22 10:02 UTC #0 lore raw

PATCH 1/1 Bluetooth: ath3k: Silence uninitialized variable warning

We could print an uninitialized value in the error message.

Signed-off-by Dan Carpenter <[email protected]>

drivers/bluetooth/ath3k.c +4 -2

index 47ca4b3..641c2d1 100644
@@ -206,7 +206,8 @@ static int ath3k_load_firmware(struct usb_device *udev,
 				const struct firmware *firmware)
 {
 	u8 *send_buf;
-	int err, pipe, len, size, sent = 0;
+	int len = 0;
+	int err, pipe, size, sent = 0;
 	int count = firmware->size;
 
 	BT_DBG("udev %p", udev);

@@ -302,7 +303,8 @@ static int ath3k_load_fwfile(struct usb_device *udev,
 		const struct firmware *firmware)
 {
 	u8 *send_buf;
-	int err, pipe, len, size, count, sent = 0;
+	int len = 0;
+	int err, pipe, size, count, sent = 0;
 	int ret;
 
 	count = firmware->size;

Marcel Holtmann

maintainer

2016-04-22 10:42 UTC #1 lore raw

Hi Dan,

Quoted 3 lines

We could print an uninitialized value in the error message.
Signed-off-by Dan Carpenter <[email protected]>

patch has been applied to bluetooth-next tree.

Regards

Marcel

Afzal Mohammed

2016-04-23 06:47 UTC #2 lore raw

In reply to Dan Carpenter

Hi,

drivers/bluetooth/ath3k.c static int ath3k_load_fwfile(struct usb_device *udev, · line 307

Quoted 3 lines · Dan Carpenter

drivers/bluetooth/ath3k.c +2 -1

-	int err, pipe, len, size, count, sent = 0;
+	int len = 0;
+	int err, pipe, size, count, sent = 0;

Is there any particular reason to avoid more than 1 variable initialization in definition on a single line ?, like,

	int err, pipe, size, count, sent = 0, len = 0;

have observed that none of your uninitialized variable warning fixes does as mentioned above.

Regards
afzal

Dan Carpenter

author

2016-04-23 07:21 UTC #3 lore raw

Quoted 11 lines · Afzal Mohammed

Hi,
drivers/bluetooth/ath3k.c static int ath3k_load_fwfile(struct usb_device *udev, · line 307
Quoted 3 lines · Dan Carpenter
drivers/bluetooth/ath3k.c +2 -1
-	int err, pipe, len, size, count, sent = 0;
+	int len = 0;
+	int err, pipe, size, count, sent = 0;
Is there any particular reason to avoid more than 1 variable initialization in definition on a single line ?, like,

Quoted 4 lines

	int err, pipe, size, count, sent = 0, len = 0;
have observed that none of your uninitialized variable warning fixes does as mentioned above.

That sort of initialization is slightly less readable...

regards,
dan carpenter