package/freeswitch: disable ClueCon invitation messages
PATCH 1/2 package/freeswitch: disable ClueCon invitation messages
--- package/freeswitch/freeswitch.mk | 2 ++ 1 file changed, 2 insertions(+)
package/freeswitch/freeswitch.mk +2 -0
@@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES $(Q)echo $(FREESWITCH_ENABLED_MODULES) \ | tr ' ' '\n' \ > $(@D)/modules.conf + > $(@D)/noreg + > $(@D)/cluecon2.tmpl endef FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES
Signature · 1 line
2.8.0.rc3
PATCH 2/2 package/freeswitch: Fix added license
Noted by Thomas:
http://lists.busybox.net/pipermail/buildroot/2016-April/158864.html
--- package/freeswitch/freeswitch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/freeswitch/freeswitch.mk +1 -1
@@ -161,7 +161,7 @@ FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES # mod_isac supports a limited set of archs # src/mod/codecs/mod_isac/typedefs.h ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_x86_64),y) -FREESWITCH_LICENSE += BSD-3c (mod_isac) +FREESWITCH_LICENSE := $(FREESWITCH_LICENSE) BSD-3c (mod_isac) FREESWITCH_LICENSE_FILES += src/mod/codecs/mod_isac/LICENSE FREESWITCH_ENABLED_MODULES += codecs/mod_isac endif
Signature · 1 line
2.8.0.rc3
PATCH 2/2 package/freeswitch: Fix added license
Hello,
package/freeswitch/freeswitch.mk FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES · line 164
Quoted 10 lines · Bernd Kuhls
package/freeswitch/freeswitch.mk +1
-1@@ -161,7 +161,7 @@ FREESWITCH_PRE_CONFIGURE_HOOKS += FREESWITCH_ENABLE_MODULES # mod_isac supports a limited set of archs # src/mod/codecs/mod_isac/typedefs.h ifeq ($(BR2_i386)$(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el)$(BR2_x86_64),y) -FREESWITCH_LICENSE += BSD-3c (mod_isac) +FREESWITCH_LICENSE := $(FREESWITCH_LICENSE) BSD-3c (mod_isac)
Hum, licenses should be comma separated, so don't we need:
FREESWITCH_LICENSE := $(FREESWITCH_LICENSE), BSD-3c (mod_isac)
?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Thomas Petazzoni
AppliedPATCH 2/2 package/freeswitch: Fix added license
In reply to Bernd KuhlsHello,
Quoted 7 lines · Bernd Kuhls
Noted by Thomas:
http://lists.busybox.net/pipermail/buildroot/2016-April/158864.htmlSigned-off-by Bernd Kuhls <[email protected]>--- package/freeswitch/freeswitch.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master after fixing the code so that licenses are comma separated.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 package/freeswitch: disable ClueCon invitation messages
In reply to Bernd KuhlsHello,
package/freeswitch/freeswitch.mk define FREESWITCH_ENABLE_MODULES · line 157
Quoted 10 lines · Bernd Kuhls
package/freeswitch/freeswitch.mk +2
-0@@ -153,6 +153,8 @@ define FREESWITCH_ENABLE_MODULES $(Q)echo $(FREESWITCH_ENABLED_MODULES) \ | tr ' ' '\n' \ > $(@D)/modules.conf + > $(@D)/noreg + > $(@D)/cluecon2.tmpl
Doesn't this deserve a separate pre-configure hook? Doing this hidden in the FREESWITCH_ENABLE_MODULES hook, with no comment or explanation whatsoever looks a bit weird.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/2 package/freeswitch: disable ClueCon invitation messages
Hello,
Quoted 3 lines · Thomas Petazzoni
Doesn't this deserve a separate pre-configure hook? Doing this hidden in the
FREESWITCH_ENABLE_MODULEShook, with no comment or explanation whatsoever looks a bit weird.
I've had no feedback, I'm marking this patch as Changes Requested in patchwork. Please resend with a separate hook, or a better explanation.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com