Skip to contentSkip to conversation

aeroflex/greth: fix warning about unused variable

PATCH Applied Sam Ravnborg 2 participants 3 messages Apr 24, 2016 – May 21, 2016

Subsystems (2)
Network drivers Greth 10/100/1G Ethernet mac device driver
lore
Share & tools
lore

Sam Ravnborg

author
#0 lore raw

PATCH 1/1 aeroflex/greth: fix warning about unused variable

From: Sam Ravnborg <[email protected]>
Date: Sun, 24 Apr 2016 18:39:52 +0200
Subject: [PATCH] aeroflex/greth: fix warning about unused variable

Fix following warning:
aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]

The variable was unused - remove it.
It looks like this warning has been there forever - was found by an allyesconfig build of sparc32.

Signed-off-by Sam Ravnborg <[email protected]>
Cc Kristoffer Glembo <[email protected]>
---
 drivers/net/ethernet/aeroflex/greth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/aeroflex/greth.c +1 -1
index b873531..bca07c5 100644
@@ -1323,7 +1323,7 @@ static inline int phy_aneg_done(struct phy_device *phydev)
 
 static int greth_mdio_init(struct greth_private *greth)
 {
-	int ret, phy;
+	int ret;
 	unsigned long timeout;
 
 	greth->mdio = mdiobus_alloc();
Signature · 1 line
1.8.3.1
author
#1 lore raw
Quoted 7 lines · Sam Ravnborg

From: Sam Ravnborg <[email protected]>
Date: Sun, 24 Apr 2016 18:39:52 +0200
Subject: [PATCH] aeroflex/greth: fix warning about unused variable

Fix following warning:
aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]

Quoted 6 lines

The variable was unused - remove it.
It looks like this warning has been there forever - was found by an allyesconfig build of sparc32.

Signed-off-by Sam Ravnborg <[email protected]>
Cc Kristoffer Glembo <[email protected]>

Kristoffer Glembo's mail bounces.
I have asked Gaisler for a replacement as maintainer.

Sam

maintainer Applied
#2 lore raw
In reply to Sam Ravnborg

From: Sam Ravnborg <[email protected]>
Date: Sun, 24 Apr 2016 19:51:05 +0200

Quoted 4 lines

From: Sam Ravnborg <[email protected]>
Date: Sun, 24 Apr 2016 18:39:52 +0200
Subject: [PATCH] aeroflex/greth: fix warning about unused variable

Quoted 8 lines

Fix following warning:
aeroflex/greth.c:1326:11: warning: unused variable 'phy' [-Wunused-variable]

The variable was unused - remove it.
It looks like this warning has been there forever - was found by an allyesconfig build of sparc32.

Signed-off-by Sam Ravnborg <[email protected]>

Applied.