Skip to contentSkip to conversation

usb: add support for Intel dual role port mux

PATCH Superseded Lu Baolu 3 participants 25 messages Apr 25, 2016 – Apr 29, 2016

Subsystems (5)

v6 of 10 Superseded Latest is v10 →

lore
Share & tools
lore

Lu Baolu

author
#0 lore raw

v6 cover usb: add support for Intel dual role port mux

Intel SOC chips are featured with USB dual role. The host role is provided by Intel xHCI IP, and the gadget role is provided by IP from designware. Tablet platform designs always share a single port for both host and gadget controllers. There is a mux to switch the port to the right controller according to the cable type. OS needs to provide the callback to control the mux when a plug-in event raises. The method to control the mux is platform dependent. At least three types of implementation can be found across current devices. 1) GPIO pins; 2) a unit which can be controlled by memory mapped registers; 3) ACPI ASL code.

This patch series adds supports for Intel dual role port mux. It includes:
(1) A helper layer on top of extcon for individual mux driver. It listens to the USB-HOST extcon cable and call the switch call-back when the cable state changes.
(2) Drivers for GPIO controlled port mux which could be found on Baytrail devices. A mfd driver is used to split the GPIOs into a USB gpio extcon device, a fixed regulator for gpio controlled USB VCC, and a USB mux device. Driver for USB gpio extcon device is already in upstream Linux. This patch series includes a driver for GPIO USB mux.
(3) Drivers for USB port mux controlled through memory mapped registers and the logic to create the mux device. This type of dual role port mux could be found in Cherry Trail and Broxton devices.

Lu Baolu (10):
extcon: usb-gpio: add device binding for platform device
extcon: usb-gpio: add support for ACPI gpio interface
regulator: fixed: add device binding for platform device
regulator: fixed: add support for ACPI interface
usb: mux: add generic code for dual role port mux
usb: mux: add driver for Intel gpio controlled port mux
usb: mux: add driver for Intel drcfg controlled port mux
mfd: intel_vuport: Add Intel virtual USB port MFD Driver
usb: pci-quirks: add Intel USB drcfg mux device
MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

Change log:

v5->v6:
Work internally with Felipe to improve the whole patch series. Below changes have been made since last version.
- rework the common code to make it a generic interface for mux devices;
- split the vbus gpio handling to a fixed regulator device;
- removed unnecessary filtering for state change;
- removed unnecessary WARN statement;
- removed globals in mux drivers;
- removed unnecessary register polling and waiting in drcfg driver;

v4->v5:
- Change the extcon interfaces with the new ones suggested by 2a9de9c0f08d6 (extcon: Use the unique id for external connector instead of string)
- remove patch "usb: pci-quirks: add Intel USB drcfg mux device" from this serial due to that it's not driver staff. Will be submitted seperately.

v3->v4:
- Check all patches with "checkpatch.pl --strict", and fix all CHECKs;
- Change sysfs node from "intel_mux" to "port_mux";
- Refines below confusing functions:
intel_usb_mux_register() -> intel_usb_mux_bind_cable() intel_usb_mux_unregister() -> intel_usb_mux_unbind_cable();
- Remove unnecessary struct intel_mux_dev.

v2->v3:
- uvport mfd driver got reviewed by Lee Jones, the following changes were made accordingly.
- seperate uvport driver from the mux drivers in MAINTAINERS file
- refine the description in Kconfig
- refine the mfd_cell structure data

v1->v2:
- move mux driver from drivers/usb/misc to drivers/usb/mux;
- replace debugfs with sysfs for user level mux control;
- remove unnecessary register restore if mux registeration failed;
- Add "Acked-by: Chanwoo Choi <[email protected]>" to extcon changes;
- Make the file names and exported function names more specific;
- Remove the usb_mux_get_dev() interface;
- Move "struct intel_usb_mux" from .h to .c file;
- Fix various kbuild robot warnings.

 Documentation/ABI/testing/sysfs-bus-platform |  17 +++
 MAINTAINERS                                  |  10 ++
 drivers/extcon/extcon-usb-gpio.c             |  10 +-
 drivers/mfd/Kconfig                          |   8 +
 drivers/mfd/Makefile                         |   1 +
 drivers/mfd/intel-vuport.c                   |  90 +++++++++++
 drivers/regulator/fixed.c                    |  55 +++++++
 drivers/usb/Kconfig                          |   2 +
 drivers/usb/Makefile                         |   1 +
 drivers/usb/host/pci-quirks.c                |  45 +++++-
 drivers/usb/host/xhci-ext-caps.h             |   2 +
 drivers/usb/mux/Kconfig                      |  30 ++++
 drivers/usb/mux/Makefile                     |   6 +
 drivers/usb/mux/portmux-core.c               | 217 +++++++++++++++++++++++++++
 drivers/usb/mux/portmux-intel-drcfg.c        | 171 +++++++++++++++++++++
 drivers/usb/mux/portmux-intel-gpio.c         | 149 ++++++++++++++++++
 include/linux/usb/portmux.h                  |  78 ++++++++++
 17 files changed, 889 insertions(+), 3 deletions(-)
 create mode 100644 drivers/mfd/intel-vuport.c
 create mode 100644 drivers/usb/mux/Kconfig
 create mode 100644 drivers/usb/mux/Makefile
 create mode 100644 drivers/usb/mux/portmux-core.c
 create mode 100644 drivers/usb/mux/portmux-intel-drcfg.c
 create mode 100644 drivers/usb/mux/portmux-intel-gpio.c
 create mode 100644 include/linux/usb/portmux.h
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH v6 1/10 extcon: usb-gpio: add device binding for platform device

This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices.

---
 drivers/extcon/extcon-usb-gpio.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/extcon/extcon-usb-gpio.c +7 -0
index 2b2fecf..af9c8b0 100644
@@ -206,6 +206,12 @@ static const struct of_device_id usb_extcon_dt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, usb_extcon_dt_match);
 
+static const struct platform_device_id usb_extcon_platform_ids[] = {
+	{ .name = "extcon-usb-gpio", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, usb_extcon_platform_ids);
+
 static struct platform_driver usb_extcon_driver = {
 	.probe		= usb_extcon_probe,
 	.remove		= usb_extcon_remove,
@@ -214,6 +220,7 @@ static struct platform_driver usb_extcon_driver = {
 		.pm	= &usb_extcon_pm_ops,
 		.of_match_table = usb_extcon_dt_match,
 	},
+	.id_table = usb_extcon_platform_ids,
 };
 
 module_platform_driver(usb_extcon_driver);
Signature · 1 line
2.1.4
maintainer
#2 lore raw

Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

Hi Lu,

Quoted 29 lines · Lu Baolu

This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices.

---
 drivers/extcon/extcon-usb-gpio.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/extcon/extcon-usb-gpio.c +6 -0
index 2b2fecf..af9c8b0 100644
@@ -206,6 +206,12 @@ static const struct of_device_id usb_extcon_dt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, usb_extcon_dt_match);
 
+static const struct platform_device_id usb_extcon_platform_ids[] = {
+	{ .name = "extcon-usb-gpio", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, usb_extcon_platform_ids);
+
 static struct platform_driver usb_extcon_driver = {
 	.probe		= usb_extcon_probe,
 	.remove		= usb_extcon_remove,

drivers/extcon/extcon-usb-gpio.c static struct platform_driver usb_extcon_driver = { · line 226

Quoted 7 lines
drivers/extcon/extcon-usb-gpio.c +1 -0
@@ -214,6 +220,7 @@ static struct platform_driver usb_extcon_driver = {
 		.pm	= &usb_extcon_pm_ops,
 		.of_match_table = usb_extcon_dt_match,
 	},
+	.id_table = usb_extcon_platform_ids,
 };
 
 module_platform_driver(usb_extcon_driver);

Applied it.

Thanks,
Chanwoo Choi

author
#3 lore raw

Re: [PATCH v6 01/10] extcon: usb-gpio: add device binding for platform device

Hi,

Quoted 37 lines · Chanwoo Choi

Hi Lu,

Quoted 34 lines · Lu Baolu

This is needed to handle the GPIO connected USB ID pin found on Intel Baytrail devices.

---
 drivers/extcon/extcon-usb-gpio.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/extcon/extcon-usb-gpio.c +7 -0
index 2b2fecf..af9c8b0 100644
@@ -206,6 +206,12 @@ static const struct of_device_id usb_extcon_dt_match[] = {
 };
 MODULE_DEVICE_TABLE(of, usb_extcon_dt_match);
 
+static const struct platform_device_id usb_extcon_platform_ids[] = {
+	{ .name = "extcon-usb-gpio", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, usb_extcon_platform_ids);
+
 static struct platform_driver usb_extcon_driver = {
 	.probe		= usb_extcon_probe,
 	.remove		= usb_extcon_remove,
@@ -214,6 +220,7 @@ static struct platform_driver usb_extcon_driver = {
 		.pm	= &usb_extcon_pm_ops,
 		.of_match_table = usb_extcon_dt_match,
 	},
+	.id_table = usb_extcon_platform_ids,
 };
 
Quoted 6 lines

drivers/extcon/extcon-usb-gpio.c static struct platform_driver usb_extcon_driver = { · line 226

Quoted 2 lines
drivers/extcon/extcon-usb-gpio.c +0 -0
 module_platform_driver(usb_extcon_driver);

Applied it.

Thanks,
Chanwoo Choi

Thank you.

Best regards,
Baolu

Quoted 1 line
author
#4 lore raw

PATCH v6 2/10 extcon: usb-gpio: add support for ACPI gpio interface

In reply to Lu Baolu

GPIO resource could be retrieved through APCI as well.

---
 drivers/extcon/extcon-usb-gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon-usb-gpio.c +2 -1
index af9c8b0..472c431 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
+#include <linux/acpi.h>
 
 #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
 
@@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	struct usb_extcon_info *info;
 	int ret;
 
-	if (!np)
+	if (!np && !ACPI_HANDLE(dev))
 		return -EINVAL;
 
 	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
Signature · 1 line
2.1.4
maintainer
#5 lore raw

Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

Hi Lu,

Quoted 23 lines · Lu Baolu

GPIO resource could be retrieved through APCI as well.

---
 drivers/extcon/extcon-usb-gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon-usb-gpio.c +1 -0
index af9c8b0..472c431 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
+#include <linux/acpi.h>
 
 #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
 

drivers/extcon/extcon-usb-gpio.c static int usb_extcon_probe(struct platform_device *pdev) · line 98

Quoted 8 lines
drivers/extcon/extcon-usb-gpio.c +1 -1
@@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	struct usb_extcon_info *info;
 	int ret;
 
-	if (!np)
+	if (!np && !ACPI_HANDLE(dev))
 		return -EINVAL;
 
 	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);

Applied it.

Thanks,
Chanwoo Choi

author
#6 lore raw

Re: [PATCH v6 02/10] extcon: usb-gpio: add support for ACPI gpio interface

Hi,

Quoted 32 lines · Chanwoo Choi

Hi Lu,

Quoted 29 lines · Lu Baolu

GPIO resource could be retrieved through APCI as well.

---
 drivers/extcon/extcon-usb-gpio.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/extcon/extcon-usb-gpio.c +2 -1
index af9c8b0..472c431 100644
@@ -26,6 +26,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
+#include <linux/acpi.h>
 
 #define USB_GPIO_DEBOUNCE_MS	20	/* ms */
 
@@ -91,7 +92,7 @@ static int usb_extcon_probe(struct platform_device *pdev)
 	struct usb_extcon_info *info;
 	int ret;
 
-	if (!np)
+	if (!np && !ACPI_HANDLE(dev))
 		return -EINVAL;
 
Quoted 7 lines

drivers/extcon/extcon-usb-gpio.c static int usb_extcon_probe(struct platform_device *pdev) · line 98

Quoted 2 lines
drivers/extcon/extcon-usb-gpio.c +0 -0
 	info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);

Applied it.

Thanks,
Chanwoo Choi

Thank you.

Best regards,
Baolu

Quoted 1 line
author
#7 lore raw

PATCH v6 3/10 regulator: fixed: add device binding for platform device

In reply to Lu Baolu

This is needed to handle the GPIO connected USB vcc pin found on Intel Baytrail devices.

---
 drivers/regulator/fixed.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/regulator/fixed.c +7 -0
index ff62d69..e6f376f 100644
@@ -209,12 +209,19 @@ static const struct of_device_id fixed_of_match[] = {
 MODULE_DEVICE_TABLE(of, fixed_of_match);
 #endif
 
+static const struct platform_device_id fixed_platform_ids[] = {
+	{ .name = "reg-fixed-voltage", },
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(platform, fixed_platform_ids);
+
 static struct platform_driver regulator_fixed_voltage_driver = {
 	.probe		= reg_fixed_voltage_probe,
 	.driver		= {
 		.name		= "reg-fixed-voltage",
 		.of_match_table = of_match_ptr(fixed_of_match),
 	},
+	.id_table = fixed_platform_ids,
 };
 
 static int __init regulator_fixed_voltage_init(void)
Signature · 1 line
2.1.4
maintainer
#8 lore raw

Re: [PATCH v6 03/10] regulator: fixed: add device binding for platform device

Quoted 2 lines · Lu Baolu

This is needed to handle the GPIO connected USB vcc pin found on Intel Baytrail devices.

In what way is this needed? The we defualt to using the driver name if no platform ID table, AFAICT this is just restating the same string?

author
#9 lore raw

Re: [PATCH v6 03/10] regulator: fixed: add device binding for platform device

Hi Mark,

Quoted 6 lines · Mark Brown
Quoted 2 lines · Lu Baolu

This is needed to handle the GPIO connected USB vcc pin found on Intel Baytrail devices.

In what way is this needed? The we defualt to using the driver name if no platform ID table, AFAICT this is just restating the same string?

You are right. This is not a "needed". It just makes the platform driver binding explicit. We can ignore it if you don't like it.

Best regards,
Lu Baolu

author
#10 lore raw

PATCH v6 4/10 regulator: fixed: add support for ACPI interface

In reply to Lu Baolu

Add support to retrieve fixed voltage configure information through ACPI interface. This is needed for Intel Bay Trail devices, where a GPIO is used to control the USB vbus.

---
 drivers/regulator/fixed.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
drivers/regulator/fixed.c +48 -0
index e6f376f..4d0cc84 100644
@@ -30,6 +30,9 @@
 #include <linux/of_gpio.h>
 #include <linux/regulator/of_regulator.h>
 #include <linux/regulator/machine.h>
+#include <linux/acpi.h>
+#include <linux/property.h>
+#include <linux/gpio/consumer.h>
 
 struct fixed_voltage_data {
 	struct regulator_desc desc;
@@ -104,6 +107,46 @@ of_get_fixed_voltage_config(struct device *dev,
 	return config;
 }
 
+/**
+ * acpi_get_fixed_voltage_config - extract fixed_voltage_config structure info
+ * @dev: device requesting for fixed_voltage_config
+ * @desc: regulator description
+ *
+ * Populates fixed_voltage_config structure by extracting data through ACPI
+ * interface, returns a pointer to the populated structure of NULL if memory
+ * alloc fails.
+ */
+static struct fixed_voltage_config *
+acpi_get_fixed_voltage_config(struct device *dev,
+			      const struct regulator_desc *desc)
+{
+	struct fixed_voltage_config *config;
+	const char *supply_name, *gpio_name;
+	struct gpio_desc *gpiod;
+	int ret;
+
+	config = devm_kzalloc(dev, sizeof(*config), GFP_KERNEL);
+	if (!config)
+		return ERR_PTR(-ENOMEM);
+
+	ret = device_property_read_string(dev, "supply-name", &supply_name);
+	if (!ret)
+		config->supply_name = supply_name;
+
+	ret = device_property_read_string(dev, "gpio-name", &gpio_name);
+	if (!ret) {
+		gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);
+		if (!IS_ERR(gpiod)) {
+			config->gpio = desc_to_gpio(gpiod);
+			config->enable_high = device_property_read_bool(dev,
+							"enable-active-high");
+			gpiod_put(gpiod);
+		}
+	}
+
+	return config;
+}
+
 static struct regulator_ops fixed_voltage_ops = {
 };
 
@@ -124,6 +167,11 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 						     &drvdata->desc);
 		if (IS_ERR(config))
 			return PTR_ERR(config);
+	} else if (ACPI_HANDLE(&pdev->dev)) {
+		config = acpi_get_fixed_voltage_config(&pdev->dev,
+						       &drvdata->desc);
+		if (IS_ERR(config))
+			return PTR_ERR(config);
 	} else {
 		config = dev_get_platdata(&pdev->dev);
 	}
Signature · 1 line
2.1.4
maintainer
#11 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

drivers/regulator/fixed.c of_get_fixed_voltage_config(struct device *dev, · line 139

Quoted 4 lines · Lu Baolu
drivers/regulator/fixed.c +4 -0
+	ret = device_property_read_string(dev, "gpio-name", &gpio_name);
+	if (!ret) {
+		gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);
+		if (!IS_ERR(gpiod)) {

This doesn't look like it's a standard ACPI binding for GPIOs, why are we using a property to get the GPIO noame?

author
#12 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Hi Mark,

Quoted 8 lines · Mark Brown

drivers/regulator/fixed.c of_get_fixed_voltage_config(struct device *dev, · line 139

Quoted 4 lines · Lu Baolu
drivers/regulator/fixed.c +4 -0
+	ret = device_property_read_string(dev, "gpio-name", &gpio_name);
+	if (!ret) {
+		gpiod = gpiod_get(dev, gpio_name, GPIOD_ASIS);
+		if (!IS_ERR(gpiod)) {

This doesn't look like it's a standard ACPI binding for GPIOs, why are we using a property to get the GPIO noame?

The GPIO name might be different in different use cases. For my case, it is "vbus_en", but other cases should use the different name.

On ACPI compatible platforms, GPIO resources are reported via ACPI tables and (devm_)gpiod_get() hides the APCI complexity and returns the gpiod according to "gpio_name".

Best regards,
Lu Baolu

maintainer
#13 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Quoted 6 lines · Lu Baolu

The GPIO name might be different in different use cases. For my case, it is "vbus_en", but other cases should use the different name.

On ACPI compatible platforms, GPIO resources are reported via ACPI tables and (devm_)gpiod_get() hides the APCI complexity and returns the gpiod according to "gpio_name".

That's labelling that you might want to do on the supplier side or at system level. Why does the device care? It's requesting the GPIO in its own context and it's only requesting one GPIO, with DT we're just always calling the GPIO "gpio" which works fine.

author
#14 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Hi,

Quoted 9 lines · Mark Brown
Quoted 5 lines · Lu Baolu

The GPIO name might be different in different use cases. For my case, it is "vbus_en", but other cases should use the different name. On ACPI compatible platforms, GPIO resources are reported via ACPI tables and (devm_)gpiod_get() hides the APCI complexity and returns the gpiod according to "gpio_name".

That's labelling that you might want to do on the supplier side or at system level.

The labeling is done at firmware level (ACPI 5.1). It uses _DSD configuration object to give names to GPIOs. There are systems which don't contain _DSD. On those platforms, Linux kernel could do this instead.

Please refer to Documentation/acpi/gpio-properties.txt.

Quoted 3 lines

Why does the device care?It's requesting the GPIO in
its own context and it's only requesting one GPIO, with DT we're just always calling the GPIO "gpio" which works fine.

This driver is not bound to an ACPI device node directly. It's a child of a mfd device, which is corresponding to a real ACPI device node.

I agree with you that we should not retrieve gpio name from the device provider. Driver should have the knowledge of the gpio name. (Please correct me if I didn't understand your point right. :-) )

Best regards,
Lu Baolu

maintainer
#15 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Quoted 1 line · Lu Baolu

Please refer to Documentation/acpi/gpio-properties.txt.

That's not visibly what your driver is doing, that is also recommending using a static name which is what I'm asking for.

Quoted 6 lines
Quoted 3 lines

Why does the device care?It's requesting the GPIO in
its own context and it's only requesting one GPIO, with DT we're just always calling the GPIO "gpio" which works fine.

This driver is not bound to an ACPI device node directly. It's a child of a mfd device, which is corresponding to a real ACPI device node.

If it's the child of a MFD it's got an ACPI device, the ACPI device is the parent. It should use the parent device or the parent should map the GPIO through to the child as many other MFDs do, the whole concept of a MFD is a Linux internal implementation detail.

author
#16 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Hi,

Quoted 5 lines · Mark Brown
Quoted 1 line · Lu Baolu

Please refer to Documentation/acpi/gpio-properties.txt.

That's not visibly what your driver is doing, that is also recommending using a static name which is what I'm asking for.

Yes, I agree that we should use a static name.

Quoted 10 lines
Quoted 6 lines
Quoted 4 lines

Why does the device care?It's requesting the GPIO in
its own context and it's only requesting one GPIO, with DT we're just always calling the GPIO "gpio" which works fine.

This driver is not bound to an ACPI device node directly. It's a child of a mfd device, which is corresponding to a real ACPI device node.

If it's the child of a MFD it's got an ACPI device, the ACPI device is the parent.It should use the parent device or the parent should map the GPIO through to the child as many other MFDs do, the whole concept of a MFD is a Linux internal implementation detail.

Yes. The mapping of GPIO is done in the parent. And the parent passes the GPIO by setting ACPI companion to this device (done in mfd internal). This driver is able to get the gpio descriptor with a static name.

How about below code?

+ gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
+ if (IS_ERR(gpiod))
+ return PTR_ERR(gpiod);
+
+ config->gpio = desc_to_gpio(gpiod);
+ config->enable_high = device_property_read_bool(dev,
+ "enable-active-high");
+ gpiod_put(gpiod);

Best regards,
Lu Baolu

maintainer
#17 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Review

Quoted 10 lines · Lu Baolu

How about below code?

(quoted diff) +8 -0
+       gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
+       if (IS_ERR(gpiod))
+               return PTR_ERR(gpiod);
+
+       config->gpio = desc_to_gpio(gpiod);
+       config->enable_high = device_property_read_bool(dev,
+                                                       "enable-active-high");
+       gpiod_put(gpiod);

That looks reasonable, though if you use "gpio" as the name like DT you could keep the code the same which would be even better? Not super crticial though.

author
#18 lore raw

Re: [PATCH v6 04/10] regulator: fixed: add support for ACPI interface

Hi,

Quoted 12 lines · Mark Brown

Review

Quoted 9 lines · Lu Baolu

How about below code?

(quoted diff) +8 -0
+       gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
+       if (IS_ERR(gpiod))
+               return PTR_ERR(gpiod);
+
+       config->gpio = desc_to_gpio(gpiod);
+       config->enable_high = device_property_read_bool(dev,
+                                                       "enable-active-high");
+       gpiod_put(gpiod);
Quoted 3 lines

That looks reasonable, though if you use "gpio" as the name like DT you could keep the code the same which would be even better? Not super crticial though.

Systems might implement the name mapping in BIOS by implementing _DSD. The "gpio" looks a little generic. I'd like to use a function specific name.

I will send a refreshed patch later.

Best regards,
Lu Baolu

author
#19 lore raw

PATCH v6 5/10 usb: mux: add generic code for dual role port mux

In reply to Lu Baolu

Several Intel platforms implement USB dual role by having completely separate xHCI and dwc3 IPs in PCH or SOC silicons. These two IPs share a single USB port. There is another external port mux which controls where the data lines should go. While the USB controllers are part of the silicon, the port mux design are platform specific.

This patch adds the generic code to handle such usb port mux. It listens to the USB HOST extcon cable, and switch the port by calling the port switch ops provided by the individual port mux driver. It also registers the mux device with sysfs, so that users can control the port mux from user space.

Some other archs (e.g. Renesas R-Car gen2 SoCs) need an external mux to swap usb roles as well. This code could be leveraged for those archs as well.

[baolu: extcon usage reviewed by Chanwoo Choi]
---
 Documentation/ABI/testing/sysfs-bus-platform |  17 +++
 drivers/usb/Kconfig                          |   2 +
 drivers/usb/Makefile                         |   1 +
 drivers/usb/mux/Kconfig                      |  11 ++
 drivers/usb/mux/Makefile                     |   4 +
 drivers/usb/mux/portmux-core.c               | 217 +++++++++++++++++++++++++++
 include/linux/usb/portmux.h                  |  78 ++++++++++
 7 files changed, 330 insertions(+)
 create mode 100644 drivers/usb/mux/Kconfig
 create mode 100644 drivers/usb/mux/Makefile
 create mode 100644 drivers/usb/mux/portmux-core.c
 create mode 100644 include/linux/usb/portmux.h
Documentation/ABI/testing/sysfs-bus-platform +17 -0
index 5172a61..f33f0a5 100644
@@ -18,3 +18,20 @@ Description:
 		devices to opt-out of driver binding using a driver_override
 		name such as "none".  Only a single driver may be specified in
 		the override, there is no support for parsing delimiters.
+
+What:		/sys/bus/platform/devices/.../portmux.N/name
+		/sys/bus/platform/devices/.../portmux.N/state
+Date:		April 2016
+Contact:	Lu Baolu <[email protected]>
+Description:
+		In some platforms, a single USB port is shared between a USB host
+		controller and a device controller. A USB mux driver is needed to
+		handle the port mux. Read-only attribute "name" shows the name of
+		the port mux device. "state" attribute shows and stores the mux
+		state.
+		For read:
+		'peripheral' - mux switched to PERIPHERAL controller;
+		'host'       - mux switched to HOST controller.
+		For write:
+		'peripheral' - mux will be switched to PERIPHERAL controller;
+		'host'       - mux will be switched to HOST controller.
drivers/usb/Kconfig +2 -0
index 8ed451d..dbd6620 100644
@@ -149,6 +149,8 @@ endif # USB
 
 source "drivers/usb/phy/Kconfig"
 
+source "drivers/usb/mux/Kconfig"
+
 source "drivers/usb/gadget/Kconfig"
 
 config USB_LED_TRIG
drivers/usb/Makefile +1 -0
index dca7856..9a92338 100644
@@ -6,6 +6,7 @@
 
 obj-$(CONFIG_USB)		+= core/
 obj-$(CONFIG_USB_SUPPORT)	+= phy/
+obj-$(CONFIG_USB_SUPPORT)	+= mux/
 
 obj-$(CONFIG_USB_DWC3)		+= dwc3/
 obj-$(CONFIG_USB_DWC2)		+= dwc2/
drivers/usb/mux/Kconfig new file +11 -0
new file mode 100644
index 0000000..d91909f
@@ -0,0 +1,11 @@
+#
+# USB port mux driver configuration
+#
+
+menu "USB Port MUX drivers"
+config USB_PORTMUX
+	select EXTCON
+	def_bool n
+	help
+	  Generic USB dual role port mux support.
+endmenu
drivers/usb/mux/Makefile new file +4 -0
new file mode 100644
index 0000000..f85df92
@@ -0,0 +1,4 @@
+#
+# Makefile for USB port mux drivers
+#
+obj-$(CONFIG_USB_PORTMUX)		+= portmux-core.o
drivers/usb/mux/portmux-core.c new file +217 -0

217 lines not on this page · raw message

include/linux/usb/portmux.h new file +78 -0

78 lines not on this page · raw message

Signature · 1 line
2.1.4
author
#20 lore raw

PATCH v6 6/10 usb: mux: add driver for Intel gpio controlled port mux

In reply to Lu Baolu

In some Intel platforms, a single usb port is shared between USB host and device controller. The shared port is under control of GPIO pins.

This patch adds the support for USB GPIO controlled port mux.

[baolu: removed .owner per platform_no_drv_owner.cocci]
---
 drivers/usb/mux/Kconfig              |  11 +++
 drivers/usb/mux/Makefile             |   1 +
 drivers/usb/mux/portmux-intel-gpio.c | 149 +++++++++++++++++++++++++++++++++++
 3 files changed, 161 insertions(+)
 create mode 100644 drivers/usb/mux/portmux-intel-gpio.c
drivers/usb/mux/Kconfig +11 -0
index d91909f..1dc1f33 100644
@@ -8,4 +8,15 @@ config USB_PORTMUX
 	def_bool n
 	help
 	  Generic USB dual role port mux support.
+
+config INTEL_MUX_GPIO
+	tristate "Intel dual role port mux controlled by GPIOs"
+	depends on GPIOLIB
+	depends on REGULATOR
+	depends on X86 && ACPI
+	select USB_PORTMUX
+	help
+	  Say Y here to enable support for Intel dual role port mux
+	  controlled by GPIOs.
+
 endmenu
drivers/usb/mux/Makefile +1 -0
index f85df92..4eb5582 100644
@@ -2,3 +2,4 @@
 # Makefile for USB port mux drivers
 #
 obj-$(CONFIG_USB_PORTMUX)		+= portmux-core.o
+obj-$(CONFIG_INTEL_MUX_GPIO)		+= portmux-intel-gpio.o
drivers/usb/mux/portmux-intel-gpio.c new file +149 -0

149 lines not on this page · raw message

Signature · 1 line
2.1.4
author
#21 lore raw

PATCH v6 7/10 usb: mux: add driver for Intel drcfg controlled port mux

In reply to Lu Baolu

Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. The mux is handled through the Dual Role Configuration Register.

---
 drivers/usb/mux/Kconfig               |   8 ++
 drivers/usb/mux/Makefile              |   1 +
 drivers/usb/mux/portmux-intel-drcfg.c | 171 ++++++++++++++++++++++++++++++++++
 3 files changed, 180 insertions(+)
 create mode 100644 drivers/usb/mux/portmux-intel-drcfg.c
drivers/usb/mux/Kconfig +8 -0
index 1dc1f33..ae3f746 100644
@@ -19,4 +19,12 @@ config INTEL_MUX_GPIO
 	  Say Y here to enable support for Intel dual role port mux
 	  controlled by GPIOs.
 
+config INTEL_MUX_DRCFG
+	tristate "Intel dual role port mux controlled by register"
+	depends on X86
+	select USB_PORTMUX
+	help
+	  Say Y here to enable support for Intel dual role port mux
+	  controlled by the Dual Role Configuration Register.
+
 endmenu
drivers/usb/mux/Makefile +1 -0
index 4eb5582..0f102b5 100644
@@ -3,3 +3,4 @@
 #
 obj-$(CONFIG_USB_PORTMUX)		+= portmux-core.o
 obj-$(CONFIG_INTEL_MUX_GPIO)		+= portmux-intel-gpio.o
+obj-$(CONFIG_INTEL_MUX_DRCFG)		+= portmux-intel-drcfg.o
drivers/usb/mux/portmux-intel-drcfg.c new file +171 -0

171 lines not on this page · raw message

Signature · 1 line
2.1.4
author
#22 lore raw

PATCH v6 8/10 mfd: intel_vuport: Add Intel virtual USB port MFD Driver

In reply to Lu Baolu

Some Intel platforms have an USB port mux controlled by GPIOs. There's a single ACPI platform device that provides 1) USB ID extcon device; 2) USB vbus regulator device; and 3) USB port switch device. This MFD driver will split these 3 devices for their respective drivers.

[baolu: removed .owner per platform_no_drv_owner.cocci]
---
 drivers/mfd/Kconfig        |  8 +++++
 drivers/mfd/Makefile       |  1 +
 drivers/mfd/intel-vuport.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 99 insertions(+)
 create mode 100644 drivers/mfd/intel-vuport.c
drivers/mfd/Kconfig +8 -0
index eea61e3..7e115ab 100644
@@ -1578,5 +1578,13 @@ config MFD_VEXPRESS_SYSREG
 	  System Registers are the platform configuration block
 	  on the ARM Ltd. Versatile Express board.
 
+config MFD_INTEL_VUPORT
+	tristate "Intel virtual USB port controller"
+	select MFD_CORE
+	depends on X86 && ACPI
+	help
+	  Say Y here to enable support for Intel's dual role port mux
+	  controlled by GPIOs.
+
 endmenu
 endif
drivers/mfd/Makefile +1 -0
index 5eaa6465d..65b0518 100644
@@ -203,3 +203,4 @@ intel-soc-pmic-objs		:= intel_soc_pmic_core.o intel_soc_pmic_crc.o
 intel-soc-pmic-$(CONFIG_INTEL_PMC_IPC)	+= intel_soc_pmic_bxtwc.o
 obj-$(CONFIG_INTEL_SOC_PMIC)	+= intel-soc-pmic.o
 obj-$(CONFIG_MFD_MT6397)	+= mt6397-core.o
+obj-$(CONFIG_MFD_INTEL_VUPORT)	+= intel-vuport.o
drivers/mfd/intel-vuport.c new file +90 -0

90 lines not on this page · raw message

Signature · 1 line
2.1.4
author
#23 lore raw

PATCH v6 9/10 usb: pci-quirks: add Intel USB drcfg mux device

In reply to Lu Baolu

In some Intel platforms, a single usb port is shared between USB host and device controllers. The shared port is under control of a switch which is defined in the Intel vendor defined extended capability for xHCI.

This patch adds the support to detect and create the platform device for the port mux switch.

---
 drivers/usb/host/pci-quirks.c    | 45 ++++++++++++++++++++++++++++++++++++++--
 drivers/usb/host/xhci-ext-caps.h |  2 ++
 2 files changed, 45 insertions(+), 2 deletions(-)
drivers/usb/host/pci-quirks.c +43 -2
index 35af362..9bb7aa1 100644
@@ -16,10 +16,11 @@
 #include <linux/export.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>
+#include <linux/platform_device.h>
+
 #include "pci-quirks.h"
 #include "xhci-ext-caps.h"
 
-
 #define UHCI_USBLEGSUP		0xc0		/* legacy support */
 #define UHCI_USBCMD		0		/* command register */
 #define UHCI_USBINTR		4		/* interrupt register */
@@ -78,6 +79,8 @@
 #define USB_INTEL_USB3_PSSEN   0xD8
 #define USB_INTEL_USB3PRM      0xDC
 
+#define DEVICE_ID_INTEL_BROXTON_P_XHCI		0x5aa8
+
 /*
  * amd_chipset_gen values represent AMD different chipset generations
  */
@@ -956,6 +959,41 @@ void usb_disable_xhci_ports(struct pci_dev *xhci_pdev)
 }
 EXPORT_SYMBOL_GPL(usb_disable_xhci_ports);
 
+static void create_intel_usb_mux_device(struct pci_dev *xhci_pdev,
+					void __iomem *base)
+{
+	struct platform_device *plat_dev;
+	struct property_set pset;
+	int ret;
+
+	struct property_entry pentry[] = {
+		PROPERTY_ENTRY_U64("reg-start",
+				   pci_resource_start(xhci_pdev, 0) + 0x80d8),
+		PROPERTY_ENTRY_U64("reg-size", 8),
+		{ },
+	};
+
+	if (!xhci_find_next_ext_cap(base, 0, XHCI_EXT_CAPS_INTEL_USB_MUX))
+		return;
+
+	plat_dev = platform_device_alloc("intel-mux-drcfg",
+					 PLATFORM_DEVID_NONE);
+	if (!plat_dev)
+		return;
+
+	plat_dev->dev.parent = &xhci_pdev->dev;
+	pset.properties = pentry;
+	platform_device_add_properties(plat_dev, &pset);
+
+	ret = platform_device_add(plat_dev);
+	if (ret) {
+		dev_warn(&xhci_pdev->dev,
+			 "failed to create mux device with error %d",
+				ret);
+		platform_device_put(plat_dev);
+	}
+}
+
 /**
  * PCI Quirks for xHCI.
  *
@@ -1022,8 +1060,11 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 	writel(val, base + ext_cap_offset + XHCI_LEGACY_CONTROL_OFFSET);
 
 hc_init:
-	if (pdev->vendor == PCI_VENDOR_ID_INTEL)
+	if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
 		usb_enable_intel_xhci_ports(pdev);
+		if (pdev->device == DEVICE_ID_INTEL_BROXTON_P_XHCI)
+			create_intel_usb_mux_device(pdev, base);
+	}
 
 	op_reg_base = base + XHCI_HC_LENGTH(readl(base));
 
drivers/usb/host/xhci-ext-caps.h +2 -0
index e0244fb..e368ccb 100644
@@ -51,6 +51,8 @@
 #define XHCI_EXT_CAPS_ROUTE	5
 /* IDs 6-9 reserved */
 #define XHCI_EXT_CAPS_DEBUG	10
+/* Vendor defined 192-255 */
+#define XHCI_EXT_CAPS_INTEL_USB_MUX	192
 /* USB Legacy Support Capability - section 7.1.1 */
 #define XHCI_HC_BIOS_OWNED	(1 << 16)
 #define XHCI_HC_OS_OWNED	(1 << 24)
Signature · 1 line
2.1.4
author
#24 lore raw

PATCH v6 10/10 MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers

In reply to Lu Baolu

Add a maintainer entry for Intel USB dual role mux drivers and add myself as a maintainer.

---
 MAINTAINERS | 10 ++++++++++
 1 file changed, 10 insertions(+)
MAINTAINERS +10 -0
index 03e00c7..e2609e6 100644
@@ -5878,6 +5878,16 @@ S:	Maintained
 F:	arch/x86/include/asm/intel_telemetry.h
 F:	drivers/platform/x86/intel_telemetry*
 
+INTEL USB DUAL ROLE PORT MUX DRIVERS
+M:	Lu Baolu <[email protected]>
+L:	[email protected]
+S:	Supported
+F:	include/linux/usb/intel-mux.h
+F:	drivers/usb/mux/intel-mux.c
+F:	drivers/usb/mux/intel-mux-gpio.c
+F:	drivers/usb/mux/intel-mux-drcfg.c
+F:	drivers/mfd/intel-vuport.c
+
 IOC3 ETHERNET DRIVER
 M:	Ralf Baechle <[email protected]>
 L:	[email protected]
Signature · 1 line
2.1.4