(unknown)
Subsystems (3)
<[email protected]>, Doug Ledford <[email protected]> Bcc:
Subject: Re: [PATCH net] RDMA/nes: don't leak skb if carrier down
Reply-To: [email protected]
In-Reply-To: <1461529139-28582-1-git-send-email-fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>
Quoted 5 lines · Florian Westphal
Alternatively one could free the skb, OTOH I don't think this test is useful so just remove it.
Cc <[email protected]>Signed-off-by Florian Westphal <[email protected]>
I don't know why did you decide to send it to netdev and not to relevant maintainers, but the relevant mailing list is linux-rdma and Faisal needs to Review/Acknowledge it.
➜ linux-rdma git:(master) ./scripts/get_maintainer.pl -f drivers/infiniband/hw/nes/nes_nic.c
Faisal Latif <[email protected]> (supporter:NETEFFECT IWARP RNIC DRIVER (IW_NES))
Doug Ledford <[email protected]> (supporter:INFINIBAND SUBSYSTEM) Sean Hefty <[email protected]> (supporter:INFINIBAND SUBSYSTEM) Hal Rosenstock <[email protected]> (supporter:INFINIBAND SUBSYSTEM)
[email protected] (open list:NETEFFECT IWARP RNIC DRIVER (IW_NES))
[email protected] (open list)
Quoted 24 lines
---
Noticed this while working on theTX_LOCKEDremoval.drivers/infiniband/hw/nes/nes_nic.c +0
-3@@ -500,9 +500,6 @@ static int nes_netdev_start_xmit(struct sk_buff *skb, struct net_device *netdev)* skb_shinfo(skb)->nr_frags, skb_is_gso(skb)); */ -if (!netif_carrier_ok (netdev)) -return NETDEV_TX_OK ; -if (netif_queue_stopped (netdev))return NETDEV_TX_BUSY ;Signature · 6 lines
2.7.3 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html