Skip to contentSkip to conversation

i7z: new package

PATCH New Vincent Stehlé 4 participants 11 messages Apr 26, 2016 – Apr 27, 2016

lore
Share & tools
lore

Vincent Stehlé

author
#0 lore raw

PATCH 1/1 i7z: new package

"A better i7 (and now i3, i5) reporting tool for Linux."

i7z can print out the C-states and temperature for i3, i5 and i7 based Core processors from Intel (including Nehalems, Sandy Bridge and Ivy Bridge).

https://code.google.com/archive/p/i7z/

Signed-off-by Vincent Stehl? <[email protected]>
---
 package/Config.in     |  1 +
 package/i7z/Config.in | 12 ++++++++++++
 package/i7z/i7z.hash  |  2 ++
 package/i7z/i7z.mk    | 22 ++++++++++++++++++++++
 4 files changed, 37 insertions(+)
 create mode 100644 package/i7z/Config.in
 create mode 100644 package/i7z/i7z.hash
 create mode 100644 package/i7z/i7z.mk
package/Config.in +1 -0
index e860f72..2967244 100644
@@ -387,6 +387,7 @@ endif
 	source "package/hwdata/Config.in"
 	source "package/hwloc/Config.in"
 	source "package/i2c-tools/Config.in"
+	source "package/i7z/Config.in"
 	source "package/input-event-daemon/Config.in"
 	source "package/input-tools/Config.in"
 	source "package/intel-microcode/Config.in"
package/i7z/Config.in new file +12 -0
new file mode 100644
index 0000000..b4b8982
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_I7Z
+	bool "i7z"
+	depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_NCURSES
+	help
+	  "A better i7 (and now i3, i5) reporting tool for Linux."
+
+	  i7z can print out the C-states and temperature for i3, i5 and i7
+	  based Core processors from Intel (including Nehalems, Sandy Bridge
+	  and Ivy Bridge).
+
+	  https://code.google.com/archive/p/i7z/
package/i7z/i7z.hash new file +2 -0
new file mode 100644
index 0000000..1bcf2c6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 e127bddf850e7febd39cef2d2b13dca5fe19cc2a1bb1099d72b683be5d8bd1c0 i7z-5023138d7c35c4667c938b853e5ea89737334e92.tar.gz
package/i7z/i7z.mk new file +22 -0
new file mode 100644
index 0000000..e21fd9f
@@ -0,0 +1,22 @@
+################################################################################
+#
+# i7z
+#
+################################################################################
+
+I7Z_VERSION = 5023138d7c35c4667c938b853e5ea89737334e92
+I7Z_SITE = $(call github,ajaiantilal,i7z,$(I7Z_VERSION))
+I7Z_LICENSE = GPLv2
+I7Z_LICENSE_FILES = COPYING
+I7Z_DEPENDENCIES = ncurses
+
+define I7Z_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define I7Z_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) install \
+		DESTDIR="$(TARGET_DIR)"
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.8.0.rc3
#1 lore raw

PATCH 1/1 i7z: new package

Am Tue, 26 Apr 2016 16:21:44 +0200 schrieb Vincent Stehl?:

package/i7z/Config.in line 12

Quoted 1 line
package/i7z/Config.in new file +1 -0
+	  https://code.google.com/archive/p/i7z/

Hi,

this link runs into a 404 error:
"The project i7z was not found."

The Debian package https://packages.qa.debian.org/i/i7z.html
links to https://github.com/ajaiantilal/i7z

Same does Archlinux:
https://www.archlinux.org/packages/community/i686/i7z/

Regards, Bernd

author
#2 lore raw

PATCH 1/1 i7z: new package

Quoted 2 lines · Bernd Kuhls

package/i7z/Config.in line 12

Quoted 1 line
package/i7z/Config.in new file +1 -0
+	  https://code.google.com/archive/p/i7z/

this link runs into a 404 error:

Hi Bernd,

Thanks for trying. This 404 error is strange as it "works for me".

Anyway, I will link to github as you proposed in case that helps. The github project has a link to the google code page anyway.

Best regards,

Vincent.

#3 lore raw

PATCH 1/1 i7z: new package

Hello,

Quoted 7 lines · Vincent Stehl?
Quoted 2 lines · Bernd Kuhls

package/i7z/Config.in line 12

Quoted 1 line
package/i7z/Config.in new file +1 -0
+	  https://code.google.com/archive/p/i7z/

this link runs into a 404 error:

Hi Bernd,

Thanks for trying. This 404 error is strange as it "works for me".

I can confirm that https://code.google.com/archive/p/i7z/ works for me as well.

Quoted 2 lines

Anyway, I will link to github as you proposed in case that helps. The github project has a link to the google code page anyway.

Yes, the Google Code site is just an archive, it is no longer evolving. If the development has moved to Github, then you should use the Github page as the upstream URL in Config.in.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 i7z: new package

In reply to Vincent Stehlé

Am Tue, 26 Apr 2016 16:21:44 +0200 schrieb Vincent Stehl?:

package/i7z/Config.in line 5

Quoted 5 lines
package/i7z/Config.in new file +5 -0
+config BR2_PACKAGE_I7Z
+	bool "i7z"
+	depends on BR2_i386 || BR2_x86_64
+	select BR2_PACKAGE_NCURSES
+	help

Hi,

the package depends on threads:

i7z_Dual_Socket.c:23:21: fatal error: pthread.h: No such file or directory

 #include <pthread.h>
                     ^

Tested using this defconfig:

BR2_PTHREADS_NONE=y
BR2_PACKAGE_I7Z=y

Regards, Bernd

author
#5 lore raw

PATCH 1/1 i7z: new package

Quoted 1 line · Bernd Kuhls

the package depends on threads:

Hi Bernd,

Thanks for spotting that. I will fix this and re-post.

Best regards,

Vincent.

author
#6 lore raw

PATCH v2 1/1 i7z: new package

"A better i7 (and now i3, i5) reporting tool for Linux."

i7z can print out the C-states and temperature for i3, i5 and i7 based Core processors from Intel (including Nehalems, Sandy Bridge and Ivy Bridge).

https://github.com/ajaiantilal/i7z

Signed-off-by Vincent Stehl? <[email protected]>
Cc Bernd Kuhls <[email protected]>

---

Changes in v2 after Bernd's review:
- Change URL
- Depend on threads

 package/Config.in     |  1 +
 package/i7z/Config.in | 13 +++++++++++++
 package/i7z/i7z.hash  |  2 ++
 package/i7z/i7z.mk    | 22 ++++++++++++++++++++++
 4 files changed, 38 insertions(+)
 create mode 100644 package/i7z/Config.in
 create mode 100644 package/i7z/i7z.hash
 create mode 100644 package/i7z/i7z.mk
package/Config.in +1 -0
index e860f72..2967244 100644
@@ -387,6 +387,7 @@ endif
 	source "package/hwdata/Config.in"
 	source "package/hwloc/Config.in"
 	source "package/i2c-tools/Config.in"
+	source "package/i7z/Config.in"
 	source "package/input-event-daemon/Config.in"
 	source "package/input-tools/Config.in"
 	source "package/intel-microcode/Config.in"
package/i7z/Config.in new file +13 -0
new file mode 100644
index 0000000..a6b8a38
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_I7Z
+	bool "i7z"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_NCURSES
+	help
+	  "A better i7 (and now i3, i5) reporting tool for Linux."
+
+	  i7z can print out the C-states and temperature for i3, i5 and i7
+	  based Core processors from Intel (including Nehalems, Sandy Bridge
+	  and Ivy Bridge).
+
+	  https://github.com/ajaiantilal/i7z
package/i7z/i7z.hash new file +2 -0
new file mode 100644
index 0000000..1bcf2c6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 e127bddf850e7febd39cef2d2b13dca5fe19cc2a1bb1099d72b683be5d8bd1c0 i7z-5023138d7c35c4667c938b853e5ea89737334e92.tar.gz
package/i7z/i7z.mk new file +22 -0
new file mode 100644
index 0000000..e21fd9f
@@ -0,0 +1,22 @@
+################################################################################
+#
+# i7z
+#
+################################################################################
+
+I7Z_VERSION = 5023138d7c35c4667c938b853e5ea89737334e92
+I7Z_SITE = $(call github,ajaiantilal,i7z,$(I7Z_VERSION))
+I7Z_LICENSE = GPLv2
+I7Z_LICENSE_FILES = COPYING
+I7Z_DEPENDENCIES = ncurses
+
+define I7Z_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define I7Z_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) install \
+		DESTDIR="$(TARGET_DIR)"
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.8.0.rc3
#7 lore raw

PATCH v2 1/1 i7z: new package

Am Wed, 27 Apr 2016 11:25:07 +0200 schrieb Vincent Stehl?:

package/i7z/Config.in line 4

Quoted 1 line
package/i7z/Config.in new file +1 -0
+	depends on BR2_TOOLCHAIN_HAS_THREADS

Hi,

please add a comment like this to inform users why the package is not available:

comment "i7z needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS

Regards, Bernd

author
#8 lore raw

PATCH v3 1/1 i7z: new package

"A better i7 (and now i3, i5) reporting tool for Linux."

i7z can print out the C-states and temperature for i3, i5 and i7 based Core processors from Intel (including Nehalems, Sandy Bridge and Ivy Bridge).

https://github.com/ajaiantilal/i7z

Signed-off-by Vincent Stehl? <[email protected]>
Cc Bernd Kuhls <[email protected]>

---

Date: Wed, 27 Apr 2016 11:36:37 +0200
From: Bernd Kuhls <[email protected]>

Quoted 2 lines

please add a comment like this to inform users why the package is not available:

Hi Bernd,

Good idea, thanks. Here it is!

Vincent.

Changes in v3 after Bernd's review:
- Add a menu comment about dependency on toolchain with threads

Changes in v2 after Bernd's review:
- Change URL
- Depend on pthread

 package/Config.in     |  1 +
 package/i7z/Config.in | 17 +++++++++++++++++
 package/i7z/i7z.hash  |  2 ++
 package/i7z/i7z.mk    | 22 ++++++++++++++++++++++
 4 files changed, 42 insertions(+)
 create mode 100644 package/i7z/Config.in
 create mode 100644 package/i7z/i7z.hash
 create mode 100644 package/i7z/i7z.mk
package/Config.in +1 -0
index e860f72..2967244 100644
@@ -387,6 +387,7 @@ endif
 	source "package/hwdata/Config.in"
 	source "package/hwloc/Config.in"
 	source "package/i2c-tools/Config.in"
+	source "package/i7z/Config.in"
 	source "package/input-event-daemon/Config.in"
 	source "package/input-tools/Config.in"
 	source "package/intel-microcode/Config.in"
package/i7z/Config.in new file +17 -0
new file mode 100644
index 0000000..5c7803b
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_I7Z
+	bool "i7z"
+	depends on BR2_i386 || BR2_x86_64
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_NCURSES
+	help
+	  "A better i7 (and now i3, i5) reporting tool for Linux."
+
+	  i7z can print out the C-states and temperature for i3, i5 and i7
+	  based Core processors from Intel (including Nehalems, Sandy Bridge
+	  and Ivy Bridge).
+
+	  https://github.com/ajaiantilal/i7z
+
+comment "i7z needs a toolchain w/ threads"
+	depends on BR2_i386 || BR2_x86_64
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
package/i7z/i7z.hash new file +2 -0
new file mode 100644
index 0000000..1bcf2c6
@@ -0,0 +1,2 @@
+# Locally computed:
+sha256 e127bddf850e7febd39cef2d2b13dca5fe19cc2a1bb1099d72b683be5d8bd1c0 i7z-5023138d7c35c4667c938b853e5ea89737334e92.tar.gz
package/i7z/i7z.mk new file +22 -0
new file mode 100644
index 0000000..e21fd9f
@@ -0,0 +1,22 @@
+################################################################################
+#
+# i7z
+#
+################################################################################
+
+I7Z_VERSION = 5023138d7c35c4667c938b853e5ea89737334e92
+I7Z_SITE = $(call github,ajaiantilal,i7z,$(I7Z_VERSION))
+I7Z_LICENSE = GPLv2
+I7Z_LICENSE_FILES = COPYING
+I7Z_DEPENDENCIES = ncurses
+
+define I7Z_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)
+endef
+
+define I7Z_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) install \
+		DESTDIR="$(TARGET_DIR)"
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.8.0.rc3
Applied
#9 lore raw

PATCH v3 1/1 i7z: new package

Hello,

Quoted 10 lines · Vincent Stehl?

"A better i7 (and now i3, i5) reporting tool for Linux."

i7z can print out the C-states and temperature for i3, i5 and i7 based Core processors from Intel (including Nehalems, Sandy Bridge and Ivy Bridge).

https://github.com/ajaiantilal/i7z

Signed-off-by Vincent Stehl? <[email protected]>
Cc Bernd Kuhls <[email protected]>

---

Applied to master, thanks.

However, I don't know if you had a look at the source code itself. But it is really truly horrible. I think I had never seen a function taking 34 arguments, so much code WRITTEN ALMOST ENTIRELY IN CAPS and generally such an atrocity. And I'm used to looking at vendor code in Linux BSPs, so I'm somewhat used to all sort of atrocities.

https://github.com/ajaiantilal/i7z/blob/master/i7z_Dual_Socket.c

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#10 lore raw

PATCH v3 1/1 i7z: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 7 lines

However, I don't know if you had a look at the source code itself. But it is really truly horrible. I think I had never seen a function taking 34 arguments, so much code WRITTEN ALMOST ENTIRELY IN CAPS and generally such an atrocity. And I'm used to looking at vendor code in Linux BSPs, so I'm somewhat used to all sort of atrocities.

https://github.com/ajaiantilal/i7z/blob/master/i7z_Dual_Socket.c

Argh, my eyes! :/

Signature · 1 line
Bye, Peter Korsgaard