staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
PATCH 1/1 staging:xgifb: Fix Comparisons should place the constant on the right side of the test warning
Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test'
--- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/xgifb/vb_setmode.c +2 -2
@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo); -if (table[i].PANELID == tempdx) { +if (tempdx == table[i].PANELID) { tempbx = table[i].MASK; tempdx = pVBInfo->LCDInfo;
@@ -3902,7 +3902,7 @@ static struct XGI301C_Tap4TimingStruct const i =0 ;while (Tap4TimingPtr[i].DE !=0xFFFF ) { -if (Tap4TimingPtr[i].DE == tempax) +if (tempax == Tap4TimingPtr[i].DE)break ; i++; }
--
1.7.10.4
Quoted 13 lines · YU Bo
Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test'
Signed-off-by YU Bo <[email protected]>--- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/xgifb/vb_setmode.c +0
-0
drivers/staging/xgifb/vb_setmode.c static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, · line 1211
Quoted 5 lines
drivers/staging/xgifb/vb_setmode.c +1
-1@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo); -if (table[i].PANELID == tempdx) { +if (tempdx == table[i].PANELID) {
I don't understand why checkpatch is complaining about this one... It seems like a false positive. Maybe it's because .PANELID is a rubbish variable name.
regards,
dan carpetner
Quoted 17 lines · Dan Carpenter
Quoted 16 lines · YU Bo
Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test'
Signed-off-by YU Bo <[email protected]>--- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/xgifb/vb_setmode.c +0
-0@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo);
Quoted 6 lines
drivers/staging/xgifb/vb_setmode.c static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, · line 1211
Quoted 2 lines
drivers/staging/xgifb/vb_setmode.c +1
-1-if (table[i].PANELID == tempdx) { +if (tempdx == table[i].PANELID) {I don't understand why checkpatch is complaining about this one... It seems like a false positive. Maybe it's because .PANELID is a rubbish variable name.
Yes.I am also confused when i'm ready to submit the patch.Obviously 'temp[ad]x' is variable.My first patch have to wait a long time.:)
Quoted 4 lines
regards,
dan carpetner
Quoted 17 lines · Dan Carpenter
Quoted 16 lines · YU Bo
Fixed checkpatch.pl's warning 'Comparisons should place the constant on the right side of the test'
Signed-off-by YU Bo <[email protected]>--- drivers/staging/xgifb/vb_setmode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/xgifb/vb_setmode.c +0
-0@@ -1208,7 +1208,7 @@ static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table,if (pVBInfo->LCDInfo & EnableScalingLCD) tempdx &= (~PanelResInfo);
Quoted 6 lines
drivers/staging/xgifb/vb_setmode.c static void const *XGI_GetLcdPtr(struct XGI330_LCDDataTablStruct const *table, · line 1211
Quoted 2 lines
drivers/staging/xgifb/vb_setmode.c +1
-1-if (table[i].PANELID == tempdx) { +if (tempdx == table[i].PANELID) {I don't understand why checkpatch is complaining about this one... It seems like a false positive. Maybe it's because .PANELID is a rubbish variable name.
Here, it seems like to notice upper case identifier on the left.
https://lkml.org/lkml/diff/2015/8/27/469/1
Best Regards,
Quoted 4 lines
regards,
dan carpetner