arm64: Drop CONFIG_RTC_LIB dependency
PATCH 1/1 arm64: Drop CONFIG_RTC_LIB dependency
The rtc-lib dependency is not required, and seems it was just copy-pasted from ARM's Kconfig. If platform requires rtc-lib, they should select it individually.
--- arch/arm64/Kconfig | 1 - 1 file changed, 1 deletion(-)
arch/arm64/Kconfig +0 -1
@@ -99,7 +99,6 @@ config ARM64 select PERF_USE_VMALLOC select POWER_RESET select POWER_SUPPLY - select RTC_LIB select SPARSE_IRQ select SYSCTL_EXCEPTION_TRACE help
Signature · 1 line
2.7.0
PATCH 1/1 arm64: Drop CONFIG_RTC_LIB dependency
Quoted 3 lines · Ezequiel Garcia
The rtc-lib dependency is not required, and seems it was just copy-pasted from ARM's
Kconfig. If platform requires rtc-lib, they should select it individually.
Are you sure this doesn't break any platforms that are relying on this implicit select?
Will
Quoted 20 lines
Signed-off-by Ezequiel Garcia <[email protected]>--- arch/arm64/Kconfig | 1 - 1 file changed, 1 deletion(-)arch/arm64/Kconfig +0
-1@@ -99,7 +99,6 @@ config ARM64 select PERF_USE_VMALLOC select POWER_RESET select POWER_SUPPLY - select RTC_LIB select SPARSE_IRQ select SYSCTL_EXCEPTION_TRACE helpSignature · 1 line
2.7.0
PATCH 1/1 arm64: Drop CONFIG_RTC_LIB dependency
Quoted 8 lines · On Thursday 28 April 2016 13:24:25 Will Deacon wrote:
Quoted 3 lines · Ezequiel Garcia
The rtc-lib dependency is not required, and seems it was just copy-pasted from ARM's
Kconfig. If platform requires rtc-lib, they should select it individually.Are you sure this doesn't break any platforms that are relying on this implicit select?
I have checked this carefully. I actually had a patch that removed this from all of the kernel, but then found some users on other architectures. ARM and ARM64 both don't use it.
Arnd
PATCH 1/1 arm64: Drop CONFIG_RTC_LIB dependency
Quoted 6 lines · Arnd Bergmann
Quoted 5 lines · On Thursday 28 April 2016 13:24:25 Will Deacon wrote:
Quoted 3 lines · Ezequiel Garcia
The rtc-lib dependency is not required, and seems it was just copy-pasted from ARM's
Kconfig. If platform requires rtc-lib, they should select it individually.
Quoted 7 lines
Quoted 3 lines
Are you sure this doesn't break any platforms that are relying on this implicit select?
I have checked this carefully. I actually had a patch that removed this from all of the kernel, but then found some users on other architectures. ARM and ARM64 both don't use it.
Great, thanks Arnd. Can I add your reviewed-by to this patch then, please?
Will
PATCH 1/1 arm64: Drop CONFIG_RTC_LIB dependency
In reply to Ezequiel GarciaQuoted 6 lines · On Wednesday 27 April 2016 13:55:28 Ezequiel Garcia wrote:
The rtc-lib dependency is not required, and seems it was just copy-pasted from ARM's
Kconfig. If platform requires rtc-lib, they should select it individually.Signed-off-by Ezequiel Garcia <[email protected]>---
Reviewed-by:
Quoted 16 lines
arch/arm64/Kconfig | 1 - 1 file changed, 1 deletion(-)arch/arm64/Kconfig +0
-1@@ -99,7 +99,6 @@ config ARM64 select PERF_USE_VMALLOC select POWER_RESET select POWER_SUPPLY - select RTC_LIB select SPARSE_IRQ select SYSCTL_EXCEPTION_TRACE help