aic94xx: silence a static checker warning

PATCH New Dan Carpenter 1 participant 1 message May 2, 2016

Subsystems (2)

SCSI Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2016-05-02 08:34 UTC #0 lore raw

PATCH 1/1 aic94xx: silence a static checker warning

"ddb" is a number between 0-64. It can't ever be >= 0xFFFF. But the static checker complains that since we're capping the upper bound, we may as well cap the lower bound and disallow negatives as well.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/aic94xx/aic94xx_dev.c +1 -1

index 3307238..84eba3e 100644
@@ -73,7 +73,7 @@ out:
 
 static void asd_free_ddb(struct asd_ha_struct *asd_ha, int ddb)
 {
-	if (!ddb || ddb >= 0xFFFF)
+	if (ddb <= 0 || ddb >= 0xFFFF)
 		return;
 	asd_ddbsite_write_byte(asd_ha, ddb, DDB_TYPE, DDB_TYPE_UNUSED);
 	CLEAR_DDB(ddb, asd_ha);