Skip to contentSkip to conversation

Staging: dgnc: fix coding style warning in dgnc_cls.c

PATCH In review Patryk Mezydlo 3 participants 3 messages May 2, 2016 Staging

lore
Share & tools
lore

Patryk Mezydlo

author
#0 lore raw

PATCH 1/1 Staging: dgnc: fix coding style warning in dgnc_cls.c

This is a patch to the dgnc_cls.c file that fixes up a brace warning found by the checkpatch.pl tool

Signed-off-by Patryk Mezydlo <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +4 -1
index 5e46ac8..f782904 100644
@@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+	writeb((UART_FCR_ENABLE_FIFO
+		| UART_FCR_CLEAR_RCVR
+		| UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
+
 	udelay(10);
 
 	ch->ch_flags |= (CH_FIFO_ENABLED | CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM);
Signature · 1 line
2.1.4
maintainer
#1 lore raw
Quoted 13 lines · Patryk Mezydlo

This is a patch to the dgnc_cls.c file that fixes up a brace warning found by the checkpatch.pl tool

Signed-off-by Patryk Mezydlo <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index 5e46ac8..f782904 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t *ch) · line 1175

Quoted 9 lines
drivers/staging/dgnc/dgnc_cls.c +4 -1
@@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t *ch)
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+	writeb((UART_FCR_ENABLE_FIFO
+		| UART_FCR_CLEAR_RCVR
+		| UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
+

This isn't a "brace warning" fix.

And why add another blank line?

#2 lore raw
Quoted 29 lines · Greg KH

Review

Quoted 9 lines · Patryk Mezydlo

This is a patch to the dgnc_cls.c file that fixes up a brace warning found by the checkpatch.pl tool

Signed-off-by Patryk Mezydlo <[email protected]>
---
 drivers/staging/dgnc/dgnc_cls.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/staging/dgnc/dgnc_cls.c

drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t

Quoted 4 lines

index 5e46ac8..f782904 100644

drivers/staging/dgnc/dgnc_cls.c +0 -0
@@ -1168,8 +1168,11 @@ static void cls_uart_init(struct channel_t

*ch)

drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t *ch)

Quoted 4 lines
drivers/staging/dgnc/dgnc_cls.c +0 -1
 	/* Clear out UART and FIFO */
 	readb(&ch->ch_cls_uart->txrx);
 
-	writeb((UART_FCR_ENABLE_FIFO | UART_FCR_CLEAR_RCVR |

UART_FCR_CLEAR_XMIT),

drivers/staging/dgnc/dgnc_cls.c static void cls_uart_init(struct channel_t *ch) · line 1175

Quoted 5 lines
drivers/staging/dgnc/dgnc_cls.c +4 -0
+	writeb((UART_FCR_ENABLE_FIFO
+		| UART_FCR_CLEAR_RCVR
+		| UART_FCR_CLEAR_XMIT),
 	       &ch->ch_cls_uart->isr_fcr);
+

This isn't a "brace warning" fix.

Quoted 1 line

And why add another blank line?

Patryk,

Please post the checkpatch warning that was output so we can see what exactly was attempted to be corrected.

Regards,

Michael