usbnet/smsc75xx: silence uninitialized variable warning

PATCH Applied Dan Carpenter 2 participants 2 messages May 4, 2016

Subsystems (4)

Networking Network drivers USB networking drivers USB SMSC75XX Ethernet driver

lore

Share & tools

lore

Dan Carpenter

author

2016-05-04 06:21 UTC #0 lore raw

PATCH 1/1 usbnet/smsc75xx: silence uninitialized variable warning

If the fn() calls fail then "buf" is uninitialized. Just return early in that situation.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/usb/smsc75xx.c +3 -1

index c369db9..9af9799 100644
@@ -99,9 +99,11 @@ static int __must_check __smsc75xx_read_reg(struct usbnet *dev, u32 index,
 	ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN
 		 | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
 		 0, index, &buf, 4);
-	if (unlikely(ret < 0))
+	if (unlikely(ret < 0)) {
 		netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n",
 			    index, ret);
+		return ret;
+	}
 
 	le32_to_cpus(&buf);
 	*data = buf;

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

David Miller

maintainer Applied

2016-05-04 20:59 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 4 May 2016 09:21:02 +0300

Quoted 4 lines

If the fn() calls fail then "buf" is uninitialized. Just return early in that situation.
Signed-off-by Dan Carpenter <[email protected]>

Applied.