Skip to contentSkip to conversation

usbnet: smsc95xx: silence an uninitialized variable warning

PATCH Applied Dan Carpenter 2 participants 2 messages May 4, 2016

Subsystems (4)
Networking Network drivers USB networking drivers USB SMSC95XX Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 usbnet: smsc95xx: silence an uninitialized variable warning

If the call to fn() fails then "buf" is uninitialized. Just return the error code in that case.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/usb/smsc95xx.c +3 -1
index 2edc2bc..d9d2806 100644
@@ -92,9 +92,11 @@ static int __must_check __smsc95xx_read_reg(struct usbnet *dev, u32 index,
 	ret = fn(dev, USB_VENDOR_REQUEST_READ_REGISTER, USB_DIR_IN
 		 | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
 		 0, index, &buf, 4);
-	if (unlikely(ret < 0))
+	if (unlikely(ret < 0)) {
 		netdev_warn(dev->net, "Failed to read reg index 0x%08x: %d\n",
 			    index, ret);
+		return ret;
+	}
 
 	le32_to_cpus(&buf);
 	*data = buf;

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer Applied
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Wed, 4 May 2016 09:22:01 +0300

Quoted 4 lines

If the call to fn() fails then "buf" is uninitialized. Just return the error code in that case.

Signed-off-by Dan Carpenter <[email protected]>

Applied.

Please, in the future, use a consistent subsystem prefixing scheme. In these two patches you used "x/y:"" and "x: y:"

Thanks.