Skip to contentSkip to conversation

i40e: fix an uninitialized variable bug

PATCH New Dan Carpenter 2 participants 2 messages May 5, 2016 – May 9, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Intel Ethernet
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 i40e: fix an uninitialized variable bug

We removed this initialization but it is required. Let's put it back.

Fixes 895106a577c4 ('i40e: trivial fixes')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/intel/i40e/i40e_hmc.c +1 -1
index 5ebe12d..a7c7b1d 100644
@@ -49,7 +49,7 @@ i40e_status i40e_add_sd_table_entry(struct i40e_hw *hw,
 	struct i40e_hmc_sd_entry *sd_entry;
 	bool dma_mem_alloc_done = false;
 	struct i40e_dma_mem mem;
-	i40e_status ret_code;
+	i40e_status ret_code = I40E_SUCCESS;
 	u64 alloc_len;
 
 	if (NULL == hmc_info->sd_table.sd_entry) {
#1 lore raw

PATCH 1/1 i40e: fix an uninitialized variable bug

Quoted 10 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Dan Carpenter
Sent: Thursday, May 05, 2016 6:18 AM
To: Kirsher, Jeffrey T <[email protected]>; Brandeburg, Jesse <[email protected]>
Cc: kernel-janitors at vger.kernel.org; linux-kernel at vger.kernel.org; intel- wired-lan at lists.osuosl.org; netdev at vger.kernel.org
Subject: [Intel-wired-lan] [patch] i40e: fix an uninitialized variable bug

Quoted 4 lines

We removed this initialization but it is required. Let's put it back.

Fixes 895106a577c4 ('i40e: trivial fixes')
Signed-off-by Dan Carpenter <[email protected]>
Tested-by Andrew Bowers <[email protected]>

No uninitialized variable warning at compile