Skip to contentSkip to conversation

netxen: netxen_rom_fast_read() doesn't return -1

PATCH Applied Dan Carpenter 2 participants 2 messages May 5, 2016 – May 7, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Netxen (1/10) GbE support
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 netxen: netxen_rom_fast_read() doesn't return -1

The error handling is broken here. netxen_rom_fast_read() returns zero on success and -EIO on error. It never returns -1.

Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +2 -1
index fd362b6..9c6eed9 100644
@@ -852,7 +852,8 @@ netxen_check_options(struct netxen_adapter *adapter)
 	ptr32 = (__le32 *)&serial_num;
 	offset = NX_FW_SERIAL_NUM_OFFSET;
 	for (i = 0; i < 8; i++) {
-		if (netxen_rom_fast_read(adapter, offset, &val) = -1) {
+		err = netxen_rom_fast_read(adapter, offset, &val);
+		if (err) {
 			dev_err(&pdev->dev, "error reading board info\n");
 			adapter->driver_mismatch = 1;
 			return;