Skip to contentSkip to conversation

giflib: update to version 5.1.4

PATCH In review Derek Straka 2 participants 5 messages Apr 29, 2016 – May 6, 2016

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 giflib: update to version 5.1.4

- Remove EXTRA_OECONF to disable X11 support since direct X11 window rendering has been retired

---
 .../recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb}   | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb} (67%)
meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +2 -5
similarity index 67%
rename from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
rename to meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
index e59d0e5..21fa352 100644
@@ -2,14 +2,11 @@ SUMMARY = "shared library for GIF images"
 SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"
-PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-EXTRA_OECONF = "--disable-x11"
-
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
 FILES_${PN}-utils = "${bindir}"
@@ -18,5 +15,5 @@ BBCLASSEXTEND = "native"
 
 RDEPENDS_${PN}-utils = "perl"
 
-SRC_URI[md5sum] = "7125644155ae6ad33dbc9fc15a14735f"
-SRC_URI[sha256sum] = "e1c1ced9c5bc8f93ef0faf0a8c7717abf784d10a7b270d2285e8e1f3b93f2bed"
+SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
+SRC_URI[sha256sum] = "df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5"
Signature · 1 line
1.9.1
#1 lore raw

Can you check leptonica, seems to be broken by this upgrade:

http://errors.yoctoproject.org/Errors/Details/61476/

Quoted 52 lines · Derek Straka

- Remove EXTRA_OECONF to disable X11 support since direct X11 window
rendering has been retired

---
 .../recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb}   | 7
++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-devtools/giflib/{giflib_4.1.6.bb =>

giflib_5.1.4.bb} (67%)

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -5
similarity index 67%
rename from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
rename to meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
index e59d0e5..21fa352 100644
@@ -2,14 +2,11 @@ SUMMARY = "shared library for GIF images"
 SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"
-PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-EXTRA_OECONF = "--disable-x11"
-
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
 FILES_${PN}-utils = "${bindir}"
@@ -18,5 +15,5 @@ BBCLASSEXTEND = "native"
 
 RDEPENDS_${PN}-utils = "perl"
 
-SRC_URI[md5sum] = "7125644155ae6ad33dbc9fc15a14735f"
-SRC_URI[sha256sum] =

"e1c1ced9c5bc8f93ef0faf0a8c7717abf784d10a7b270d2285e8e1f3b93f2bed"

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +2 -0
+SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
+SRC_URI[sha256sum] =

"df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5" --
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw

Yes. I'll submit a patch for leptonica -> 1.73 to be compatible with giflib 5.1.x

Quoted 60 lines · Martin Jansa

Can you check leptonica, seems to be broken by this upgrade:

http://errors.yoctoproject.org/Errors/Details/61476/

Quoted 52 lines · Derek Straka

- Remove EXTRA_OECONF to disable X11 support since direct X11 window
rendering has been retired

---
 .../recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb}   | 7
++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-devtools/giflib/{giflib_4.1.6.bb =>

giflib_5.1.4.bb} (67%)

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -5
similarity index 67%
rename from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
rename to meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
index e59d0e5..21fa352 100644
@@ -2,14 +2,11 @@ SUMMARY = "shared library for GIF images"
 SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"
-PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-EXTRA_OECONF = "--disable-x11"
-
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
 FILES_${PN}-utils = "${bindir}"
@@ -18,5 +15,5 @@ BBCLASSEXTEND = "native"
 
 RDEPENDS_${PN}-utils = "perl"
 
-SRC_URI[md5sum] = "7125644155ae6ad33dbc9fc15a14735f"
-SRC_URI[sha256sum] =

"e1c1ced9c5bc8f93ef0faf0a8c7717abf784d10a7b270d2285e8e1f3b93f2bed"

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +2 -0
+SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
+SRC_URI[sha256sum] =

"df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5" --
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw
Quoted 2 lines · Derek Straka

Yes. I'll submit a patch for leptonica -> 1.73 to be compatible with giflib 5.1.x

That unblocked another issue:

| ../../../tracker-0.14.2/src/tracker-extract/tracker-extract-gif.c: In function 'tracker_extract_get_metadata':
| ../../../tracker-0.14.2/src/tracker-extract/tracker-extract-gif.c:620:17:
error: too few arguments to function 'DGifOpenFileHandle'
| if ((gifFile = DGifOpenFileHandle (fd)) == NULL) {
| ^

Whole log:
http://errors.yoctoproject.org/Errors/Details/61673/

Can you please take a look at it?

Breaking giflib API is not fun :/ even when done with good intentions:
http://esr.ibiblio.org/?p=5754

Quoted 62 lines · Martin Jansa
Quoted 61 lines

Can you check leptonica, seems to be broken by this upgrade:

http://errors.yoctoproject.org/Errors/Details/61476/

Quoted 52 lines · Derek Straka

- Remove EXTRA_OECONF to disable X11 support since direct X11 window
rendering has been retired

---
 .../recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb}   | 7
++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-devtools/giflib/{giflib_4.1.6.bb =>

giflib_5.1.4.bb} (67%)

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -5
similarity index 67%
rename from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
rename to meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb
index e59d0e5..21fa352 100644
@@ -2,14 +2,11 @@ SUMMARY = "shared library for GIF images"
 SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"
-PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-EXTRA_OECONF = "--disable-x11"
-
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
 FILES_${PN}-utils = "${bindir}"
@@ -18,5 +15,5 @@ BBCLASSEXTEND = "native"
 
 RDEPENDS_${PN}-utils = "perl"
 
-SRC_URI[md5sum] = "7125644155ae6ad33dbc9fc15a14735f"
-SRC_URI[sha256sum] =

"e1c1ced9c5bc8f93ef0faf0a8c7717abf784d10a7b270d2285e8e1f3b93f2bed"

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +2 -0
+SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
+SRC_URI[sha256sum] =

"df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5" --
1.9.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

Sure. Patch set submitted.

Quoted 92 lines · Martin Jansa
Quoted 2 lines · Derek Straka

Yes. I'll submit a patch for leptonica -> 1.73 to be compatible with giflib 5.1.x

That unblocked another issue:

| ../../../tracker-0.14.2/src/tracker-extract/tracker-extract-gif.c: In function 'tracker_extract_get_metadata':
| ../../../tracker-0.14.2/src/tracker-extract/tracker-extract-gif.c:620:17:
error: too few arguments to function 'DGifOpenFileHandle'
| if ((gifFile = DGifOpenFileHandle (fd)) == NULL) {
| ^

Whole log:
http://errors.yoctoproject.org/Errors/Details/61673/

Can you please take a look at it?

Breaking giflib API is not fun :/ even when done with good intentions:
http://esr.ibiblio.org/?p=5754

Quoted 1 line

On Tue, May 3, 2016 at 3:38 AM, Martin Jansa <[email protected]>

Quoted 6 lines · wrote:
Quoted 6 lines

Can you check leptonica, seems to be broken by this upgrade:

http://errors.yoctoproject.org/Errors/Details/61476/

On Fri, Apr 29, 2016 at 6:24 PM, Derek Straka <[email protected]>

Quoted 6 lines · wrote:
Quoted 6 lines
Quoted 6 lines

- Remove EXTRA_OECONF to disable X11 support since direct X11 window
rendering has been retired

---
.../recipes-devtools/giflib/{giflib_4.1.6.bb => giflib_5.1.4.bb}

| 7

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

++-----

 1 file changed, 2 insertions(+), 5 deletions(-)
 rename meta-oe/recipes-devtools/giflib/{giflib_4.1.6.bb =>

giflib_5.1.4.bb} (67%)

Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -0
similarity index 67%
rename from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb
Quoted 8 lines

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb SUMMARY = "shared library for GIF images" · line 4

Quoted 8 lines

rename to meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb index e59d0e5..21fa352 100644

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -0
@@ -2,14 +2,11 @@ SUMMARY = "shared library for GIF images"
 SECTION = "libs"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM =

"file://COPYING;md5=ae11c61b04b2917be39b11f78d71519a"

Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +0 -5
-PR = "r3"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/giflib/${BP}.tar.bz2"
 
 inherit autotools
 
-EXTRA_OECONF = "--disable-x11"
-
 PACKAGES += "${PN}-utils"
 FILES_${PN} = "${libdir}/libgif.so.*"
 FILES_${PN}-utils = "${bindir}"
@@ -18,5 +15,5 @@ BBCLASSEXTEND = "native"
 
 RDEPENDS_${PN}-utils = "perl"
 
-SRC_URI[md5sum] = "7125644155ae6ad33dbc9fc15a14735f"
-SRC_URI[sha256sum] =

"e1c1ced9c5bc8f93ef0faf0a8c7717abf784d10a7b270d2285e8e1f3b93f2bed"

meta-oe/recipes-devtools/giflib/giflib_5.1.4.bb renamed from meta-oe/recipes-devtools/giflib/giflib_4.1.6.bb +2 -0
+SRC_URI[md5sum] = "2c171ced93c0e83bb09e6ccad8e3ba2b"
+SRC_URI[sha256sum] =

"df27ec3ff24671f80b29e6ab1c4971059c14ac3db95406884fc26574631ba8d5" --
1.9.1

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]