Skip to contentSkip to conversation

x86/platform/UV: Add obtaining GAM Range Table from UV BIOS

DISCUSSION Dan Carpenter 1 participant 1 message May 6, 2016 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Mike Travis,

This is a semi-automatic email about new static checker warnings.

The patch ef93bf803999: "x86/platform/UV: Add obtaining GAM Range Table from UV BIOS" from Apr 29, 2016, leads to the following Smatch complaint:

arch/x86/platform/uv/bios_uv.c:207 uv_bios_init()
error: we previously assumed 'uv_systab' could be null (see line 206)

arch/x86/platform/uv/bios_uv.c
205 uv_systab = ioremap(efi.uv_systab, uv_systab->size);

   206			if (!uv_systab) {
                             ^^^^^^^^^

Check.

207 pr_err("UV: UVsystab: ioremap(%d) failed!\n",

   208					uv_systab->size);
                                        ^^^^^^^^^^^^^^^

NULL deref.

209 return;

regards,
dan carpenter