Skip to contentSkip to conversation

staging: gdm724x: fixing coding style problems listed by checkpatch

PATCH In review Bruno Carvalho 2 participants 2 messages May 6, 2016 – May 7, 2016 Staging

lore
Share & tools
lore

Bruno Carvalho

author
#0 lore raw

PATCH 1/1 staging: gdm724x: fixing coding style problems listed by checkpatch

This patch is to fix some coding style issues pointed by scripts/checkpatch.pl

Signed-off-by Bruno Carvalho <[email protected]>
---
 drivers/staging/gdm724x/gdm_mux.c |  6 ++++--
 drivers/staging/gdm724x/gdm_mux.h | 12 ++++++------
 2 files changed, 10 insertions(+), 8 deletions(-)
drivers/staging/gdm724x/gdm_mux.c +4 -2
index 6bedd66..5e661d9 100644
@@ -278,8 +278,10 @@ static void gdm_mux_rcv_complete(struct urb *urb)
 	}
 }
 
-static int gdm_mux_recv(void *priv_dev, int (*cb)(void *data, int len,
-			int tty_index, struct tty_dev *tty_dev, int complete))
+static int gdm_mux_recv(void *priv_dev,
+			int (*cb)(void *data, int len,
+				  int tty_index,
+				  struct tty_dev *tty_dev, int complete))
 {
 	struct mux_dev *mux_dev = priv_dev;
 	struct usb_device *usbdev = mux_dev->usbdev;
drivers/staging/gdm724x/gdm_mux.h +6 -6
index 3d50383..49bb90d 100644
@@ -27,8 +27,8 @@
 
 #define START_FLAG 0xA512485A
 #define MUX_HEADER_SIZE 14
-#define MUX_TX_MAX_SIZE (1024*10)
-#define MUX_RX_MAX_SIZE (1024*30)
+#define MUX_TX_MAX_SIZE (1024 * 10)
+#define MUX_RX_MAX_SIZE (1024 * 30)
 #define AT_PKT_TYPE 0xF011
 #define DM_PKT_TYPE 0xF010
 

@@ -70,9 +70,9 @@ struct rx_cxt {
 	struct list_head to_host_list;
 	struct list_head rx_submit_list;
 	struct list_head rx_free_list;
-	spinlock_t to_host_lock;
-	spinlock_t submit_list_lock;
-	spinlock_t free_list_lock;
+	spinlock_t to_host_lock;         /* spinlock for host handling */
+	spinlock_t submit_list_lock;     /* spinlock for submit list handling */
+	spinlock_t free_list_lock;       /* spinlock for free list handling */
 };
 
 struct mux_dev {

@@ -88,7 +88,7 @@ struct mux_dev {
 		     int tty_index,
 		     struct tty_dev *tty_dev,
 		     int complete);
-	spinlock_t write_lock;
+	spinlock_t write_lock;          /* spinlock for write handling */
 	struct tty_dev *tty_dev;
 };
Signature · 1 line
2.1.4
maintainer
#1 lore raw
Quoted 2 lines · Bruno Carvalho

This patch is to fix some coding style issues pointed by scripts/checkpatch.pl

Which ones specifically?

Please be descriptive, as other commits are for this driver, take a look at them for examples.

And remember, only do one "type" of change per patch, don't mix us a bunch of different types of coding style cleanups in the same patch.

Please fix this up and resend.

thanks,

greg k-h