Skip to contentSkip to conversation

Staging: android: ion: fixes use of typedef

PATCH In review Thimo Braker 2 participants 3 messages May 7, 2016 – May 8, 2016 Staging

lore
Share & tools
lore

Thimo Braker

author
#0 lore raw

PATCH 1/2 Staging: android: ion: fixes use of typedef

Fixes a checkpatch.pl warning about 'do not add new typedefs'

Signed-off-by Thimo Braker <[email protected]>
---
 drivers/staging/android/uapi/ion.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/android/uapi/ion.h +3 -5
index 0a8e40f..77a46f0 100644
@@ -20,8 +20,6 @@
 #include <linux/ioctl.h>
 #include <linux/types.h>
 
-typedef int ion_user_handle_t;
-
 /**
  * enum ion_heap_types - list of all possible types of heaps
  * @ION_HEAP_TYPE_SYSTEM:	 memory allocated via vmalloc

@@ -95,7 +93,7 @@ struct ion_allocation_data {
 	size_t align;
 	unsigned int heap_id_mask;
 	unsigned int flags;
-	ion_user_handle_t handle;
+	int handle;
 };
 
 /**

@@ -109,7 +107,7 @@ struct ion_allocation_data {
  * provides the file descriptor and the kernel returns the handle.
  */
 struct ion_fd_data {
-	ion_user_handle_t handle;
+	int handle;
 	int fd;
 };
 

@@ -118,7 +116,7 @@ struct ion_fd_data {
  * @handle:	a handle
  */
 struct ion_handle_data {
-	ion_user_handle_t handle;
+	int handle;
 };
 
 /**
Signature · 1 line
2.1.4
maintainer
#1 lore raw
Quoted 12 lines · Thimo Braker

Fixes a checkpatch.pl warning about 'do not add new typedefs'

Signed-off-by Thimo Braker <[email protected]>
---
 drivers/staging/android/uapi/ion.h | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/android/uapi/ion.h +0 -0
index 0a8e40f..77a46f0 100644

drivers/staging/android/uapi/ion.h line 24

Quoted 5 lines
drivers/staging/android/uapi/ion.h +0 -2
@@ -20,8 +20,6 @@
 #include <linux/ioctl.h>
 #include <linux/types.h>
 
-typedef int ion_user_handle_t;
-

You just broke userspace :(

Sorry, you can't do this, be careful when touching files that cross the user/kernel boundry (hint, they have uapi in the path), you have to know exactly what you are doing when you do that.

thanks,

greg k-h

author
#2 lore raw
Quoted 3 lines · Greg KH

You just broke userspace :(
[..]
(hint, they have uapi in the path)

I see I need to get used to some names ( now you say it, Uapi is quite logical ). Thanks for the feedback.

Thimo B.