Skip to contentSkip to conversation

Staging: wlan-ng: fix comments style

PATCH In review YU Bo 2 participants 4 messages May 8, 2016 – May 11, 2016 Staging

lore
Share & tools
lore

YU Bo

author
#0 lore raw

PATCH 1/1 Staging: wlan-ng: fix comments style

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line.

Signed-off-by YU Bo <[email protected]>
---
 drivers/staging/wlan-ng/prism2mgmt.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.h +2 -2
index e6472034da33..371c0fe8ae9d 100644
@@ -82,10 +82,10 @@ int prism2mgmt_flashdl_state(wlandevice_t *wlandev, void *msgp);
 int prism2mgmt_flashdl_write(wlandevice_t *wlandev, void *msgp);
 int prism2mgmt_autojoin(wlandevice_t *wlandev, void *msgp);
 
-/*---------------------------------------------------------------
+/*
 * conversion functions going between wlan message data types and
 * Prism2 data types
----------------------------------------------------------------*/
+*/
 /* byte area conversion functions*/
 void prism2mgmt_bytearea2pstr(u8 *bytearea, p80211pstrd_t *pstr, int len);

--
1.7.10.4

maintainer
#1 lore raw
Quoted 7 lines · YU Bo

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line.

Signed-off-by YU Bo <[email protected]>
---
 drivers/staging/wlan-ng/prism2mgmt.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch doesn't apply to my tree, what branch did you make this against?

thanks,

greg k-h

author
#2 lore raw

Hi Greg,

Quoted 10 lines · Kroah-Hartman
Quoted 7 lines · YU Bo

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line.

Signed-off-by YU Bo <[email protected]>
---
 drivers/staging/wlan-ng/prism2mgmt.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch doesn't apply to my tree, what branch did you make this against?

Thanks for your reply.
I made two branches on your tree:little,greg.
Each time i went into a branch and type:
git fetch origin && git rebase origin/staging-testing
then i repated on different branch.
Sure,i will reset my commit before these operations.
Due to network issue,i have to make patch on local kernel and scp patch to my VPS then send you via mutt.It's ok for me to git am xx_xx.patch but fail to apply git am xx_xx.mbox which save from mutt sometime:( I will try to send you a series of patch and test it ok.
Thanks again.

Quoted 4 lines

thanks,

greg k-h

maintainer
#3 lore raw
Quoted 11 lines · YU Bo

Hi Greg,

Quoted 9 lines · Kroah-Hartman
Quoted 7 lines · YU Bo

The patch fixed warning reported by checkpatch.pl: Block comments use a trailing */ on a separate line.

Signed-off-by YU Bo <[email protected]>
---
 drivers/staging/wlan-ng/prism2mgmt.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 5 lines
Quoted 1 line

Patch doesn't apply to my tree, what branch did you make this against?

Thanks for your reply.
I made two branches on your tree:little,greg. Each time i went into a branch and type:
git fetch origin && git rebase origin/staging-testing

Ok, good, that is the correct branch, I guess we just got out of sync here, sorry about that. Try to rebase and resend.

thanks,

greg k-h