ixgbe: Fix VLAN features error
Subsystems (2)
PATCH 1/1 ixgbe: Fix VLAN features error
It looks like at some point I somehow transposed the location of setting the VLAN features in netdev->features and the configuration of the vlan_features. As a result the driver is now generating a warning about vlan_features being setup incorrectly.
This patch corrects that by placing the update of netdev->features to include the VLAN features so that it is after the point where we write netdev->features into netdev->vlan_features.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +4 -4
@@ -9508,15 +9508,15 @@ skip_sriov:if (pci_using_dac) netdev->features |=NETIF_F_HIGHDMA ; + netdev->vlan_features |= netdev->features |NETIF_F_TSO_MANGLEID ; + netdev->hw_enc_features |= netdev->vlan_features; + netdev->mpls_features |=NETIF_F_HW_CSUM ; +/* set this bit last since it cannot be part of vlan_features */ netdev->features |=NETIF_F_HW_VLAN_CTAG_FILTER |NETIF_F_HW_VLAN_CTAG_RX |NETIF_F_HW_VLAN_CTAG_TX ; - netdev->vlan_features |= netdev->features |NETIF_F_TSO_MANGLEID ; - netdev->hw_enc_features |= netdev->vlan_features; - netdev->mpls_features |=NETIF_F_HW_CSUM ; - netdev->priv_flags |=IFF_UNICAST_FLT ; netdev->priv_flags |=IFF_SUPP_NOFCS ;
Bowers
PATCH 1/1 ixgbe: Fix VLAN features error
Quoted 17 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Alexander Duyck
Sent: Wednesday, May 11, 2016 1:24 PM
To: Schmitt, Phillip J <[email protected]>; intel-wired- lan at lists.osuosl.org; alexander.duyck at gmail.com
Subject: [Intel-wired-lan] [next PATCH] ixgbe: Fix VLAN features errorIt looks like at some point I somehow transposed the location of setting the VLAN features in
netdev->featuresand the configuration of thevlan_features. As a result the driver is now generating a warning aboutvlan_featuresbeing setup incorrectly.This patch corrects that by placing the update of
netdev->featuresto include the VLAN features so that it is after the point where we writenetdev->featuresintonetdev->vlan_features.
Quoted 5 lines
Fixes b83e30104bd9 ("ixgbe/ixgbevf: Add support for GSO partial")Signed-off-by Alexander Duyck <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
An error is no longer received when creating VLAN interfaces on ixgbe devices