Skip to contentSkip to conversation

arm: dts: am57xx: Correct the thermal thresholds

PATCH RESEND New Keerthy 3 participants 8 messages Apr 28, 2016 – May 13, 2016 Device tree bindings

lore
Share & tools
lore

Keerthy

author
#0 lore raw

cover arm: dts: am57xx: Correct the thermal thresholds

Noticed that earlier post had a wrong list name hence resending the series.

Currently all the am57xx versions are wrongly re-using the dra7 thermal threholds. Introduing the correct thermal thresholds based on industrial or commercial grade silicon present on the individual boards.

Tested on AM57XX-BEAGLE-X15 (Commercial) and AM572X-IDK(Industrial) for the trip_point node sysfs temperatures.

These patches are on top of:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/tmlind/linux-omap/+/omap-for-v4.7/dt

Keerthy (4):
ARM: dts: am57xx: Introduce commercial grade thermal thresholds
ARM: dts: am57xx: Introduce industrial grade thermal thresholds
ARM: dts: am57xx: Include the commercial grade thresholds
ARM: dts: am57xx-idk: Include Industrial grade thermal thresholds

 arch/arm/boot/dts/am57xx-beagle-x15.dts        |  1 +
 arch/arm/boot/dts/am57xx-commercial-grade.dtsi | 23 +++++++++++++++++++++++
 arch/arm/boot/dts/am57xx-idk-common.dtsi       |  2 ++
 arch/arm/boot/dts/am57xx-industrial-grade.dtsi | 23 +++++++++++++++++++++++
 4 files changed, 49 insertions(+)
 create mode 100644 arch/arm/boot/dts/am57xx-commercial-grade.dtsi
 create mode 100644 arch/arm/boot/dts/am57xx-industrial-grade.dtsi
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH RESEND 1/4 ARM: dts: am57xx: Introduce commercial grade thermal thresholds

The silicon versions which are non ES2.0 are commercial grade silicon and have lower thermal thresholds.

---
 arch/arm/boot/dts/am57xx-commercial-grade.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 arch/arm/boot/dts/am57xx-commercial-grade.dtsi
arch/arm/boot/dts/am57xx-commercial-grade.dtsi new file +23 -0
new file mode 100644
index 0000000..c183654
@@ -0,0 +1,23 @@
+&cpu_alert0 {
+	temperature = <80000>; /* milliCelsius */
+};
+
+&cpu_crit {
+	temperature = <90000>; /* milliCelsius */
+};
+
+&gpu_crit {
+	temperature = <90000>; /* milliCelsius */
+};
+
+&core_crit {
+	temperature = <90000>; /* milliCelsius */
+};
+
+&dspeve_crit {
+	temperature = <90000>; /* milliCelsius */
+};
+
+&iva_crit {
+	temperature = <90000>; /* milliCelsius */
+};
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH RESEND 2/4 ARM: dts: am57xx: Introduce industrial grade thermal thresholds

In reply to Keerthy

The silicon version ES2.0 onwards are industrial grade samples and have higher thermal thresholds than commecial grade samples.

---
 arch/arm/boot/dts/am57xx-industrial-grade.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 arch/arm/boot/dts/am57xx-industrial-grade.dtsi
arch/arm/boot/dts/am57xx-industrial-grade.dtsi new file +23 -0
new file mode 100644
index 0000000..70c8c4b
@@ -0,0 +1,23 @@
+&cpu_alert0 {
+	temperature = <90000>; /* milliCelsius */
+};
+
+&cpu_crit {
+	temperature = <105000>; /* milliCelsius */
+};
+
+&gpu_crit {
+	temperature = <105000>; /* milliCelsius */
+};
+
+&core_crit {
+	temperature = <105000>; /* milliCelsius */
+};
+
+&dspeve_crit {
+	temperature = <105000>; /* milliCelsius */
+};
+
+&iva_crit {
+	temperature = <105000>; /* milliCelsius */
+};
Signature · 1 line
1.9.1
author
#3 lore raw

PATCH RESEND 3/4 ARM: dts: am57xx-beagle-x15: Include the commercial grade thresholds

In reply to Keerthy

am57xx-beagle-x15 have commercial grade samples whose thermal thresholds lower than dra7. Hence correcting the same.

---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/am57xx-beagle-x15.dts +1 -0
index f0a0efb..f6904f6 100644
@@ -8,6 +8,7 @@
 /dts-v1/;
 
 #include "dra74x.dtsi"
+#include "am57xx-commercial-grade.dtsi"
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 
Signature · 1 line
1.9.1
author
#4 lore raw

PATCH RESEND 4/4 ARM: dts: am57xx-idk: Include Industrial grade thermal thresholds

In reply to Keerthy

am57xx-idk have Industrial grade samples whose thermal thresholds are different as compared with dra7. Hence correcting the same.

---
 arch/arm/boot/dts/am57xx-idk-common.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/am57xx-idk-common.dtsi +2 -0
index 2805b68..b01a594 100644
@@ -6,6 +6,8 @@
  * published by the Free Software Foundation.
  */
 
+#include "am57xx-industrial-grade.dtsi"
+
 / {
 	aliases {
 		rtc0 = &tps659038_rtc;
Signature · 1 line
1.9.1
#5 lore raw

cover arm: dts: am57xx: Correct the thermal thresholds

In reply to Keerthy

Tony,

Quoted 10 lines · Keerthy

Noticed that earlier post had a wrong list name hence resending the series.

Currently all the am57xx versions are wrongly re-using the dra7 thermal threholds. Introduing the correct thermal thresholds based on industrial or commercial grade silicon present on the individual boards.

Tested on AM57XX-BEAGLE-X15 (Commercial) and AM572X-IDK(Industrial) for the trip_point node sysfs temperatures.

A Gentle ping on this series.

Quoted 17 lines

These patches are on top of:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/tmlind/linux-omap/+/omap-for-v4.7/dt

Keerthy (4):
ARM: dts: am57xx: Introduce commercial grade thermal thresholds
ARM: dts: am57xx: Introduce industrial grade thermal thresholds
ARM: dts: am57xx: Include the commercial grade thresholds
ARM: dts: am57xx-idk: Include Industrial grade thermal thresholds

  arch/arm/boot/dts/am57xx-beagle-x15.dts        |  1 +
  arch/arm/boot/dts/am57xx-commercial-grade.dtsi | 23 +++++++++++++++++++++++
  arch/arm/boot/dts/am57xx-idk-common.dtsi       |  2 ++
  arch/arm/boot/dts/am57xx-industrial-grade.dtsi | 23 +++++++++++++++++++++++
  4 files changed, 49 insertions(+)

create mode 100644 arch/arm/boot/dts/am57xx-commercial-grade.dtsi create mode 100644 arch/arm/boot/dts/am57xx-industrial-grade.dtsi

#6 lore raw

cover arm: dts: am57xx: Correct the thermal thresholds

Hi,

Quoted 10 lines · Keerthy

Tony,

Quoted 7 lines · Keerthy

Noticed that earlier post had a wrong list name hence resending the series.

Currently all the am57xx versions are wrongly re-using the dra7 thermal threholds. Introduing the correct thermal thresholds based on industrial or commercial grade silicon present on the individual boards.

Quoted 5 lines
Quoted 3 lines

Tested on AM57XX-BEAGLE-X15 (Commercial) and AM572X-IDK(Industrial) for the trip_point node sysfs temperatures.

A Gentle ping on this series.

I already have these in Linux next for v4.7 merge window:

5b6042237dc8 ("ARM: dts: am57xx-idk: Include Industrial grade thermal thresholds") 266e62f97539 ("ARM: dts: am57xx-beagle-x15: Include the commercial grade thresholds") cf9b7d5e9cfd ("ARM: dts: am57xx: Introduce industrial grade thermal thresholds") 286db0a516e0 ("ARM: dts: am57xx: Introduce commercial grade thermal thresholds")

Care to check if those are OK? If fixes are needed, please post an incremental patch against current Linux next.

Regards,

Tony

#7 lore raw

cover arm: dts: am57xx: Correct the thermal thresholds

Quoted 21 lines · Tony Lindgren

Hi,

Quoted 10 lines · Keerthy

Tony,

Quoted 7 lines · Keerthy

Noticed that earlier post had a wrong list name hence resending the series.

Currently all the am57xx versions are wrongly re-using the dra7 thermal threholds. Introduing the correct thermal thresholds based on industrial or commercial grade silicon present on the individual boards.

Quoted 5 lines
Quoted 3 lines

Tested on AM57XX-BEAGLE-X15 (Commercial) and AM572X-IDK(Industrial) for the trip_point node sysfs temperatures.

A Gentle ping on this series.

I already have these in Linux next for v4.7 merge window:

Quoted 7 lines

5b6042237dc8 ("ARM: dts: am57xx-idk: Include Industrial grade thermal thresholds") 266e62f97539 ("ARM: dts: am57xx-beagle-x15: Include the commercial grade thresholds") cf9b7d5e9cfd ("ARM: dts: am57xx: Introduce industrial grade thermal thresholds") 286db0a516e0 ("ARM: dts: am57xx: Introduce commercial grade thermal thresholds")

Care to check if those are OK? If fixes are needed, please post an incremental patch against current Linux next.

Thanks Tony. Those 4 commits are fine.

Regards,
Keerthy

Quoted 5 lines

Regards,

Tony