Skip to contentSkip to conversation

ASoC: Intel: Skylake: Add channel constraints for refcap

PATCH In review Yong Zhi 2 participants 3 messages May 17, 2016 – May 19, 2016

Subsystems (3)
lore
Share & tools
lore

Yong Zhi

author
#0 lore raw

PATCH 1/2 ASoC: Intel: Skylake: Add channel constraints for refcap

Add constraint for ref DMIC to match with the
topology firmware config.

---
 sound/soc/intel/boards/skl_nau88l25_max98357a.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
sound/soc/intel/boards/skl_nau88l25_max98357a.c +14 -0
index 7cc7251..463f0e5 100644
@@ -339,8 +339,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
 	.list  = rates_16000,
 };
 
+static const unsigned int ch_mono[] = {
+	1,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_refcap = {
+	.count = ARRAY_SIZE(ch_mono),
+	.list  = ch_mono,
+};
+
 static int skylake_refcap_startup(struct snd_pcm_substream *substream)
 {
+	substream->runtime->hw.channels_max = 1;
+	snd_pcm_hw_constraint_list(substream->runtime, 0,
+					SNDRV_PCM_HW_PARAM_CHANNELS,
+					&constraints_refcap);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 				SNDRV_PCM_HW_PARAM_RATE,
 				&constraints_16000);
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 ASoC: Intel: Skylake: Use refcap device for mono recording

Only mono channel is allowed for refcap device.

---
 sound/soc/intel/boards/skl_nau88l25_ssm4567.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
sound/soc/intel/boards/skl_nau88l25_ssm4567.c +14 -0
index 73cbddb..65002bd 100644
@@ -388,8 +388,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
 	.list  = rates_16000,
 };
 
+static const unsigned int ch_mono[] = {
+	1,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_refcap = {
+	.count = ARRAY_SIZE(ch_mono),
+	.list  = ch_mono,
+};
+
 static int skylake_refcap_startup(struct snd_pcm_substream *substream)
 {
+	substream->runtime->hw.channels_max = 1;
+	snd_pcm_hw_constraint_list(substream->runtime, 0,
+					SNDRV_PCM_HW_PARAM_CHANNELS,
+					&constraints_refcap);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 			SNDRV_PCM_HW_PARAM_RATE,
 			&constraints_16000);
Signature · 1 line
1.9.1
Acked-by on v1 1/2
#2 lore raw
In reply to Yong Zhi
Quoted 4 lines · Yong Zhi

Add constraint for ref DMIC to match with the
topology firmware config.

Both:

Quoted 34 lines
---
 sound/soc/intel/boards/skl_nau88l25_max98357a.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
sound/soc/intel/boards/skl_nau88l25_max98357a.c +14 -0
index 7cc7251..463f0e5 100644
@@ -339,8 +339,22 @@ static struct snd_pcm_hw_constraint_list constraints_16000 = {
 	.list  = rates_16000,
 };
 
+static const unsigned int ch_mono[] = {
+	1,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_refcap = {
+	.count = ARRAY_SIZE(ch_mono),
+	.list  = ch_mono,
+};
+
 static int skylake_refcap_startup(struct snd_pcm_substream *substream)
 {
+	substream->runtime->hw.channels_max = 1;
+	snd_pcm_hw_constraint_list(substream->runtime, 0,
+					SNDRV_PCM_HW_PARAM_CHANNELS,
+					&constraints_refcap);
+
 	return snd_pcm_hw_constraint_list(substream->runtime, 0,
 				SNDRV_PCM_HW_PARAM_RATE,
 				&constraints_16000);
Signature · 1 line
1.9.1
Signature · 1 line
~Vinod