Skip to contentSkip to conversation

Update CONTRIBUTING.rst to allow GitHub PRs for code review purposes

PATCH In review [email protected]... 2 participants 2 messages May 19, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Update CONTRIBUTING.rst to allow GitHub PRs for code review purposes

From: Samuli Seppänen <[email protected]...>

---
 CONTRIBUTING.rst | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
CONTRIBUTING.rst +10 -6
index 6033097..f87293c 100644
@@ -4,15 +4,19 @@ CONTRIBUTING TO THE OPENVPN PROJECT
 Patches should be written against the Git "master" branch. Some patches may get
 backported to a release branch.
 
-We do not currently accept GitHub pull requests for the core OpenVPN project.
-Instead, all patches must be sent to "openvpn-devel" mailing list for review:
+The preferred procedure to send patches to the "openvpn-devel" mailing list:
 
 - https://lists.sourceforge.net/lists/listinfo/openvpn-devel
 
-The subject line should preferably be prefixed with [PATCH]. To avoid merging
-issues the patches should be generated with git-format-patch or sent using
-git-send-email. Try to split large patches into small, atomic pieces to make
-reviews easier.
+While we do not merge GitHub pull requests as-is, we do allow their use for code
+review purposes. After the patch has been ACKed (reviewed and accepted), it must
+be sent to the mailing list. This last step does not necessarily need to be done
+by the patch author, although that is definitely recommended.
+
+When sending patches to "openvpn-devel" the subject line should be prefixed with
+[PATCH]. To avoid merging issues the patches should be generated with
+git-format-patch or sent using git-send-email. Try to split large patches into
+small, atomic pieces to make reviews easier.
 
 If you want quick feedback on a patch before sending it to openvpn-devel mailing
 list, you can visit the #openvpn-devel channel on irc.freenode.net. Note that
Signature · 1 line
2.5.5
#1 lore raw

ACK, as discussed on IRC.

Your patch has been applied to the master and release/2.3 branch.

commit 698f0dab76741f4ce8c1a98236786d59eca338ef (master) commit 85f6a2b49db5544732b14ee3f0798e84329d6da1 (release/2.3)

Author: Samuli Seppänen
Date:   Thu May 19 11:51:49 2016 +0300
     Update CONTRIBUTING.rst to allow GitHub PRs for code review purposes

     Signed-off-by: Samuli Seppänen <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/11679
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering