Skip to contentSkip to conversation

edac:Fix kernel panic regression in edac_mc_reset_delay_period due to missing mode operation check

PATCH Borislav Petkov 1 participant 1 message May 20, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 3 lines · Nicholas Krause

This fixes a kernel panic regression in the function, edac_mc_reset_delay_period as show by this kernel panic trace:

...

Quoted 9 lines
 drivers/edac/edac_mc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/edac/edac_mc.c +0 -0
index 6aa256b0..c3ee3ad 100644

drivers/edac/edac_mc.c void edac_mc_reset_delay_period(unsigned long value) · line 572

Quoted 9 lines
drivers/edac/edac_mc.c +2 -1
@@ -565,7 +565,8 @@ void edac_mc_reset_delay_period(unsigned long value)
 	list_for_each(item, &mc_devices) {
 		mci = list_entry(item, struct mem_ctl_info, link);
 
-		edac_mod_work(&mci->work, value);
+		if (mci->op_state == OP_RUNNING_POLL)
+			edac_mod_work(&mci->work, value);
 	}
 	mutex_unlock(&mem_ctls_mutex);
 }

Looks good to me. I'll apply it after the merge window is over.

Thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.