Skip to contentSkip to conversation

qed: signedness bug in qed_dcbx_process_tlv()

PATCH Applied Dan Carpenter 3 participants 3 messages May 23, 2016

Subsystems (4)
Networking Network drivers Kernel janitors QLogic QL4xxx Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 qed: signedness bug in qed_dcbx_process_tlv()

"priority" needs to be signed for the error handling to work.

Fixes 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by Dan Carpenter <[email protected]>

---
Applies to the main net tree.

drivers/net/ethernet/qlogic/qed/qed_dcbx.c +2 -1
index cbf58e1..a06d19a 100644
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
 		     struct dcbx_app_priority_entry *p_tbl,
 		     u32 pri_tc_tbl, int count, bool dcbx_enabled)
 {
-	u8 tc, priority, priority_map;
+	u8 tc, priority_map;
 	enum dcbx_protocol_type type;
 	u16 protocol_id;
+	int priority;
 	bool enable;
 	int i;
Acked-by on v1 1/1
#1 lore raw

Thanks, Dan.

Acked-by Sudarsana Reddy Kalluru <[email protected]>

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: 23 May 2016 15:50
To: Yuval Mintz <[email protected]>; Sudarsana Kalluru <[email protected]>
Cc: Ariel Elior <[email protected]>; Dept-Eng Everest Linux L2 <[email protected]>; netdev <[email protected]>; [email protected]
Subject: [patch] qed: signedness bug in qed_dcbx_process_tlv()

"priority" needs to be signed for the error handling to work.

Fixes 39651abd2814 ('qed: add support for dcbx.')
Signed-off-by Dan Carpenter <[email protected]>

---
Applies to the main net tree.

drivers/net/ethernet/qlogic/qed/qed_dcbx.c +2 -1
index cbf58e1..a06d19a 100644
@@ -192,9 +192,10 @@ qed_dcbx_process_tlv(struct qed_hwfn *p_hwfn,
 		     struct dcbx_app_priority_entry *p_tbl,
 		     u32 pri_tc_tbl, int count, bool dcbx_enabled)  {
-	u8 tc, priority, priority_map;
+	u8 tc, priority_map;
 	enum dcbx_protocol_type type;
 	u16 protocol_id;
+	int priority;
 	bool enable;
 	int i;