core/pkg-kconfig: pass host PKG_CONFIG_PATH env var
PATCH 1/1 core/pkg-kconfig: pass host PKG_CONFIG_PATH env var
This is basically the same change as in 0515fe45661b6d320f8d2071df2 ("Makefile: pass host PKG_CONFIG_PATH at "make menuconfig" time"). That commit made sure to pass host PKG_CONFIG_PATH when invoking Buildroot's own menuconfig program. This change ensures that the same is true for third party menuconfig programs (i.e. Linux, uClibc and Busybox).
This unbreaks "make {linux,uclibc}-menuconfig" for host platforms which rely on PKG_CONFIG_PATH to find .pc files (e.g. NixOS). (When Busybox updates to a more recent Kconfig snapshot, one that uses pkg-config to find ncurses, "make busybox-menuconfig" will also start working.)
Tested on Ubuntu and NixOS:
$ make qemu_arm_versatile_defconfig $ make linux-menuconfig $ make
--- package/pkg-kconfig.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/pkg-kconfig.mk +2 -1
@@ -143,7 +143,8 @@ endif # nconfig, gconfig, xconfig). # So we simply remove our PATH and PKG_CONFIG_* variables. $(2)_CONFIGURATOR_MAKE_ENV = \ - $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=% PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) + $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=% PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) \ + PKG_CONFIG_PATH="$(HOST_PKG_CONFIG_PATH)" # Configuration editors (menuconfig, ...) #
Signature · 1 line
2.8.0
PATCH 1/1 core/pkg-kconfig: pass host PKG_CONFIG_PATH env var
Bj?rn, All,
On 2016-05-28 00:03 +0200, Bj?rn Forsman spake thusly:
Quoted 11 lines
This is basically the same change as in
0515fe45661b6d320f8d2071df2("Makefile: pass hostPKG_CONFIG_PATHat "make menuconfig" time"). That commit made sure to pass hostPKG_CONFIG_PATHwhen invoking Buildroot's own menuconfig program. This change ensures that the same is true for third party menuconfig programs (i.e. Linux, uClibc and Busybox).This unbreaks "make {linux,uclibc}-menuconfig" for host platforms which rely on
PKG_CONFIG_PATHto find .pc files (e.g. NixOS). (When Busybox updates to a more recentKconfigsnapshot, one that uses pkg-config to find ncurses, "make busybox-menuconfig" will also start working.)
Quoted 7 lines
Tested on Ubuntu and NixOS:
$ make qemu_arm_versatile_defconfig $ make linux-menuconfig $ makeSigned-off-by Bj?rn Forsman <[email protected]>
Regards,
Yann E. MORIN.
Quoted 25 lines
--- package/pkg-kconfig.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/pkg-kconfig.mk +2
-1@@ -143,7 +143,8 @@ endif # nconfig, gconfig, xconfig). # So we simply remove our PATH and PKG_CONFIG_* variables. $(2)_CONFIGURATOR_MAKE_ENV = \ - $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=% PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) + $$(filter-out PATH=% PKG_CONFIG=% PKG_CONFIG_SYSROOT_DIR=% PKG_CONFIG_LIBDIR=%,$$($(2)_MAKE_ENV)) \ + PKG_CONFIG_PATH="$(HOST_PKG_CONFIG_PATH)" # Configuration editors (menuconfig, ...) #Signature · 6 lines
2.8.0 _______________________________________________ buildroot mailing list buildroot at busybox.net http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
Thomas Petazzoni
AppliedPATCH 1/1 core/pkg-kconfig: pass host PKG_CONFIG_PATH env var
In reply to Bjørn ForsmanHello,
Quoted 13 lines · Bj?rn Forsman
This is basically the same change as in
0515fe45661b6d320f8d2071df2("Makefile: pass hostPKG_CONFIG_PATHat "make menuconfig" time"). That commit made sure to pass hostPKG_CONFIG_PATHwhen invoking Buildroot's own menuconfig program. This change ensures that the same is true for third party menuconfig programs (i.e. Linux, uClibc and Busybox).This unbreaks "make {linux,uclibc}-menuconfig" for host platforms which rely on
PKG_CONFIG_PATHto find .pc files (e.g. NixOS). (When Busybox updates to a more recentKconfigsnapshot, one that uses pkg-config to find ncurses, "make busybox-menuconfig" will also start working.)Tested on Ubuntu and NixOS:
Quoted 8 lines
$ make qemu_arm_versatile_defconfig $ make linux-menuconfig $ makeSigned-off-by Bj?rn Forsman <[email protected]>--- package/pkg-kconfig.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com