Skip to contentSkip to conversation

p7zip: New package

PATCH Superseded André Hentschel 4 participants 7 messages May 29, 2016 – May 31, 2016

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 p7zip: New package

---
 package/Config.in        |  1 +
 package/p7zip/Config.in  | 15 +++++++++++++++
 package/p7zip/p7zip.hash |  3 +++
 package/p7zip/p7zip.mk   | 25 +++++++++++++++++++++++++
 4 files changed, 44 insertions(+)
 create mode 100644 package/p7zip/Config.in
 create mode 100644 package/p7zip/p7zip.hash
 create mode 100644 package/p7zip/p7zip.mk
package/Config.in +1 -0
index 9d668bf..073b88e 100644
@@ -59,6 +59,7 @@ endif
 	source "package/lz4/Config.in"
 	source "package/lzip/Config.in"
 	source "package/lzop/Config.in"
+	source "package/p7zip/Config.in"
 	source "package/unrar/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	source "package/unzip/Config.in"
package/p7zip/Config.in new file +15 -0
new file mode 100644
index 0000000..1a6a4df
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb
+	help
+	  p7zip is a quick port of the command line version of 7-zip for Unix.
+	  (see http://www.7-zip.org)
+
+	  7-Zip is a file archiver with highest compression ratio.
+
+	  http://sourceforge.net/projects/p7zip
+
+comment "p7zip needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/p7zip/p7zip.hash new file +3 -0
new file mode 100644
index 0000000..ead6d87
@@ -0,0 +1,3 @@
+# From https://sourceforge.net/projects/p7zip/files/p7zip/
+md5	92cca093312b5a71a7be7dc7d1d32509	p7zip_15.14.1_src_all.tar.bz2
+sha1	9b15a79f94230fab9b9d4f9f532c723117145c7a	p7zip_15.14.1_src_all.tar.bz2
package/p7zip/p7zip.mk new file +25 -0
new file mode 100644
index 0000000..95d47d2
@@ -0,0 +1,25 @@
+################################################################################
+#
+# p7zip
+#
+################################################################################
+
+P7ZIP_VERSION = 15.14.1
+P7ZIP_SOURCE = p7zip_$(P7ZIP_VERSION)_src_all.tar.bz2
+P7ZIP_SITE = http://downloads.sourceforge.net/project/p7zip/p7zip/$(P7ZIP_VERSION)
+P7ZIP_LICENSE = LGPLv2.1+
+P7ZIP_LICENSE_FILES = DOC/License.txt
+
+# Note that the build system of p7zip is a mess, so we can't use TARGET_CONFIGURE_OPTS
+define P7ZIP_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" ALLFLAGS_C="$(TARGET_CFLAGS)" \
+		CXX="$(TARGET_CXX)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		-C $(@D) 7zr
+endef
+
+define P7ZIP_INSTALL_TARGET_CMDS
+	cp -dpf $(@D)/bin/7zr $(TARGET_DIR)/usr/bin/
+endef
+
+$(eval $(generic-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 p7zip: New package

Andr?, All,

On 2016-05-29 18:28 +0200, Andr? Hentschel spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/p7zip/Config.in line 5

Quoted 11 lines
package/p7zip/Config.in new file +5 -0
new file mode 100644
index 0000000..1a6a4df
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb

Please explain why this is limited to those architectures.

You can put it in the commit log, or you may add a terse comment just above the depends-on line. If the explanations is not straightforward, prefer the commit log.

(Yes, I read the previous reply that it was broken on NIOSII. Limiting to a small set of architectures wihtout an explanation is not enough.)

Thanks! :-)

Regards,
Yann E. MORIN.

Quoted 32 lines
package/p7zip/Config.in new file +10 -0
+	help
+	  p7zip is a quick port of the command line version of 7-zip for Unix.
+	  (see http://www.7-zip.org)
+
+	  7-Zip is a file archiver with highest compression ratio.
+
+	  http://sourceforge.net/projects/p7zip
+
+comment "p7zip needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/p7zip/p7zip.hash new file +3 -0
new file mode 100644
index 0000000..ead6d87
@@ -0,0 +1,3 @@
+# From https://sourceforge.net/projects/p7zip/files/p7zip/
+md5	92cca093312b5a71a7be7dc7d1d32509	p7zip_15.14.1_src_all.tar.bz2
+sha1	9b15a79f94230fab9b9d4f9f532c723117145c7a	p7zip_15.14.1_src_all.tar.bz2
package/p7zip/p7zip.mk new file +7 -0
new file mode 100644
index 0000000..95d47d2
@@ -0,0 +1,25 @@
+################################################################################
+#
+# p7zip
+#
+################################################################################
+
+P7ZIP_VERSION = 15.14.1

package/p7zip/p7zip.mk line 17

Quoted 10 lines
package/p7zip/p7zip.mk new file +10 -0
+P7ZIP_SOURCE = p7zip_$(P7ZIP_VERSION)_src_all.tar.bz2
+P7ZIP_SITE = http://downloads.sourceforge.net/project/p7zip/p7zip/$(P7ZIP_VERSION)
+P7ZIP_LICENSE = LGPLv2.1+
+P7ZIP_LICENSE_FILES = DOC/License.txt
+
+# Note that the build system of p7zip is a mess, so we can't use TARGET_CONFIGURE_OPTS
+define P7ZIP_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" ALLFLAGS_C="$(TARGET_CFLAGS)" \
+		CXX="$(TARGET_CXX)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \

Well, I at least see three variables in there (CC, CXX and LDFLAGS) that are in TARGET_CONFIGURE_OPTS. Can you do:

    $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \
        ALLFLAGS_C="$(TARGET_CFLAGS)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
        7zr

... instead?

Regards,
Yann E. MORIN.

Quoted 15 lines
package/p7zip/p7zip.mk new file +8 -0
+		-C $(@D) 7zr
+endef
+
+define P7ZIP_INSTALL_TARGET_CMDS
+	cp -dpf $(@D)/bin/7zr $(TARGET_DIR)/usr/bin/
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v2 1/1 p7zip: New package

Am 29.05.2016 um 19:14 schrieb Yann E. MORIN:

Quoted 2 lines

Andr?, All,

Hi

Quoted 18 lines

On 2016-05-29 18:28 +0200, Andr? Hentschel spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/p7zip/Config.in line 5

Quoted 11 lines
package/p7zip/Config.in new file +5 -0
new file mode 100644
index 0000000..1a6a4df
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb

Please explain why this is limited to those architectures.

Quoted 8 lines

You can put it in the commit log, or you may add a terse comment just above the depends-on line. If the explanations is not straightforward, prefer the commit log.

(Yes, I read the previous reply that it was broken on NIOSII. Limiting to a small set of architectures wihtout an explanation is not enough.)

Thanks! :-)

Can I start with a small set of archs until it is tested on more? (with a comment then anyway of course)

Quoted 47 lines
Quoted 33 lines
package/p7zip/Config.in new file +10 -0
+	help
+	  p7zip is a quick port of the command line version of 7-zip for Unix.
+	  (see http://www.7-zip.org)
+
+	  7-Zip is a file archiver with highest compression ratio.
+
+	  http://sourceforge.net/projects/p7zip
+
+comment "p7zip needs a toolchain w/ C++"
+	depends on !BR2_INSTALL_LIBSTDCPP
package/p7zip/p7zip.hash new file +3 -0
new file mode 100644
index 0000000..ead6d87
@@ -0,0 +1,3 @@
+# From https://sourceforge.net/projects/p7zip/files/p7zip/
+md5	92cca093312b5a71a7be7dc7d1d32509	p7zip_15.14.1_src_all.tar.bz2
+sha1	9b15a79f94230fab9b9d4f9f532c723117145c7a	p7zip_15.14.1_src_all.tar.bz2
package/p7zip/p7zip.mk new file +7 -0
new file mode 100644
index 0000000..95d47d2
@@ -0,0 +1,25 @@
+################################################################################
+#
+# p7zip
+#
+################################################################################
+
+P7ZIP_VERSION = 15.14.1

package/p7zip/p7zip.mk line 17

Quoted 10 lines
package/p7zip/p7zip.mk new file +10 -0
+P7ZIP_SOURCE = p7zip_$(P7ZIP_VERSION)_src_all.tar.bz2
+P7ZIP_SITE = http://downloads.sourceforge.net/project/p7zip/p7zip/$(P7ZIP_VERSION)
+P7ZIP_LICENSE = LGPLv2.1+
+P7ZIP_LICENSE_FILES = DOC/License.txt
+
+# Note that the build system of p7zip is a mess, so we can't use TARGET_CONFIGURE_OPTS
+define P7ZIP_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" ALLFLAGS_C="$(TARGET_CFLAGS)" \
+		CXX="$(TARGET_CXX)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \

Well, I at least see three variables in there (CC, CXX and LDFLAGS) that are in TARGET_CONFIGURE_OPTS. Can you do:

Quoted 5 lines
    $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \
        ALLFLAGS_C="$(TARGET_CFLAGS)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
        7zr

... instead?

We can't touch CFLAGS and CXXFLAGS, other option would be to patch p7zip, but it's already too messy, no intention to touch that...

#3 lore raw

PATCH v2 1/1 p7zip: New package

Andr?, All,

On 2016-05-29 19:22 +0200, Andr? Hentschel spake thusly:

Quoted 23 lines

Am 29.05.2016 um 19:14 schrieb Yann E. MORIN:

Quoted 22 lines

On 2016-05-29 18:28 +0200, Andr? Hentschel spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/p7zip/Config.in line 5

Quoted 11 lines
package/p7zip/Config.in new file +5 -0
new file mode 100644
index 0000000..1a6a4df
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb

Please explain why this is limited to those architectures.

You can put it in the commit log, or you may add a terse comment just above the depends-on line. If the explanations is not straightforward, prefer the commit log.

Quoted 7 lines
Quoted 4 lines

(Yes, I read the previous reply that it was broken on NIOSII. Limiting to a small set of architectures wihtout an explanation is not enough.)

Thanks! :-)

Can I start with a small set of archs until it is tested on more? (with a comment then anyway of course)

Yes, that's perfectly OK for me. Just say so, like:

Only enabled on a subset of known-working architectures. It fails to build on some archs, like NIOSII.

[--SNIP--]

Quoted 27 lines
Quoted 27 lines
Quoted 13 lines
package/p7zip/p7zip.mk new file +7 -0
new file mode 100644
index 0000000..95d47d2
@@ -0,0 +1,25 @@
+################################################################################
+#
+# p7zip
+#
+################################################################################
+
+P7ZIP_VERSION = 15.14.1

package/p7zip/p7zip.mk line 17

Quoted 10 lines
package/p7zip/p7zip.mk new file +10 -0
+P7ZIP_SOURCE = p7zip_$(P7ZIP_VERSION)_src_all.tar.bz2
+P7ZIP_SITE = http://downloads.sourceforge.net/project/p7zip/p7zip/$(P7ZIP_VERSION)
+P7ZIP_LICENSE = LGPLv2.1+
+P7ZIP_LICENSE_FILES = DOC/License.txt
+
+# Note that the build system of p7zip is a mess, so we can't use TARGET_CONFIGURE_OPTS
+define P7ZIP_BUILD_CMDS
+	$(MAKE) CC="$(TARGET_CC)" ALLFLAGS_C="$(TARGET_CFLAGS)" \
+		CXX="$(TARGET_CXX)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \

Well, I at least see three variables in there (CC, CXX and LDFLAGS) that are in TARGET_CONFIGURE_OPTS. Can you do:

Quoted 7 lines
Quoted 5 lines
    $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) \
        ALLFLAGS_C="$(TARGET_CFLAGS)" ALLFLAGS_CPP="$(TARGET_CXXFLAGS)" \
        7zr

... instead?

We can't touch CFLAGS and CXXFLAGS,

OK, I guess we should also say so:

    # p7zip buildsystem is a mess: it plays dirty tricks with CFLAGS and
    # CXXFLAGS, so we can't pass them. Instead, it accepts ALLFLAGS_C
    # and ALLFLAGS_CPP as variables to pass the CFLAGS and CXXFLAGS.
Quoted 2 lines

other option would be to patch
p7zip, but it's already too messy, no intention to touch that...

Meh... ;-)

Thanks!

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH v2 1/1 p7zip: New package

In reply to André Hentschel

Hello,

Quoted 12 lines · Andr? Hentschel
Quoted 12 lines

package/p7zip/Config.in line 5

Quoted 5 lines
package/p7zip/Config.in new file +5 -0
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb  

Please explain why this is limited to those architectures.

You can put it in the commit log, or you may add a terse comment just above the depends-on line. If the explanations is not straightforward, prefer the commit log.

Quoted 7 lines
Quoted 4 lines

(Yes, I read the previous reply that it was broken on NIOSII. Limiting to a small set of architectures wihtout an explanation is not enough.)

Thanks! :-)

Can I start with a small set of archs until it is tested on more? (with a comment then anyway of course)

I will disagree with Yann here. We typically do not limit the architectures based simply on what has been tested or not.

A dependency on specific architectures should only be added if the package is either 1/ contains some architecture-specific code or 2/ is known to not build/work properly on some architectures.

In any case, the fact that you could only test on i386/AArch64/ARM is not a proper reason to restrict the package to those architectures only.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH v2 1/1 p7zip: New package

Am 30.05.2016 um 15:20 schrieb Thomas Petazzoni:

Quoted 27 lines

Hello,

Quoted 12 lines · Andr? Hentschel
Quoted 12 lines

package/p7zip/Config.in line 5

Quoted 5 lines
package/p7zip/Config.in new file +5 -0
+config BR2_PACKAGE_P7ZIP
+	bool "p7zip"
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb  

Please explain why this is limited to those architectures.

You can put it in the commit log, or you may add a terse comment just above the depends-on line. If the explanations is not straightforward, prefer the commit log.

Quoted 7 lines
Quoted 4 lines

(Yes, I read the previous reply that it was broken on NIOSII. Limiting to a small set of architectures wihtout an explanation is not enough.)

Thanks! :-)

Can I start with a small set of archs until it is tested on more? (with a comment then anyway of course)

I will disagree with Yann here. We typically do not limit the architectures based simply on what has been tested or not.

Quoted 6 lines

A dependency on specific architectures should only be added if the package is either 1/ contains some architecture-specific code or 2/ is known to not build/work properly on some architectures.

In any case, the fact that you could only test on i386/AArch64/ARM is not a proper reason to restrict the package to those architectures only.

I simply used my autobuild machine now to test on almost all archs, bfin is the only troublemaker.

Quoted 9 lines

Building p7zip for blackfin using

http://autobuild.buildroot.net/toolchains/configs/bfin-uclinux.config

as defconfig fails with

../../../../CPP/myWindows/mySplitCommandLine.cpp:99:8: error: #error ENDIANNESS

Regards, Bernd

I tried it, the compiler doesn't expose ENDIANess defines... reason unknown...

#6 lore raw

PATCH v2 1/1 p7zip: New package

In reply to André Hentschel

Am Sun, 29 May 2016 18:28:19 +0200 schrieb Andr? Hentschel:

package/p7zip/Config.in line 5

Quoted 2 lines
package/p7zip/Config.in new file +2 -0
+	depends on BR2_i386 || BR2_x86_64 || \
+		BR2_aarch64 || BR2_arm || BR2_armeb

Hi Andr?,

I also tested with xtensa and microblazeel with success, please do not get confused by the list of archs in C/CpuArch.h.

Lines 69

|| (defined(__BYTE_ORDER__) && (__BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__))

and 85

|| (defined(__BYTE_ORDER__) && (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__))

are a major catch-all which however does not work out for blackfin.

Adding

|| defined(__BLACKFIN__)

around line 68 in C/CpuArch.h should be enough to fix the problem because blackfin is little endian:

https://git.busybox.net/buildroot/tree/arch/Config.in.bfin#n69

Regards, Bernd