Skip to contentSkip to conversation

perf/x86/intel/rapl: add skylake server

PATCH In review Jacob Pan 2 participants 3 messages May 24, 2016 – Jun 1, 2016

Subsystems (2)
lore
Share & tools
lore

Jacob Pan

author
#0 lore raw

PATCH 1/1 perf/x86/intel/rapl: add skylake server

SKX uses similar RAPL interface as Broadwell server.

---
 arch/x86/events/intel/rapl.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/rapl.c +1 -0
index 1705c9d..70af62a 100644
@@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
 		break;
 	case 63: /* Haswell-Server */
 	case 79: /* Broadwell-Server */
+	case 85: /* Skylake-Server */
 		apply_quirk = true;
 		rapl_cntr_mask = RAPL_IDX_SRV;
 		rapl_pmu_events_group.attrs = rapl_events_srv_attr;
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 12 lines · Jacob Pan

SKX uses similar RAPL interface as Broadwell server.

---
 arch/x86/events/intel/rapl.c | 1 +
 1 file changed, 1 insertion(+)
arch/x86/events/intel/rapl.c +0 -0
index 1705c9d..70af62a 100644

arch/x86/events/intel/rapl.c static int __init rapl_pmu_init(void) · line 718

Quoted 7 lines
arch/x86/events/intel/rapl.c +1 -0
@@ -712,6 +712,7 @@ static int __init rapl_pmu_init(void)
 		break;
 	case 63: /* Haswell-Server */
 	case 79: /* Broadwell-Server */
+	case 85: /* Skylake-Server */
 		apply_quirk = true;
 		rapl_cntr_mask = RAPL_IDX_SRV;
 		rapl_pmu_events_group.attrs = rapl_events_srv_attr;

This does not apply; please try against a more recent kernel. In specific commit:

4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver modular")

seems to the 'problem'.

author
#2 lore raw
Quoted 11 lines · On Tue, 31 May 2016 11:29:08 +0200 Peter Zijlstra <[email protected]> wrote:
Quoted 7 lines
arch/x86/events/intel/rapl.c +1 -0
 	case 63: /* Haswell-Server */
 	case 79: /* Broadwell-Server */
+	case 85: /* Skylake-Server */
 		apply_quirk = true;
 		rapl_cntr_mask = RAPL_IDX_SRV;
 		rapl_pmu_events_group.attrs =

rapl_events_srv_attr;

This does not apply; please try against a more recent kernel. In specific commit:

Quoted 4 lines

4b6e2571bf00 ("x86/perf/intel/rapl: Make the Intel RAPL PMU driver
modular")

seems to the 'problem'.

Dave Hanse (cc'd) will send out the patch as part of the clean up of open-coding x86 model numbers.