Skip to contentSkip to conversation

extensions: libxt_devgroup: Fix order of mask and id

PATCH Applied Shivani Bhardwaj 2 participants 2 messages Jun 2, 2016 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 extensions: libxt_devgroup: Fix order of mask and id

The order of mask and id in the translated code is not apt so fix it.
This patch follows commit 8548dd by Liping Zhang.

---
 extensions/libxt_devgroup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
extensions/libxt_devgroup.c +2 -2
index a30fff0..f110ea7 100644
@@ -158,8 +158,8 @@ print_devgroup_xlate(unsigned int id, uint32_t op,  unsigned int mask,
 	const char *name = NULL;
 
 	if (mask != 0xffffffff)
-		xt_xlate_add(xl, "and 0x%x %s 0x%x ", id,
-			   op == XT_OP_EQ ? "==" : "!=", mask);
+		xt_xlate_add(xl, "and 0x%x %s 0x%x ", mask,
+			   op == XT_OP_EQ ? "==" : "!=", id);
 	else {
 		if (numeric == 0)
 			name = xtables_lmap_id2name(devgroups, id);
Signature · 1 line
1.9.1
maintainer Applied
#1 lore raw
Quoted 3 lines · Shivani Bhardwaj

The order of mask and id in the translated code is not apt so fix it.
This patch follows commit 8548dd by Liping Zhang.

Applied, thanks.