arm64: fix the wrong comment
PATCH 1/1 arm64: fix the wrong comment
Currently, we use the 48-bit for the kernel and user by default. The comment becomes stale. This patch fixes the wrong comment.
--- arch/arm64/mm/proc.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/mm/proc.S +2 -2
@@ -209,8 +209,8 @@ ENTRY(__cpu_setup) bic x0, x0, x5 // clear bits orr x0, x0, x6 // set bits /* - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for - * both user and kernel. + * Set/prepare TCR. We use VA_BITS of address range for both + * kernel and user. */ ldr x10, =TCR_TxSZ(VA_BITS) | TCR_CACHE_FLAGS | TCR_SMP_FLAGS | \ TCR_TG_FLAGS | TCR_ASID16 | TCR_TBI0
Signature · 1 line
2.5.5
PATCH 1/1 arm64: fix the wrong comment
Quoted 13 lines · Huang Shijie
Currently, we use the 48-bit for the kernel and user by default. The comment becomes stale. This patch fixes the wrong comment.
Signed-off-by Huang Shijie <[email protected]>--- arch/arm64/mm/proc.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm64/mm/proc.S +0
-0
arch/arm64/mm/proc.S ENTRY(__cpu_setup) · line 214
Quoted 8 lines
arch/arm64/mm/proc.S +2
-2@@ -209,8 +209,8 @@ ENTRY(__cpu_setup) bic x0, x0, x5 // clear bits orr x0, x0, x6 // set bits /* - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for - * both user and kernel. + * Set/prepare TCR. We use VA_BITS of address range for both + * kernel and user. */
To be honest, all three of these comments (including the two in the context) are totally useless. Can we just remove them instead?
Will
PATCH 1/1 arm64: fix the wrong comment
Quoted 9 lines · Will Deacon
Quoted 8 lines · Huang Shijie
Currently, we use the 48-bit for the kernel and user by default. The comment becomes stale. This patch fixes the wrong comment.
Signed-off-by Huang Shijie <[email protected]>--- arch/arm64/mm/proc.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 16 lines
arch/arm64/mm/proc.S ENTRY(__cpu_setup) · line 214
Quoted 13 lines
arch/arm64/mm/proc.S +2
-2@@ -209,8 +209,8 @@ ENTRY(__cpu_setup) bic x0, x0, x5 // clear bits orr x0, x0, x6 // set bits /* - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for - * both user and kernel. + * Set/prepare TCR. We use VA_BITS of address range for both + * kernel and user. */To be honest, all three of these comments (including the two in the context) are totally useless. Can we just remove them instead?
Do you mean we could remove the comments like this:
--- arch/arm64/mm/proc.S | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
arch/arm64/mm/proc.S +1 -4
@@ -208,10 +208,7 @@ ENTRY(__cpu_setup) mrs x0, sctlr_el1 bic x0, x0, x5 // clear bits orr x0, x0, x6 // set bits - /* - * Set/prepare TCR and TTBR. We use 512GB (39-bit) address range for - * both user and kernel. - */ + ldr x10, =TCR_TxSZ(VA_BITS) | TCR_CACHE_FLAGS | TCR_SMP_FLAGS | \ TCR_TG_FLAGS | TCR_ASID16 | TCR_TBI0 tcr_set_idmap_t0sz x10, x9
Signature · 2 lines
thanks Huang Shijie