Skip to contentSkip to conversation

tty: serial: msm: fix definition of msm_stop_dma

PATCH New Ben Dooks 4 participants 4 messages Jun 7, 2016 – Jun 9, 2016

Subsystems (2)
Arm Qualcomm mailing list TTY layer and serial drivers
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 tty: serial: msm: fix definition of msm_stop_dma

The msm_stop_dma() is not exported from the driver, so make it static to stop the following warning:

drivers/tty/serial/msm_serial.c:84:6: warning: symbol 'msm_stop_dma' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Andy Gross <[email protected]>
Cc: David Brown <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-soc at vger.kernel.org
Cc: linux-serial at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/tty/serial/msm_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/msm_serial.c +1 -1
index b7d80bd..187f2c0 100644
@@ -81,7 +81,7 @@ struct msm_port {
 static void msm_handle_tx(struct uart_port *port);
 static void msm_start_rx_dma(struct msm_port *msm_port);
 
-void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
+static void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
 {
 	struct device *dev = port->dev;
 	unsigned int mapped;
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 tty: serial: msm: fix definition of msm_stop_dma

Quoted 6 lines · Ben Dooks

The msm_stop_dma() is not exported from the driver, so make it static to stop the following warning:

drivers/tty/serial/msm_serial.c:84:6: warning: symbol 'msm_stop_dma' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>
Reviewed-by Bjorn Andersson <[email protected]>

Regards,
Bjorn

Quoted 34 lines

---
Cc: Andy Gross <[email protected]>
Cc: David Brown <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Jiri Slaby <[email protected]>
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-soc at vger.kernel.org
Cc: linux-serial at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/tty/serial/msm_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/msm_serial.c +1 -1
index b7d80bd..187f2c0 100644
@@ -81,7 +81,7 @@ struct msm_port {
 static void msm_handle_tx(struct uart_port *port);
 static void msm_start_rx_dma(struct msm_port *msm_port);
 
-void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
+static void msm_stop_dma(struct uart_port *port, struct msm_dma *dma)
 {
 	struct device *dev = port->dev;
 	unsigned int mapped;
Signature · 7 lines
2.8.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw

PATCH 1/1 tty: serial: msm: fix definition of msm_stop_dma

In reply to Ben Dooks
Quoted 7 lines · Ben Dooks

The msm_stop_dma() is not exported from the driver, so make it static to stop the following warning:

drivers/tty/serial/msm_serial.c:84:6: warning: symbol 'msm_stop_dma' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---

Reviewed-by Stephen Boyd <[email protected]>
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project