Skip to contentSkip to conversation

dmaengine: sirf: fix un-exported struct warnings

PATCH New Ben Dooks 2 participants 2 messages Jun 7, 2016 – Jun 8, 2016 dmaengine

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 dmaengine: sirf: fix un-exported struct warnings

The sirfsoc_dmadata structs are not used outside the driver, so remove build warnings by making them static. Fixes:

drivers/dma/sirf-dma.c:1129:24: warning: symbol 'sirfsoc_dmadata_a6' was not declared. Should it be static? drivers/dma/sirf-dma.c:1134:24: warning: symbol 'sirfsoc_dmadata_a7v1' was not declared. Should it be static? drivers/dma/sirf-dma.c:1139:24: warning: symbol 'sirfsoc_dmadata_a7v2' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: Barry Song <[email protected]>
Cc: dmaengine at vger.kernel.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/dma/sirf-dma.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/dma/sirf-dma.c +3 -3
index e48350e..dde392d 100644
@@ -1126,17 +1126,17 @@ static const struct dev_pm_ops sirfsoc_dma_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(sirfsoc_dma_pm_suspend, sirfsoc_dma_pm_resume)
 };
 
-struct sirfsoc_dmadata sirfsoc_dmadata_a6 = {
+static struct sirfsoc_dmadata sirfsoc_dmadata_a6 = {
 	.exec = sirfsoc_dma_execute_hw_a6,
 	.type = SIRFSOC_DMA_VER_A6,
 };
 
-struct sirfsoc_dmadata sirfsoc_dmadata_a7v1 = {
+static struct sirfsoc_dmadata sirfsoc_dmadata_a7v1 = {
 	.exec = sirfsoc_dma_execute_hw_a7v1,
 	.type = SIRFSOC_DMA_VER_A7V1,
 };
 
-struct sirfsoc_dmadata sirfsoc_dmadata_a7v2 = {
+static struct sirfsoc_dmadata sirfsoc_dmadata_a7v2 = {
 	.exec = sirfsoc_dma_execute_hw_a7v2,
 	.type = SIRFSOC_DMA_VER_A7V2,
 };
Signature · 1 line
2.8.1
Applied
#1 lore raw

PATCH 1/1 dmaengine: sirf: fix un-exported struct warnings

Quoted 2 lines · Ben Dooks

The sirfsoc_dmadata structs are not used outside the driver, so remove build warnings by making them static. Fixes:

Applied, thanks

Signature · 1 line
~Vinod