Skip to contentSkip to conversation

dmaengine: at_xdmac: fix un-exported functions

PATCH New Ben Dooks 2 participants 2 messages Jun 7, 2016 – Jun 8, 2016

Subsystems (2)
dmaengine Microchip AT91 DMA drivers
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 dmaengine: at_xdmac: fix un-exported functions

The at_xdmac_init_used_desc() and at_xdmac_prep_dma_memset() functions are not exported outside the driver, so make them static to avoid the following warnings:

drivers/dma/at_xdmac.c:459:6: warning: symbol 'at_xdmac_init_used_desc' was not declared. Should it be static? drivers/dma/at_xdmac.c:1205:32: warning: symbol 'at_xdmac_prep_dma_memset' was not declared. Should it be static?

Signed-off-by Ben Dooks <[email protected]>

---
Cc: Ludovic Desroches <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: linux-arm-kernel at lists.infradead.org
Cc: dmaengine at vger.kernel.org

---
 drivers/dma/at_xdmac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/at_xdmac.c +2 -2
index 8e304b1..2503b40 100644
@@ -456,7 +456,7 @@ static struct at_xdmac_desc *at_xdmac_alloc_desc(struct dma_chan *chan,
 	return desc;
 }
 
-void at_xdmac_init_used_desc(struct at_xdmac_desc *desc)
+static void at_xdmac_init_used_desc(struct at_xdmac_desc *desc)
 {
 	memset(&desc->lld, 0, sizeof(desc->lld));
 	INIT_LIST_HEAD(&desc->descs_list);

@@ -1202,7 +1202,7 @@ static struct at_xdmac_desc *at_xdmac_memset_create_desc(struct dma_chan *chan,
 	return desc;
 }
 
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
 at_xdmac_prep_dma_memset(struct dma_chan *chan, dma_addr_t dest, int value,
 			 size_t len, unsigned long flags)
 {
Signature · 1 line
2.8.1
Applied
#1 lore raw

PATCH 1/1 dmaengine: at_xdmac: fix un-exported functions

Quoted 3 lines · Ben Dooks

The at_xdmac_init_used_desc() and at_xdmac_prep_dma_memset() functions are not exported outside the driver, so make them static to avoid the following warnings:

Applied, thanks

Signature · 1 line
~Vinod