Skip to contentSkip to conversation

dmaengine: bcm2835: fix unexported function

PATCH New Ben Dooks 3 participants 3 messages Jun 7, 2016 – Jun 8, 2016

Subsystems (3)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 dmaengine: bcm2835: fix unexported function

The bcm2835_dma_prep_dma_memcpy() function is not exported outside the driver, so make it static to avoid the following warning:

drivers/dma/bcm2835-dma.c:616:32: warning: symbol 'bcm2835_dma_prep_dma_memcpy' was not declared. Should it be static?

---
Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>
Cc: Stephen Warren <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: Eric Anholt <[email protected]>
Cc: dmaengine at vger.kernel.org
Cc: linux-rpi-kernel at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org

---
 drivers/dma/bcm2835-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/bcm2835-dma.c +1 -1
index 6149b27..9ecb942 100644
@@ -613,7 +613,7 @@ static void bcm2835_dma_issue_pending(struct dma_chan *chan)
 	spin_unlock_irqrestore(&c->vc.lock, flags);
 }
 
-struct dma_async_tx_descriptor *bcm2835_dma_prep_dma_memcpy(
+static struct dma_async_tx_descriptor *bcm2835_dma_prep_dma_memcpy(
 	struct dma_chan *chan, dma_addr_t dst, dma_addr_t src,
 	size_t len, unsigned long flags)
 {
Signature · 1 line
2.8.1
#1 lore raw

PATCH 1/1 dmaengine: bcm2835: fix unexported function

Quoted 7 lines · Ben Dooks

The bcm2835_dma_prep_dma_memcpy() function is not exported outside the driver, so make it static to avoid the following warning:

drivers/dma/bcm2835-dma.c:616:32: warning: symbol 'bcm2835_dma_prep_dma_memcpy' was not declared. Should it be static?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160607/3d61cfcc/attachment.sig>

Applied
#2 lore raw

PATCH 1/1 dmaengine: bcm2835: fix unexported function

In reply to Ben Dooks
Quoted 3 lines · Ben Dooks

The bcm2835_dma_prep_dma_memcpy() function is not exported outside the driver, so make it static to avoid the following warning:

Applied, thanks

Signature · 1 line
~Vinod