Skip to contentSkip to conversation

kmsxx: new package

PATCH Superseded Maxime Ripard 3 participants 8 messages May 9, 2016 – Jun 8, 2016 2 messages not in the archive

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 kmsxx: new package

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

---
Changes from v2:
- Added support for the python bindings
- Added extra dependencies (gcc 4.8, libstdc++ installation)

 package/Config.in       |  1 +
 package/kmsxx/Config.in | 32 ++++++++++++++++++++++++++++
 package/kmsxx/kmsxx.mk  | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 88 insertions(+)
 create mode 100644 package/kmsxx/Config.in
 create mode 100644 package/kmsxx/kmsxx.mk
package/Config.in +1 -0
index 529ad3364994..4bb60ead530b 100644
@@ -867,6 +867,7 @@ menu "Graphics"
 	source "package/imlib2/Config.in"
 	source "package/jasper/Config.in"
 	source "package/jpeg/Config.in"
+	source "package/kmsxx/Config.in"
 	source "package/lcms2/Config.in"
 	source "package/lesstif/Config.in"
 	source "package/libart/Config.in"
package/kmsxx/Config.in new file +32 -0
new file mode 100644
index 000000000000..748f65342f3d
@@ -0,0 +1,32 @@
+config BR2_PACKAGE_KMSXX
+	bool "kmsxx"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
+	select BR2_PACKAGE_LIBDRM
+	help
+	  libkms++ is a C++11 library for kernel mode setting.
+
+	  Also included are simple test tools for KMS and python wrapper for
+	  libkms++.
+
+	  https://github.com/tomba/kmsxx
+
+if BR2_PACKAGE_KMSXX
+
+config BR2_PACKAGE_KMSXX_INSTALL_TESTS
+	bool "Install test programs"
+	help
+	  This option allows to install the kmsxx test programs.
+
+config BR2_PACKAGE_KMSXX_BINDINGS_PYTHON
+	bool "Install Python bindings"
+	depends on BR2_PACKAGE_PYTHON3
+	help
+	  Install the python bindings
+
+endif
+
+comment "kmsxx needs a toolchain w/ threads"
+        depends on !BR2_TOOLCHAIN_HAS_THREADS
+
package/kmsxx/kmsxx.mk new file +55 -0

55 lines not on this page · raw message

Signature · 1 line
2.8.2
#1 lore raw

PATCH v2 1/1 kmsxx: new package

Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160602/9a38a1bf/attachment.asc>
#2 lore raw

PATCH v2 1/1 kmsxx: new package

Hi Maxime ,

Quoted 7 lines · Maxime Ripard
Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

What about removing Python bindings config option and just check if Python 3 is activated in *.mk file? See package/libcec/libcec.mk for reference.

Though libdrm already requires host-pkgconf, should this dependency appear in kms.mk?

I've looked at CMakeLIsts.txt in master branch of the project and I cannot see swig invocation. They just seem to compile some cpp files in py folder.

Could also ask project maintainers to add some cpack stuff?

Yegor

A message that is not in the archive (sent off-list or not yet received): 91587869.72Lxhe2Mek@avalon

#4 lore raw

PATCH v2 1/1 kmsxx: new package

Quoted 16 lines · Laurent Pinchart

Hi Yegor,

Quoted 13 lines · On Wednesday 08 Jun 2016 12:11:10 Yegor Yefremov wrote:
Quoted 7 lines · Maxime Ripard
Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

What about removing Python bindings config option and just check if Python 3 is activated in *.mk file? See package/libcec/libcec.mk for reference.

Quoted 8 lines
Quoted 6 lines

Though libdrm already requires host-pkgconf, should this dependency appear in kms.mk?

I've looked at CMakeLIsts.txt in master branch of the project and I cannot see swig invocation. They just seem to compile some cpp files in py folder.

The dependency on swig got removed recently, they now use pybind11.

In other words we need https://pypi.python.org/pypi/pybind11 as a host package?

Yegor

A message that is not in the archive (sent off-list or not yet received): 146541087.IVqEMkkuFm@avalon

#6 lore raw

PATCH v2 1/1 kmsxx: new package

Quoted 25 lines · Laurent Pinchart

Hi Yegor,

Quoted 22 lines · On Wednesday 08 Jun 2016 12:27:21 Yegor Yefremov wrote:
Quoted 21 lines · Laurent Pinchart
Quoted 19 lines · On Wednesday 08 Jun 2016 12:11:10 Yegor Yefremov wrote:
Quoted 7 lines · Maxime Ripard
Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

What about removing Python bindings config option and just check if Python 3 is activated in *.mk file? See package/libcec/libcec.mk for reference.

Though libdrm already requires host-pkgconf, should this dependency appear in kms.mk?

I've looked at CMakeLIsts.txt in master branch of the project and I cannot see swig invocation. They just seem to compile some cpp files in py folder.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

The dependency on swig got removed recently, they now use pybind11.

In other words we need https://pypi.python.org/pypi/pybind11 as a host package?

I don't think so, kmsxx includes pybind11 as a submodule.

I mean for the future. And if pybind11 would also supply pybin11.pc, then CMake could even automatically find it.

#7 lore raw

PATCH v2 1/1 kmsxx: new package

Quoted 29 lines · Yegor Yefremov
Quoted 27 lines · Laurent Pinchart

Hi Yegor,

Quoted 24 lines · On Wednesday 08 Jun 2016 12:27:21 Yegor Yefremov wrote:
Quoted 22 lines · Laurent Pinchart
Quoted 13 lines · On Wednesday 08 Jun 2016 12:11:10 Yegor Yefremov wrote:
Quoted 7 lines · Maxime Ripard
Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

What about removing Python bindings config option and just check if Python 3 is activated in *.mk file? See package/libcec/libcec.mk for reference.

Quoted 6 lines

Though libdrm already requires host-pkgconf, should this dependency appear in kms.mk?

I've looked at CMakeLIsts.txt in master branch of the project and I cannot see swig invocation. They just seem to compile some cpp files in py folder.

The dependency on swig got removed recently, they now use pybind11.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

In other words we need https://pypi.python.org/pypi/pybind11 as a host package?

I don't think so, kmsxx includes pybind11 as a submodule.

I mean for the future. And if pybind11 would also supply pybin11.pc, then CMake could even automatically find it.

As to pkg-config support it won't happen any time soon :-(

https://github.com/pybind/pybind11/issues/230

#8 lore raw

PATCH v2 1/1 kmsxx: new package

Quoted 34 lines · Yegor Yefremov
Quoted 32 lines · Yegor Yefremov
Quoted 30 lines · Laurent Pinchart

Hi Yegor,

Quoted 26 lines · On Wednesday 08 Jun 2016 12:27:21 Yegor Yefremov wrote:
Quoted 14 lines · Laurent Pinchart
Quoted 13 lines · On Wednesday 08 Jun 2016 12:11:10 Yegor Yefremov wrote:
Quoted 7 lines · Maxime Ripard
Quoted 4 lines · Maxime Ripard

KMS++ is a suite of library and test tools to interact with KMS drivers in the linux kernel.

Ping?

What about removing Python bindings config option and just check if Python 3 is activated in *.mk file? See package/libcec/libcec.mk for reference.

Quoted 8 lines
Quoted 6 lines

Though libdrm already requires host-pkgconf, should this dependency appear in kms.mk?

I've looked at CMakeLIsts.txt in master branch of the project and I cannot see swig invocation. They just seem to compile some cpp files in py folder.

The dependency on swig got removed recently, they now use pybind11.

In other words we need https://pypi.python.org/pypi/pybind11 as a host package?

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

I don't think so, kmsxx includes pybind11 as a submodule.

I mean for the future. And if pybind11 would also supply pybin11.pc, then CMake could even automatically find it.

As to pkg-config support it won't happen any time soon :-(

https://github.com/pybind/pybind11/issues/230

Honestly, I don't care at all about the python bindings.

I'll remove support for that in the v3, and if anyone is ever interested in adding support for it, he'll work on it (and things will have settled down hopefully)

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160608/dec3d75f/attachment.asc>
#9 lore raw

PATCH v2 1/1 kmsxx: new package

Hello,

Quoted 5 lines · Maxime Ripard

Honestly, I don't care at all about the python bindings.

I'll remove support for that in the v3, and if anyone is ever interested in adding support for it, he'll work on it (and things will have settled down hopefully)

FWIW: I discussed this topic with Maxime today. I very much prefer having a basic kmsxx package merged, with the features that Maxime uses/needs, rather than waiting endlessly to resolve all the Python bindings issues. So let's merge a simpler version of kmsxx that doesn't have the Python bindings, and when someone is interested enough to have the Python bindings, this someone can submit follow-up patches.

So, yes, Maxime: please send a simpler version of the patch.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com