Skip to contentSkip to conversation

ARM: mxs: dts: Add SSP2 SD mux

PATCH Superseded Marek Vasut 4 participants 13 messages May 8, 2016 – Jun 9, 2016

Subsystems (3)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ARM: mxs: dts: Add SSP2 SD mux

From: Marek Vasut <[email protected]>

Add pinmux configuration for SSP2 port in SD mode, both for the 4-bit and 8-bit case.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
---
 arch/arm/boot/dts/imx23.dtsi | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/imx23.dtsi +34 -0
index 302d116..c70ebef 100644
@@ -249,6 +249,40 @@
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
+				mmc1_4bit_pins_a: mmc1-4bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						MX23_PAD_GPMI_D00__SSP2_DATA0
+						MX23_PAD_GPMI_D01__SSP2_DATA1
+						MX23_PAD_GPMI_D02__SSP2_DATA2
+						MX23_PAD_GPMI_D03__SSP2_DATA3
+						MX23_PAD_GPMI_RDY1__SSP2_CMD
+						MX23_PAD_GPMI_WRN__SSP2_SCK
+					>;
+					fsl,drive-strength = <MXS_DRIVE_8mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_ENABLE>;
+				};
+
+				mmc1_8bit_pins_a: mmc1-8bit at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						MX23_PAD_GPMI_D00__SSP2_DATA0
+						MX23_PAD_GPMI_D01__SSP2_DATA1
+						MX23_PAD_GPMI_D02__SSP2_DATA2
+						MX23_PAD_GPMI_D03__SSP2_DATA3
+						MX23_PAD_GPMI_D04__SSP2_DATA4
+						MX23_PAD_GPMI_D05__SSP2_DATA5
+						MX23_PAD_GPMI_D06__SSP2_DATA6
+						MX23_PAD_GPMI_D07__SSP2_DATA7
+						MX23_PAD_GPMI_RDY1__SSP2_CMD
+						MX23_PAD_GPMI_WRN__SSP2_SCK
+					>;
+					fsl,drive-strength = <MXS_DRIVE_8mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_ENABLE>;
+				};
+
 				pwm2_pins_a: pwm2 at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
Signature · 1 line
2.7.0
#1 lore raw

PATCH 2/4 ARM: mxs: dts: Add AUART2 pinmux

From: Marek Vasut <[email protected]>

Add 2-pin pinmux settings for AUART2.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>
---
 arch/arm/boot/dts/imx23.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx23.dtsi +11 -0
index c70ebef..0c9a357e 100644
@@ -171,6 +171,17 @@
 					fsl,pull-up = <MXS_PULL_DISABLE>;
 				};
 
+				auart1_2pins_a: auart1-2pins at 0 {
+					reg = <0>;
+					fsl,pinmux-ids = <
+						MX23_PAD_GPMI_D14__AUART2_RX
+						MX23_PAD_GPMI_D15__AUART2_TX
+					>;
+					fsl,drive-strength = <MXS_DRIVE_4mA>;
+					fsl,voltage = <MXS_VOLTAGE_HIGH>;
+					fsl,pull-up = <MXS_PULL_DISABLE>;
+				};
+
 				gpmi_pins_a: gpmi-nand at 0 {
 					reg = <0>;
 					fsl,pinmux-ids = <
Signature · 1 line
2.7.0
#2 lore raw

PATCH v2 3/4 ARM: mxs: dts: Add Creative X-Fi3 support

In reply to Marek Vasut

From: Marek Vasut <[email protected]>

Add support for this small MP3 player based on STMP3780 (rev.4). Currently supported is both external microSD and internal SD-NAND bridge, PWM and USB gadget.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>

---
V2: - Fix the button nodes to not generate possible DT warning
- Drop the address part from the license

---
 arch/arm/boot/dts/Makefile       |   1 +
 arch/arm/boot/dts/imx23-xfi3.dts | 183 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 184 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx23-xfi3.dts
arch/arm/boot/dts/Makefile +1 -0
index 8f9f1c2..7a79d37 100644
@@ -417,6 +417,7 @@ dtb-$(CONFIG_ARCH_MXS) += \
 	imx23-evk.dtb \
 	imx23-olinuxino.dtb \
 	imx23-stmp378x_devb.dtb \
+	imx23-xfi3.dtb \
 	imx28-apf28.dtb \
 	imx28-apf28dev.dtb \
 	imx28-apx4devkit.dtb \
arch/arm/boot/dts/imx23-xfi3.dts new file +183 -0

183 lines not on this page · raw message

Signature · 1 line
2.7.0
#3 lore raw

PATCH v2 3/4 ARM: mxs: dts: Add Creative X-Fi3 support

Am 08.05.2016 um 22:50 schrieb Marek Vasut:

Quoted 6 lines

From: Marek Vasut <[email protected]>

Add support for this small MP3 player based on STMP3780 (rev.4). Currently supported is both external microSD and internal SD-NAND bridge, PWM and USB gadget.

Quoted 7 lines
Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>

---
V2: - Fix the button nodes to not generate possible DT warning
- Drop the address part from the license
---

Thanks

#4 lore raw

PATCH v2 3/4 ARM: mxs: dts: Add Creative X-Fi3 support

In reply to Marek Vasut

arch/arm/boot/dts/imx23-xfi3.dts line 155

Quoted 11 lines · Marek Vasut
arch/arm/boot/dts/imx23-xfi3.dts new file +11 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 7 0>;
+		};
+	};

For new dts, we suggest put fixed regulator node directly under root in the following naming scheme:

	reg_xxx: regulator-xxx {
		...
	};

Also, the order of subject prefix is like ARM: dts: mxs: ...

Shawn

#5 lore raw

PATCH v2 3/4 ARM: mxs: dts: Add Creative X-Fi3 support

Quoted 16 lines · Shawn Guo

arch/arm/boot/dts/imx23-xfi3.dts line 155

Quoted 11 lines · Marek Vasut
arch/arm/boot/dts/imx23-xfi3.dts new file +11 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 7 0>;
+		};
+	};

For new dts, we suggest put fixed regulator node directly under root in the following naming scheme:

Quoted 5 lines
	reg_xxx: regulator-xxx {
		...
	};

Also, the order of subject prefix is like ARM: dts: mxs: ...

I see, can you do this trivial fix while applying ?

Thanks

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

In reply to Marek Vasut

From: Marek Vasut <[email protected]>

Add support for this small MP3 player based on STMP3780 (rev.3). Currently supported are both external microSD and internal SD-NAND bridge, PWM and USB gadget.

Cc Fabio Estevam <[email protected]>
Cc Shawn Guo <[email protected]>

---
V2: - Drop the address part from the license

---
 arch/arm/boot/dts/Makefile        |   1 +
 arch/arm/boot/dts/imx23-sansa.dts | 211 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 212 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx23-sansa.dts
arch/arm/boot/dts/Makefile +1 -0
index 7a79d37..eaa8048 100644
@@ -416,6 +416,7 @@ dtb-$(CONFIG_SOC_VF610) += \
 dtb-$(CONFIG_ARCH_MXS) += \
 	imx23-evk.dtb \
 	imx23-olinuxino.dtb \
+	imx23-sansa.dtb \
 	imx23-stmp378x_devb.dtb \
 	imx23-xfi3.dtb \
 	imx28-apf28.dtb \
arch/arm/boot/dts/imx23-sansa.dts new file +211 -0

211 lines not on this page · raw message

Signature · 1 line
2.7.0
#7 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

arch/arm/boot/dts/imx23-sansa.dts line 134

Quoted 4 lines · Marek Vasut
arch/arm/boot/dts/imx23-sansa.dts new file +4 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {

Put fixed regulator nodes directly under root with suggested naming scheme.

Quoted 34 lines
arch/arm/boot/dts/imx23-sansa.dts new file +34 -0
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 8 0>;
+		};
+
+		reg_vddio_sd1: vddio-sd1 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd1";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio1 29 0>;
+		};
+
+		reg_vdd_touchpad: vdd-touchpad0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-touchpad0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 26 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+
+		reg_vdd_tuner: vdd-tuner0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-tuner0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 29 0>;
+			regulator-always-on;
+			enable-active-low;
+		};

arch/arm/boot/dts/imx23-sansa.dts line 178

Quoted 10 lines
arch/arm/boot/dts/imx23-sansa.dts new file +10 -0
+	};
+
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 2 5000000>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+	};
+
+	i2c at 0 {

The @unit-address should be used for nodes with 'reg' property.

Shawn

Quoted 41 lines
arch/arm/boot/dts/imx23-sansa.dts new file +33 -0
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "i2c-gpio";
+		gpios = <
+			&gpio1 24 0		/* SDA */
+			&gpio1 22 0		/* SCL */
+		>;
+		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
+	};
+
+	i2c at 1 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "i2c-gpio";
+		gpios = <
+			&gpio0 31 0		/* SDA */
+			&gpio0 30 0		/* SCL */
+		>;
+		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
+
+		touch: touch at 20 {
+			compatible = "synaptics,synaptics_i2c";
+			reg = <0x20>;
+		};
+
+		eeprom: eeprom at 50 {
+			compatible = "atmel,24c64";
+			reg = <0x50>;
+			pagesize = <32>;
+		};
+	};
+
+};
Signature · 7 lines
2.7.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#8 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

Quoted 47 lines · Shawn Guo

arch/arm/boot/dts/imx23-sansa.dts line 134

Quoted 4 lines · Marek Vasut
arch/arm/boot/dts/imx23-sansa.dts new file +4 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {

Put fixed regulator nodes directly under root with suggested naming scheme.

Quoted 38 lines
arch/arm/boot/dts/imx23-sansa.dts new file +38 -0
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 8 0>;
+		};
+
+		reg_vddio_sd1: vddio-sd1 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd1";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio1 29 0>;
+		};
+
+		reg_vdd_touchpad: vdd-touchpad0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-touchpad0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 26 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+
+		reg_vdd_tuner: vdd-tuner0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-tuner0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 29 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+	};
+
+	backlight {
+		compatible = "pwm-backlight";
Quoted 8 lines

arch/arm/boot/dts/imx23-sansa.dts line 178

Quoted 6 lines
arch/arm/boot/dts/imx23-sansa.dts new file +6 -0
+		pwms = <&pwm 2 5000000>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+	};
+
+	i2c at 0 {

The @unit-address should be used for nodes with 'reg' property.

Can you please do such minor fixes when applying or do you expect a resend ?

Quoted 43 lines

Shawn

Quoted 41 lines
arch/arm/boot/dts/imx23-sansa.dts new file +33 -0
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "i2c-gpio";
+		gpios = <
+			&gpio1 24 0		/* SDA */
+			&gpio1 22 0		/* SCL */
+		>;
+		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
+	};
+
+	i2c at 1 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "i2c-gpio";
+		gpios = <
+			&gpio0 31 0		/* SDA */
+			&gpio0 30 0		/* SCL */
+		>;
+		i2c-gpio,delay-us = <2>;	/* ~100 kHz */
+
+		touch: touch at 20 {
+			compatible = "synaptics,synaptics_i2c";
+			reg = <0x20>;
+		};
+
+		eeprom: eeprom at 50 {
+			compatible = "atmel,24c64";
+			reg = <0x50>;
+			pagesize = <32>;
+		};
+	};
+
+};
Signature · 7 lines
2.7.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
Best regards,
Marek Vasut
#9 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

Quoted 57 lines · Marek Vasut
Quoted 47 lines · Shawn Guo

arch/arm/boot/dts/imx23-sansa.dts line 134

Quoted 4 lines · Marek Vasut
arch/arm/boot/dts/imx23-sansa.dts new file +4 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {

Put fixed regulator nodes directly under root with suggested naming scheme.

Quoted 38 lines
arch/arm/boot/dts/imx23-sansa.dts new file +38 -0
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 8 0>;
+		};
+
+		reg_vddio_sd1: vddio-sd1 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd1";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio1 29 0>;
+		};
+
+		reg_vdd_touchpad: vdd-touchpad0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-touchpad0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 26 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+
+		reg_vdd_tuner: vdd-tuner0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-tuner0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 29 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+	};
+
+	backlight {
+		compatible = "pwm-backlight";
Quoted 8 lines

arch/arm/boot/dts/imx23-sansa.dts line 178

Quoted 6 lines
arch/arm/boot/dts/imx23-sansa.dts new file +6 -0
+		pwms = <&pwm 2 5000000>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+	};
+
+	i2c at 0 {

The @unit-address should be used for nodes with 'reg' property.

Quoted 1 line

Can you please do such minor fixes when applying or do you expect a resend ?

Such minor fixes are just too many to be fixed by myself. Please resend.

Shawn

#10 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

Quoted 58 lines · Shawn Guo
Quoted 57 lines · Marek Vasut
Quoted 55 lines · Shawn Guo

arch/arm/boot/dts/imx23-sansa.dts line 134

Quoted 4 lines · Marek Vasut
arch/arm/boot/dts/imx23-sansa.dts new file +4 -0
+	regulators {
+		compatible = "simple-bus";
+
+		reg_vddio_sd0: vddio-sd0 {

Put fixed regulator nodes directly under root with suggested naming scheme.

Quoted 34 lines
arch/arm/boot/dts/imx23-sansa.dts new file +34 -0
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 8 0>;
+		};
+
+		reg_vddio_sd1: vddio-sd1 {
+			compatible = "regulator-fixed";
+			regulator-name = "vddio-sd1";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio1 29 0>;
+		};
+
+		reg_vdd_touchpad: vdd-touchpad0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-touchpad0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 26 0>;
+			regulator-always-on;
+			enable-active-low;
+		};
+
+		reg_vdd_tuner: vdd-tuner0 {
+			compatible = "regulator-fixed";
+			regulator-name = "vdd-tuner0";
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3300000>;
+			gpio = <&gpio0 29 0>;
+			regulator-always-on;
+			enable-active-low;
+		};

arch/arm/boot/dts/imx23-sansa.dts line 178

Quoted 10 lines
arch/arm/boot/dts/imx23-sansa.dts new file +10 -0
+	};
+
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pwm 2 5000000>;
+		brightness-levels = <0 4 8 16 32 64 128 255>;
+		default-brightness-level = <6>;
+	};
+
+	i2c at 0 {

The @unit-address should be used for nodes with 'reg' property.

Quoted 4 lines
Quoted 1 line

Can you please do such minor fixes when applying or do you expect a resend ?

Such minor fixes are just too many to be fixed by myself. Please resend.

I see. Would you be able to review them in less than one month please ? It is extremely demotivating to wait over a month only to get a review with a few nitpicks and request to resend.

Signature · 2 lines
Best regards,
Marek Vasut
#11 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

Quoted 3 lines · Marek Vasut

I see. Would you be able to review them in less than one month please ? It is extremely demotivating to wait over a month only to get a review with a few nitpicks and request to resend.

Sure, that's really something I'm trying to avoid. I definitely won't let the review delay get patches miss the merge window. So one month should be the worst case when my paid job get me so busy.

BTW, today is the public holiday in China.

Shawn

#12 lore raw

PATCH v2 4/4 ARM: mxs: dts: Add SanDisk Sansa Fuze+ support

Quoted 8 lines · Shawn Guo
Quoted 3 lines · Marek Vasut

I see. Would you be able to review them in less than one month please ? It is extremely demotivating to wait over a month only to get a review with a few nitpicks and request to resend.

Sure, that's really something I'm trying to avoid. I definitely won't let the review delay get patches miss the merge window. So one month should be the worst case when my paid job get me so busy.

I see, thanks.

Quoted 4 lines

BTW, today is the public holiday in China.

Shawn

Signature · 2 lines
Best regards,
Marek Vasut