Skip to contentSkip to conversation

ARM: imx6ul: Fix Micrel PHY mask

PATCH New Fabio Estevam 3 participants 4 messages May 11, 2016 – Jun 9, 2016

Subsystems (4)
Stable branch Arm (32-bit) Arm sub-architectures Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: imx6ul: Fix Micrel PHY mask

From: Fabio Estevam <[email protected]>

The value used for Micrel PHY mask is not correct. Use the MICREL_PHY_ID_MASK definition instead.

Thanks to Jiri Luznicky for proposing the fix at
https://community.freescale.com/thread/387739

Cc <[email protected]>
Fixes 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/mach-imx/mach-imx6ul.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mach-imx6ul.c +1 -1
index a38b16b..b56de4b 100644
@@ -46,7 +46,7 @@ static int ksz8081_phy_fixup(struct phy_device *dev)
 static void __init imx6ul_enet_phy_init(void)
 {
 	if (IS_BUILTIN(CONFIG_PHYLIB))
-		phy_register_fixup_for_uid(PHY_ID_KSZ8081, 0xffffffff,
+		phy_register_fixup_for_uid(PHY_ID_KSZ8081, MICREL_PHY_ID_MASK,
 					   ksz8081_phy_fixup);
 }
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: imx6ul: Fix Micrel PHY mask

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The value used for Micrel PHY mask is not correct. Use the MICREL_PHY_ID_MASK definition instead.

Thanks to Jiri Luznicky for proposing the fix at
https://community.freescale.com/thread/387739

Cc <[email protected]>
Fixes 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Andrew Lunn <[email protected]>

It would be nice if drivers/net/phy/micrel.c was to use MICREL_PHY_ID_MASK. But that is a different patch.

Thanks
Andrew

author reviewer
#2 lore raw

PATCH 1/1 ARM: imx6ul: Fix Micrel PHY mask

Quoted 4 lines · Andrew Lunn
Reviewed-by Andrew Lunn <[email protected]>

It would be nice if drivers/net/phy/micrel.c was to use MICREL_PHY_ID_MASK. But that is a different patch.

Good suggestion. I will submit a patch doing this. Thanks

Applied
#3 lore raw

PATCH 1/1 ARM: imx6ul: Fix Micrel PHY mask

In reply to Fabio Estevam
Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The value used for Micrel PHY mask is not correct. Use the MICREL_PHY_ID_MASK definition instead.

Thanks to Jiri Luznicky for proposing the fix at
https://community.freescale.com/thread/387739

Cc <[email protected]>
Fixes 709bc0657fe6f9f55 ("ARM: imx6ul: add fec MAC refrence clock and phy fixup init")
Signed-off-by Fabio Estevam <[email protected]>

Applied, thanks.