toshiba_acpi: Accelerometer updates
Subsystems (2)
Azael Avalos
maintainercover toshiba_acpi: Accelerometer updates
These series of patches update the accelerometer axis data reporting to use the IIO subsystem, deprecating the custom position sysfs entry, and finally bumping the driver version to 0.24.
Azael Avalos (3):
toshiba_acpi: Add IIO interface for accelerometer axis data
toshiba_acpi: Remove the position sysfs entry
toshiba_acpi: Bump driver version and update copyrignt year
drivers/platform/x86/toshiba_acpi.c | 147 +++++++++++++++++++++++++++++------- 1 file changed, 120 insertions(+), 27 deletions(-)
Signature · 1 line
2.8.3
Azael Avalos
maintainerPATCH 2/3 toshiba_acpi: Remove the position sysfs entry
Now that we have proper support for the acceleromeer under the IIO subsystem, the _position_ sysfs file is now deprecated.
This patch removes all code related to the position sysfs entry.
--- drivers/platform/x86/toshiba_acpi.c | 29 ----------------------------- 1 file changed, 29 deletions(-)
drivers/platform/x86/toshiba_acpi.c +0 -29
@@ -1961,32 +1961,6 @@ static ssize_t touchpad_show(struct device *dev, }static DEVICE_ATTR_RW (touchpad); -static ssize_t position_show (struct device *dev, -struct device_attribute *attr,char *buf) -{ -struct toshiba_acpi_dev *toshiba =dev_get_drvdata (dev); -u32 xyval, zval; -int x, y, z; -int ret; - - xyval = zval =0 ; - ret =toshiba_accelerometer_get (toshiba, &xyval, &zval); -if (ret <0 ) -return ret; - -/* Accelerometer values */ - x = xyval &HCI_ACCEL_MASK ; - y = (xyval >>HCI_MISC_SHIFT ) &HCI_ACCEL_MASK ; - z = zval &HCI_ACCEL_MASK ; -/* Movement direction */ - x *= xyval &HCI_ACCEL_DIRECTION_MASK ?-1 :1 ; - y *= (xyval >>HCI_MISC_SHIFT ) &HCI_ACCEL_DIRECTION_MASK ?-1 :1 ; - z *= zval &HCI_ACCEL_DIRECTION_MASK ?-1 :1 ; - -return sprintf (buf,"%d %d %d\n" , x, y, z); -} -static DEVICE_ATTR_RO (position); -static ssize_t usb_sleep_charge_show (struct device *dev,struct device_attribute *attr,char *buf) {
@@ -2357,7 +2331,6 @@ static struct attribute *toshiba_attributes[] = { &dev_attr_available_kbd_modes.attr, &dev_attr_kbd_backlight_timeout.attr, &dev_attr_touchpad.attr, - &dev_attr_position.attr, &dev_attr_usb_sleep_charge.attr, &dev_attr_sleep_functions_on_battery.attr, &dev_attr_usb_rapid_charge.attr,
@@ -2384,8 +2357,6 @@ static umode_t toshiba_sysfs_is_visible(struct kobject *kobj, exists = (drv->kbd_mode ==SCI_KBD_MODE_AUTO ) ? true : false; else if (attr == &dev_attr_touchpad.attr) exists = (drv->touchpad_supported) ? true : false; - else if (attr == &dev_attr_position.attr) - exists = (drv->accelerometer_supported) ? true : false; else if (attr == &dev_attr_usb_sleep_charge.attr) exists = (drv->usb_sleep_charge_supported) ? true : false; else if (attr == &dev_attr_sleep_functions_on_battery.attr)
Signature · 1 line
2.8.3
Azael Avalos
maintainerPATCH 3/3 toshiba_acpi: Bump driver version and update copyrignt year
In reply to Azael AvalosAfter several fixes, and added support for more features (WWAN, Cooling Method and IIO accelometer axis data), bump the driver version to 0.24.
Also update the copyright year.
--- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/toshiba_acpi.c +2 -2
@@ -4,7 +4,7 @@* Copyright (C) 2002-2004 John Belmonte * Copyright (C) 2008 Philip Langdale * Copyright (C) 2010 Pierre Ducroquet -* Copyright (C) 2014-2015 Azael Avalos +* Copyright (C) 2014-2016 Azael Avalos * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by
@@ -31,7 +31,7 @@#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt -#define TOSHIBA_ACPI_VERSION "0.23" +#define TOSHIBA_ACPI_VERSION "0.24"#define PROC_INTERFACE_VERSION 1#include <linux/kernel.h>
Signature · 1 line
2.8.3