Skip to contentSkip to conversation

Document the 'svn propset' command.

PATCH In review Alfred Perlstein 5 participants 11 messages Jun 16, 2016 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Document the 'svn propset' command.

Junio + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset

---
 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/git-svn.txt +14 -0
index fb23a98..e104824 100644
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
Signature · 1 line
2.7.1
#1 lore raw

Hey Alfred,

Quoted 11 lines · Alfred Perlstein

Junio + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset

I am not particularly sure whether the above could form a good commit message. I think you wanted to include this as a comment. git-am picks up these patches. The title commit is taken from the subject stripping the '[PATCH]'. Then the body before '---' is taken as the rest of the commit message. Then the diff is applied. To include comments add them after ---. Also please have a look at Documentation/SubmittingPatches. Also missing signoff. For the patch to actually be accept you need to follow those instructions. Thanks for contributing.

Quoted 19 lines
---
 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/git-svn.txt +7 -0
index fb23a98..e104824 100644
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
        Gets the Subversion property given as the first argument, for a
        file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+       Sets the Subversion property given as the first argument, to the
+       value given as the second argument for the file given as the
+       third argument.
++
+Example:
++

Documentation/git-svn.txt Any other arguments are passed directly to 'git log' · line 478

Quoted 10 lines
Documentation/git-svn.txt +7 -0
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
        Shows the Subversion externals.  Use -r/--revision to specify a
        specific revision.

Regards,
Pranit Bauva

#2 lore raw

Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"?

-Alfred

Quoted 55 lines · Pranit Bauva

Hey Alfred,

Quoted 11 lines · Alfred Perlstein

Junio + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset

I am not particularly sure whether the above could form a good commit message. I think you wanted to include this as a comment. git-am picks up these patches. The title commit is taken from the subject stripping the '[PATCH]'. Then the body before '---' is taken as the rest of the commit message. Then the diff is applied. To include comments add them after ---. Also please have a look at Documentation/SubmittingPatches. Also missing signoff. For the patch to actually be accept you need to follow those instructions. Thanks for contributing.

Quoted 19 lines
---
  Documentation/git-svn.txt | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
Documentation/git-svn.txt +7 -0
index fb23a98..e104824 100644
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
         Gets the Subversion property given as the first argument, for a
         file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+       Sets the Subversion property given as the first argument, to the
+       value given as the second argument for the file given as the
+       third argument.
++
+Example:
++

Documentation/git-svn.txt Any other arguments are passed directly to 'git log' · line 478

Quoted 10 lines
Documentation/git-svn.txt +7 -0
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
  'show-externals'::
         Shows the Subversion externals.  Use -r/--revision to specify a
         specific revision.

Regards,
Pranit Bauva

#3 lore raw

Hey Alfred,

Quoted 4 lines · Alfred Perlstein

Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"?

Signoff is used to indicate that you are OKAY with releasing your patch according to git's license. For more details see the Documentation/SubmittingPatches[1]. To summarize you will have to add this in the end :

Though I will still recommend you to go through [1] properly.

Regards,
Pranit Bauva

#4 lore raw

Hey Alfred,

Quoted 8 lines · Pranit Bauva

Hey Alfred,

Quoted 4 lines · Alfred Perlstein

Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"?

Quoted 8 lines

Signoff is used to indicate that you are OKAY with releasing your patch according to git's license. For more details see the Documentation/SubmittingPatches[1]. To summarize you will have to add this in the end :

Though I will still recommend you to go through [1] properly.

Oops I forgot to put the link.

[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307

Regards,
Pranit Bauva

#5 lore raw
Quoted 15 lines · Pranit Bauva

Hey Alfred,

Quoted 12 lines · Pranit Bauva

Hey Alfred,

Quoted 4 lines · Alfred Perlstein

Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"?

Signoff is used to indicate that you are OKAY with releasing your patch according to git's license. For more details see the Documentation/SubmittingPatches[1]. To summarize you will have to add this in the end :

Quoted 7 lines
Quoted 3 lines

Though I will still recommend you to go through [1] properly.

Oops I forgot to put the link.

[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307

Pranit,

Ah thank you!!! This clarifies. I will resend the patch tonight.

-Alfred

#6 lore raw

PATCH 1/1 Document the 'svn propset' command.

In reply to Alfred Perlstein

Add example usage to the git-svn documentation.

---

Junio, Pranit, + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here:
https://github.com/splbio/git/tree/document_propset

 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/git-svn.txt +14 -0
index fb23a98..e104824 100644
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
Signature · 1 line
2.7.1
#7 lore raw
Quoted 6 lines · Alfred Perlstein

Add example usage to the git-svn documentation.

---

Quoted 8 lines

Junio, Pranit, + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

Thanks Alfred,

I've removed the '.' from the commit subject, signed-off, and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:

Git 2.9 (2016-06-13 10:42:13 -0700)

are available in the git repository at:

git://bogomips.org/git-svn.git svn-propset-doc

for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:

Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

----------------------------------------------------------------
Alfred Perlstein (1):
Document the 'svn propset' command

 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
#8 lore raw
Quoted 9 lines · Eric Wong

Thanks Alfred,

I've removed the '.' from the commit subject, signed-off, and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:

Git 2.9 (2016-06-13 10:42:13 -0700)

Quoted 7 lines

are available in the git repository at:

git://bogomips.org/git-svn.git svn-propset-doc

for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:

Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
support for git-svn propset, 2014-12-07) so that it could go to older maintenance tracks.

I will pick up your Reviewed-by: and redo it. Thanks.

#9 lore raw
Quoted 21 lines · Junio C Hamano
Quoted 15 lines · Eric Wong

Thanks Alfred,

I've removed the '.' from the commit subject, signed-off, and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:

Git 2.9 (2016-06-13 10:42:13 -0700)

are available in the git repository at:

git://bogomips.org/git-svn.git svn-propset-doc

for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:

Quoted 8 lines
Quoted 1 line

Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
support for git-svn propset, 2014-12-07) so that it could go to older maintenance tracks.

I will pick up your Reviewed-by: and redo it. Thanks.

Thank you, always great working with the git project!

-Alfred

#10 lore raw
Quoted 27 lines · Alfred Perlstein
Quoted 26 lines · Junio C Hamano
Quoted 9 lines · Eric Wong

Thanks Alfred,

I've removed the '.' from the commit subject, signed-off, and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:

Git 2.9 (2016-06-13 10:42:13 -0700)

Quoted 7 lines

are available in the git repository at:

git://bogomips.org/git-svn.git svn-propset-doc

for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:

Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
support for git-svn propset, 2014-12-07) so that it could go to older maintenance tracks.

Quoted 6 lines
Quoted 2 lines

I will pick up your Reviewed-by: and redo it. Thanks.

Thank you, always great working with the git project!

-Alfred

Thanks for addressing this!

- Joe