Skip to contentSkip to conversation

arm64: defconfig: disable plain NEON implementation of AES

PATCH New Ard Biesheuvel 2 participants 2 messages Jun 13, 2016 – Jun 14, 2016

lore
Share & tools
lore

Ard Biesheuvel

author
#0 lore raw

PATCH 1/1 arm64: defconfig: disable plain NEON implementation of AES

The plain NEON implementation of AES is only suited for v8 cores that lack the ARMv8 Crypto Extensions but have an implementation of the NEON tbl/tbx instruction that is not pathetically slow. Unfortunately, this is currently the empty set, so there is no point in including this implementation by default. So disable it.

Signed-off-by Ard Biesheuvel <[email protected]>
---
 arch/arm64/configs/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/configs/defconfig +1 -1
index fd2d74d0491e..ab76f74e859b 100644
@@ -343,5 +343,5 @@ CONFIG_CRYPTO_SHA2_ARM64_CE=y
 CONFIG_CRYPTO_GHASH_ARM64_CE=y
 CONFIG_CRYPTO_AES_ARM64_CE_CCM=y
 CONFIG_CRYPTO_AES_ARM64_CE_BLK=y
-CONFIG_CRYPTO_AES_ARM64_NEON_BLK=y
+# CONFIG_CRYPTO_AES_ARM64_NEON_BLK is not set
 CONFIG_CRYPTO_CRC32_ARM64=y
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 arm64: defconfig: disable plain NEON implementation of AES

Quoted 7 lines · Ard Biesheuvel

The plain NEON implementation of AES is only suited for v8 cores that lack the ARMv8 Crypto Extensions but have an implementation of the NEON tbl/tbx instruction that is not pathetically slow. Unfortunately, this is currently the empty set, so there is no point in including this implementation by default. So disable it.

Signed-off-by Ard Biesheuvel <[email protected]>

Applied, thanks.

-Olof