Skip to contentSkip to conversation

liquidio: a couple indenting tweaks

PATCH In review Dan Carpenter 2 participants 2 messages Jun 18, 2016 – Jun 22, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Cavium liquidio network driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/3 liquidio: a couple indenting tweaks

Remove a stray space character and fix an if statement that wasn't indented.

Signed-off-by Dan Carpenter <[email protected]>

---
Speaking of style issues, this whole file follows return 1 on error and 0 on success. It was confusing for me. It's not too late to change it to use correct error codes. ;)

drivers/net/ethernet/cavium/liquidio/lio_main.c +3 -3
index d0ab97c..715ddfa 100644
@@ -365,7 +365,7 @@ static int wait_for_pending_requests(struct octeon_device *oct)
 				[OCTEON_ORDERED_SC_LIST].pending_req_count);
 		if (pcount)
 			schedule_timeout_uninterruptible(HZ / 10);
-		 else
+		else
 			break;
 	}
 

@@ -3351,8 +3351,8 @@ static int setup_nic_devices(struct octeon_device *octeon_dev)
 		liquidio_set_ethtool_ops(netdev);
 
 		if (netdev->features & NETIF_F_LRO)
-		liquidio_set_feature(netdev, OCTNET_CMD_LRO_ENABLE,
-				     OCTNIC_LROIPV4 | OCTNIC_LROIPV6);
+			liquidio_set_feature(netdev, OCTNET_CMD_LRO_ENABLE,
+					     OCTNIC_LROIPV4 | OCTNIC_LROIPV6);
 
 		if ((debug != -1) && (debug & NETIF_MSG_HW))
 			liquidio_set_feature(netdev, OCTNET_CMD_VERBOSE_ENABLE,
maintainer
#1 lore raw

Dan, please don't mix bug fixes and cleanups in the same patch series.